Patchwork [[PATCH,v3] ] populate_sdk_base.bbclass: Make it possible to override the create_shar method of populate_sdk_base.

login
mail settings
Submitter Martin Ertsaas
Date Oct. 8, 2012, 10:43 a.m.
Message ID <1349693030-31861-1-git-send-email-mertsas@cisco.com>
Download mbox | patch
Permalink /patch/37919/
State New
Headers show

Comments

Martin Ertsaas - Oct. 8, 2012, 10:43 a.m.
From: Thomas Kristensen <thkriste@cisco.com>

If you wish to change the install/unpack method of the sdk, this can now be done by making
your own create_shar method, and setting a SDK_PACKAGING_FUNC variable to your
new create_shar function.

Signed-off-by: Thomas Kristensen <thkriste@cisco.com>
---
 meta/classes/populate_sdk_base.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Martin Ertsaas - Oct. 15, 2012, 6:56 a.m.
On 10/08/12 12:43, Martin Ertsaas wrote:
> From: Thomas Kristensen <thkriste@cisco.com>
>
> If you wish to change the install/unpack method of the sdk, this can now be done by making
> your own create_shar method, and setting a SDK_PACKAGING_FUNC variable to your
> new create_shar function.
>
> Signed-off-by: Thomas Kristensen <thkriste@cisco.com>
> ---
>  meta/classes/populate_sdk_base.bbclass |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 1c151d7..762ba12 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -24,6 +24,8 @@ PID = "${@os.getpid()}"
>  
>  EXCLUDE_FROM_WORLD = "1"
>  
> +SDK_PACKAGING_FUNC ?= "create_shar"
> +
>  python () {
>      # If we don't do this we try and run the mapping hooks while parsing which is slow
>      # bitbake should really provide something to let us know this...
> @@ -56,7 +58,7 @@ fakeroot python do_populate_sdk() {
>  
>      bb.build.exec_func("tar_sdk", d)
>  
> -    bb.build.exec_func("create_shar", d)
> +    bb.build.exec_func(d.getVar("SDK_PACKAGING_FUNC", True), d)
>  }
>  
>  fakeroot populate_sdk_image() {
Have anyone had time to look at this, and if so, is it suitable for
upstream?

- Martin
Saul Wold - Oct. 18, 2012, 8:08 p.m.
On 10/08/2012 03:43 AM, Martin Ertsaas wrote:
> From: Thomas Kristensen <thkriste@cisco.com>
>
> If you wish to change the install/unpack method of the sdk, this can now be done by making
> your own create_shar method, and setting a SDK_PACKAGING_FUNC variable to your
> new create_shar function.
>
> Signed-off-by: Thomas Kristensen <thkriste@cisco.com>
> ---
>   meta/classes/populate_sdk_base.bbclass |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 1c151d7..762ba12 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -24,6 +24,8 @@ PID = "${@os.getpid()}"
>
>   EXCLUDE_FROM_WORLD = "1"
>
> +SDK_PACKAGING_FUNC ?= "create_shar"
> +
>   python () {
>       # If we don't do this we try and run the mapping hooks while parsing which is slow
>       # bitbake should really provide something to let us know this...
> @@ -56,7 +58,7 @@ fakeroot python do_populate_sdk() {
>
>       bb.build.exec_func("tar_sdk", d)
>
> -    bb.build.exec_func("create_shar", d)
> +    bb.build.exec_func(d.getVar("SDK_PACKAGING_FUNC", True), d)
>   }
>
>   fakeroot populate_sdk_image() {
>
Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
index 1c151d7..762ba12 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -24,6 +24,8 @@  PID = "${@os.getpid()}"
 
 EXCLUDE_FROM_WORLD = "1"
 
+SDK_PACKAGING_FUNC ?= "create_shar"
+
 python () {
     # If we don't do this we try and run the mapping hooks while parsing which is slow
     # bitbake should really provide something to let us know this...
@@ -56,7 +58,7 @@  fakeroot python do_populate_sdk() {
 
     bb.build.exec_func("tar_sdk", d)
 
-    bb.build.exec_func("create_shar", d)
+    bb.build.exec_func(d.getVar("SDK_PACKAGING_FUNC", True), d)
 }
 
 fakeroot populate_sdk_image() {