Patchwork [meta-oe,v3] iw: add iw 3.6 recipe

login
register
mail settings
Submitter jackie huang
Date Oct. 5, 2012, 1:39 a.m.
Message ID <1349401196-24611-1-git-send-email-jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/37793/
State Superseded
Headers show

Comments

jackie huang - Oct. 5, 2012, 1:39 a.m.
iw: add iw 3.6 recipe

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta-oe/recipes-connectivity/iw/iw_3.6.bb |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-connectivity/iw/iw_3.6.bb
Andrei Gherzan - Oct. 5, 2012, 10:20 a.m.
Hello,

On Fri, Oct 5, 2012 at 4:39 AM, <jackie.huang@windriver.com> wrote:

> iw: add iw 3.6 recipe
>

Don't copy the subject here.


>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta-oe/recipes-connectivity/iw/iw_3.6.bb |   23 +++++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-connectivity/iw/iw_3.6.bb
>
> diff --git a/meta-oe/recipes-connectivity/iw/iw_3.6.bbb/meta-oe/recipes-connectivity/iw/
> iw_3.6.bb
> new file mode 100644
> index 0000000..42a43c3
> --- /dev/null
> +++ b/meta-oe/recipes-connectivity/iw/iw_3.6.bb
> @@ -0,0 +1,23 @@
> +SUMMARY = "nl80211 based CLI configuration utility for wireless devices"
> +DESCRIPTION = "iw is a new nl80211 based CLI configuration utility for \
> +wireless devices. It supports almost all new drivers that have been added
> \
> +to the kernel recently. "
> +HOMEPAGE = "http://linuxwireless.org/en/users/Documentation/iw"
> +SECTION = "base"
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=878618a5c4af25e9b93ef0be1a93f774"
> +
> +DEPENDS = "libnl pkgconfig"
> +
> +SRC_URI = "http://wireless.kernel.org/download/iw/${P}.tar.bz2 \
> +
> file://0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch \
> +          "
> +
> +SRC_URI[md5sum] = "1c18bfbbc8773629e5e8ac733a39540c"
> +SRC_URI[sha256sum] =
> "df11036ac11df31f44083da962a6e9c74bdea7c01c596c4b5840f948cdb6c857"
> +
> +EXTRA_OEMAKE = ""
> +
>

Do you really need this?

+do_install() {
> +       oe_runmake DESTDIR=${D} install
>

Why don't you add DESTDIR=${D} to EXTRA_OEMAKE and drop the install rule?

ag
Koen Kooi - Oct. 6, 2012, 11:16 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 05-10-12 03:39, jackie.huang@windriver.com schreef:
> iw: add iw 3.6 recipe
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>

Is there a strong reason to keep the old recipe?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQcBMRMkyGM64RGpERAjETAKCoJ9Uxn+mkwVmidt0COiXE7cXFGgCgkjaP
3A0vZJwg6gsdyDuP0DYAsS8=
=bBXN
-----END PGP SIGNATURE-----
jackie huang - Oct. 8, 2012, 5:27 a.m.
On 10/5/2012 6:20 PM, Andrei Gherzan wrote:
> Hello,
>
> On Fri, Oct 5, 2012 at 4:39 AM, <jackie.huang@windriver.com> wrote:
>
>> iw: add iw 3.6 recipe
>>
>
> Don't copy the subject here.
>
>
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>>   meta-oe/recipes-connectivity/iw/iw_3.6.bb |   23 +++++++++++++++++++++++
>>   1 files changed, 23 insertions(+), 0 deletions(-)
>>   create mode 100644 meta-oe/recipes-connectivity/iw/iw_3.6.bb
>>
>> diff --git a/meta-oe/recipes-connectivity/iw/iw_3.6.bbb/meta-oe/recipes-connectivity/iw/
>> iw_3.6.bb
>> new file mode 100644
>> index 0000000..42a43c3
>> --- /dev/null
>> +++ b/meta-oe/recipes-connectivity/iw/iw_3.6.bb
>> @@ -0,0 +1,23 @@
>> +SUMMARY = "nl80211 based CLI configuration utility for wireless devices"
>> +DESCRIPTION = "iw is a new nl80211 based CLI configuration utility for \
>> +wireless devices. It supports almost all new drivers that have been added
>> \
>> +to the kernel recently. "
>> +HOMEPAGE = "http://linuxwireless.org/en/users/Documentation/iw"
>> +SECTION = "base"
>> +LICENSE = "BSD"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=878618a5c4af25e9b93ef0be1a93f774"
>> +
>> +DEPENDS = "libnl pkgconfig"
>> +
>> +SRC_URI = "http://wireless.kernel.org/download/iw/${P}.tar.bz2 \
>> +
>> file://0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch \
>> +          "
>> +
>> +SRC_URI[md5sum] = "1c18bfbbc8773629e5e8ac733a39540c"
>> +SRC_URI[sha256sum] =
>> "df11036ac11df31f44083da962a6e9c74bdea7c01c596c4b5840f948cdb6c857"
>> +
>> +EXTRA_OEMAKE = ""
>> +
>>
>
> Do you really need this?

Yes, in the Makefile, pkg-config commands is used to get libraries info 
and then modify CFLAGS and LIBS accordingly, but they will be overrode 
with the -e option in typical EXTRA_OEMAKE, so I need this to drop the 
-e option.

>
> +do_install() {
>> +       oe_runmake DESTDIR=${D} install
>>
>
> Why don't you add DESTDIR=${D} to EXTRA_OEMAKE and drop the install rule?

It will do nothing with the default intall rule, I just kept the same 
way used in the 3.2 recipe.

Thanks,
Jackie

>
> ag
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
jackie huang - Oct. 8, 2012, 5:29 a.m.
On 10/6/2012 7:16 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 05-10-12 03:39, jackie.huang@windriver.com schreef:
>> iw: add iw 3.6 recipe
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>
> Is there a strong reason to keep the old recipe?

No, I will drop the old recipe.

Thanks,
Jackie

>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFQcBMRMkyGM64RGpERAjETAKCoJ9Uxn+mkwVmidt0COiXE7cXFGgCgkjaP
> 3A0vZJwg6gsdyDuP0DYAsS8=
> =bBXN
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-oe/recipes-connectivity/iw/iw_3.6.bb b/meta-oe/recipes-connectivity/iw/iw_3.6.bb
new file mode 100644
index 0000000..42a43c3
--- /dev/null
+++ b/meta-oe/recipes-connectivity/iw/iw_3.6.bb
@@ -0,0 +1,23 @@ 
+SUMMARY = "nl80211 based CLI configuration utility for wireless devices"
+DESCRIPTION = "iw is a new nl80211 based CLI configuration utility for \
+wireless devices. It supports almost all new drivers that have been added \
+to the kernel recently. "
+HOMEPAGE = "http://linuxwireless.org/en/users/Documentation/iw"
+SECTION = "base"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://COPYING;md5=878618a5c4af25e9b93ef0be1a93f774"
+
+DEPENDS = "libnl pkgconfig"
+
+SRC_URI = "http://wireless.kernel.org/download/iw/${P}.tar.bz2 \
+           file://0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch \
+          "
+
+SRC_URI[md5sum] = "1c18bfbbc8773629e5e8ac733a39540c"
+SRC_URI[sha256sum] = "df11036ac11df31f44083da962a6e9c74bdea7c01c596c4b5840f948cdb6c857"
+
+EXTRA_OEMAKE = ""
+
+do_install() {
+	oe_runmake DESTDIR=${D} install
+}