Patchwork [bitbake-devel] hob/hobeventhandler: Throw an exception if runCommand fails

login
mail settings
Submitter Constantin Musca
Date Oct. 4, 2012, 5:15 a.m.
Message ID <1349327752-25155-1-git-send-email-constantinx.musca@intel.com>
Download mbox | patch
Permalink /patch/37761/
State New
Headers show

Comments

Constantin Musca - Oct. 4, 2012, 5:15 a.m.
- throw a Hob exception if runCommand returns 'Busy' or
'No such command'

[YOCTO #1245]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
---
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Richard Purdie - Oct. 4, 2012, 1 p.m.
On Thu, 2012-10-04 at 08:15 +0300, Constantin Musca wrote:
> - throw a Hob exception if runCommand returns 'Busy' or
> 'No such command'
> 
> [YOCTO #1245]
> 
> Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
index e8d7dc2..2ce5b66 100644
--- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
@@ -101,7 +101,12 @@  class HobHandler(gobject.GObject):
 
     def runCommand(self, commandline):
         try:
-            return self.server.runCommand(commandline)
+            result = self.server.runCommand(commandline)
+            result_str = str(result)
+            if (result_str.startswith("Busy (") or
+                    result_str == "No such command"):
+                raise Exception(result_str)
+            return result
         except Exception as e:
             self.commands_async = []
             self.clear_busy()