Patchwork populate_sdk_base.bbclass: Make it possible to overrise the create_shar method of populate_sdk_base.

login
register
mail settings
Submitter Martin Ertsaas
Date Oct. 3, 2012, 12:51 p.m.
Message ID <1349268675-7808-1-git-send-email-mertsas@cisco.com>
Download mbox | patch
Permalink /patch/37699/
State New
Headers show

Comments

Martin Ertsaas - Oct. 3, 2012, 12:51 p.m.
From: Thomas Kristensen <thkriste@cisco.com>

If you wish to change the install/unpack method of the sdk, this can now be done by making
your own create_shar method, and setting a POPULATE_SDK_CREATE_SHAR_COMMAND variable to your
new create_shar function.

Signed-off-by: Thomas Kristensen <thkriste@cisco.com>
Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
---
 meta/classes/populate_sdk_base.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Martin Ertsaas - Oct. 8, 2012, 6:20 a.m.
On 10/03/12 14:51, Martin Ertsaas wrote:
> From: Thomas Kristensen <thkriste@cisco.com>
>
> If you wish to change the install/unpack method of the sdk, this can now be done by making
> your own create_shar method, and setting a POPULATE_SDK_CREATE_SHAR_COMMAND variable to your
> new create_shar function.
>
> Signed-off-by: Thomas Kristensen <thkriste@cisco.com>
> Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
> ---
>  meta/classes/populate_sdk_base.bbclass |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 1c151d7..53b11a3 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -24,6 +24,8 @@ PID = "${@os.getpid()}"
>  
>  EXCLUDE_FROM_WORLD = "1"
>  
> +POPULATE_SDK_CREATE_SHAR_COMMAND ?= "create_shar"
> +
>  python () {
>      # If we don't do this we try and run the mapping hooks while parsing which is slow
>      # bitbake should really provide something to let us know this...
> @@ -56,7 +58,7 @@ fakeroot python do_populate_sdk() {
>  
>      bb.build.exec_func("tar_sdk", d)
>  
> -    bb.build.exec_func("create_shar", d)
> +    bb.build.exec_func(d.getVar("POPULATE_SDK_CREATE_SHAR_COMMAND", True), d)
>  }
>  
>  fakeroot populate_sdk_image() {
Have anyone had the change to look at this? Would greatly appreciate
some feedback on this. Might also consider making similar overloads for
tar_sdk and friends as well if this is something the community wants.

- Martin
Richard Purdie - Oct. 8, 2012, 9:58 a.m.
On Mon, 2012-10-08 at 08:20 +0200, Martin Ertsås wrote:
> On 10/03/12 14:51, Martin Ertsaas wrote:
> > From: Thomas Kristensen <thkriste@cisco.com>
> >
> > If you wish to change the install/unpack method of the sdk, this can now be done by making
> > your own create_shar method, and setting a POPULATE_SDK_CREATE_SHAR_COMMAND variable to your
> > new create_shar function.
> >
> > Signed-off-by: Thomas Kristensen <thkriste@cisco.com>
> > Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
> > ---
> >  meta/classes/populate_sdk_base.bbclass |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> > index 1c151d7..53b11a3 100644
> > --- a/meta/classes/populate_sdk_base.bbclass
> > +++ b/meta/classes/populate_sdk_base.bbclass
> > @@ -24,6 +24,8 @@ PID = "${@os.getpid()}"
> >  
> >  EXCLUDE_FROM_WORLD = "1"
> >  
> > +POPULATE_SDK_CREATE_SHAR_COMMAND ?= "create_shar"
> > +
> >  python () {
> >      # If we don't do this we try and run the mapping hooks while parsing which is slow
> >      # bitbake should really provide something to let us know this...
> > @@ -56,7 +58,7 @@ fakeroot python do_populate_sdk() {
> >  
> >      bb.build.exec_func("tar_sdk", d)
> >  
> > -    bb.build.exec_func("create_shar", d)
> > +    bb.build.exec_func(d.getVar("POPULATE_SDK_CREATE_SHAR_COMMAND", True), d)
> >  }
> >  
> >  fakeroot populate_sdk_image() {
> Have anyone had the change to look at this? Would greatly appreciate
> some feedback on this. Might also consider making similar overloads for
> tar_sdk and friends as well if this is something the community wants.

My main feedback would be about the variable name. Something like
"SDK_PACKAGING_FUNC" might better describe what its doing.

This is coming in a bit late to make it into the release but which a
rename, will make it into master in due course.

Cheers,

Richard

Patch

diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
index 1c151d7..53b11a3 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -24,6 +24,8 @@  PID = "${@os.getpid()}"
 
 EXCLUDE_FROM_WORLD = "1"
 
+POPULATE_SDK_CREATE_SHAR_COMMAND ?= "create_shar"
+
 python () {
     # If we don't do this we try and run the mapping hooks while parsing which is slow
     # bitbake should really provide something to let us know this...
@@ -56,7 +58,7 @@  fakeroot python do_populate_sdk() {
 
     bb.build.exec_func("tar_sdk", d)
 
-    bb.build.exec_func("create_shar", d)
+    bb.build.exec_func(d.getVar("POPULATE_SDK_CREATE_SHAR_COMMAND", True), d)
 }
 
 fakeroot populate_sdk_image() {