Patchwork package.bbclass: Fix regression in -dbg packages introduced by explode_dep_versions change

login
register
mail settings
Submitter Richard Purdie
Date Oct. 3, 2012, 8:58 a.m.
Message ID <1349254704.18301.22.camel@ted>
Download mbox | patch
Permalink /patch/37651/
State Accepted
Commit 71030c6b37ca320c7d4f5dbc39e6e1ef17e53cfe
Headers show

Comments

Richard Purdie - Oct. 3, 2012, 8:58 a.m.
We need to iterate over the dictionary pulling out the values, not take the top
level keys. If we don't do this, we end up with dependencies on the values of
PACKAGES, not library dependencies.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index a14561d..73c4358 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1763,7 +1763,10 @@  python package_depchains() {
 
     if "-dbg" in pkgs:
         pkglibdeps = read_libdep_files(d)
-        pkglibdeplist = pkglibdeps.keys()
+        pkglibdeplist = []
+        for pkg in pkglibdeps:
+            for k in pkglibdeps[pkg]:
+                add_dep(pkglibdeplist, k)
         # FIXME this should not look at PN once all task recipes inherit from task.bbclass
         dbgdefaultdeps = ((d.getVar('DEPCHAIN_DBGDEFAULTDEPS', True) == '1') or (d.getVar('PN', True) or '').startswith('packagegroup-'))