Patchwork [for-denzil] libtool: Add missing DEPENDS on libtool-cross

login
register
mail settings
Submitter chase maupin
Date Oct. 2, 2012, 9:30 p.m.
Message ID <1349213410-14141-1-git-send-email-Chase.Maupin@ti.com>
Download mbox | patch
Permalink /patch/37635/
State New
Headers show

Comments

chase maupin - Oct. 2, 2012, 9:30 p.m.
* When building with 24 bitbake threads on my system I observed
  errors like the following:
    | configure.ac:199: error: LT_LANG: unsupported language: "Go"
    | <tmpdir>/work/armv7a-vfp-neon-oe-linux-gnueabi/libtool-2.4.2-r3.0/libtool-2.4.2/aclocal-copy/libtool.m4:768: LT_LANG is expanded from...
    | configure.ac:199: the top level
    | autom4te: m4 failed with exit status: 1
* This could be found by doing a clean build.  If a build had
  already been performed then often just cleaning the libtool
  package and rebuilding it would resolve the issue.
* Adding a DEPENDS on libtool-cross resolves this issue with a
  clean build.
* Bump the PR

Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
 meta/recipes-devtools/libtool/libtool_2.4.2.bb |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Richard Purdie - Oct. 3, 2012, 10:21 p.m.
On Wed, 2012-10-03 at 10:17 -0700, Scott Garman wrote:
> On 10/02/2012 02:30 PM, Chase Maupin wrote:
> > * When building with 24 bitbake threads on my system I observed
> >    errors like the following:
> >      | configure.ac:199: error: LT_LANG: unsupported language: "Go"
> >      | <tmpdir>/work/armv7a-vfp-neon-oe-linux-gnueabi/libtool-2.4.2-r3.0/libtool-2.4.2/aclocal-copy/libtool.m4:768: LT_LANG is expanded from...
> >      | configure.ac:199: the top level
> >      | autom4te: m4 failed with exit status: 1
> > * This could be found by doing a clean build.  If a build had
> >    already been performed then often just cleaning the libtool
> >    package and rebuilding it would resolve the issue.
> > * Adding a DEPENDS on libtool-cross resolves this issue with a
> >    clean build.
> > * Bump the PR
> >
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> 
> Thanks for this, I've merged it into my sgarman/denzil-next testing 
> branches.

This isn't even in master yet and I have some concerns about why its
necessary. I've not had a chance to look into it properly yet though :/.

Cheers,

Richard
Scott Garman - Oct. 3, 2012, 11:10 p.m.
On 10/03/2012 03:21 PM, Richard Purdie wrote:
> On Wed, 2012-10-03 at 10:17 -0700, Scott Garman wrote:
>> On 10/02/2012 02:30 PM, Chase Maupin wrote:
>>> * When building with 24 bitbake threads on my system I observed
>>>     errors like the following:
>>>       | configure.ac:199: error: LT_LANG: unsupported language: "Go"
>>>       | <tmpdir>/work/armv7a-vfp-neon-oe-linux-gnueabi/libtool-2.4.2-r3.0/libtool-2.4.2/aclocal-copy/libtool.m4:768: LT_LANG is expanded from...
>>>       | configure.ac:199: the top level
>>>       | autom4te: m4 failed with exit status: 1
>>> * This could be found by doing a clean build.  If a build had
>>>     already been performed then often just cleaning the libtool
>>>     package and rebuilding it would resolve the issue.
>>> * Adding a DEPENDS on libtool-cross resolves this issue with a
>>>     clean build.
>>> * Bump the PR
>>>
>>> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
>>
>> Thanks for this, I've merged it into my sgarman/denzil-next testing
>> branches.
>
> This isn't even in master yet and I have some concerns about why its
> necessary. I've not had a chance to look into it properly yet though :/.

Yeah, sorry I'm jumping the gun a bit. I'm trying to merge commits 
quickly so I can test the branch soon on the autobuilder and get another 
pull request in before the patchset gets too large (last time it was a 
bit unwieldy).

Scott

Patch

diff --git a/meta/recipes-devtools/libtool/libtool_2.4.2.bb b/meta/recipes-devtools/libtool/libtool_2.4.2.bb
index a2eb4ea..f376b67 100644
--- a/meta/recipes-devtools/libtool/libtool_2.4.2.bb
+++ b/meta/recipes-devtools/libtool/libtool_2.4.2.bb
@@ -1,6 +1,8 @@ 
 require libtool-${PV}.inc
 
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
+
+DEPENDS += "libtool-cross"
 
 #
 # We want the results of libtool-cross preserved - don't stage anything ourselves.