Patchwork chrpath: We should provide chrpath-replacement-native and install into a native specific directory

login
register
mail settings
Submitter Richard Purdie
Date Oct. 2, 2012, 1:13 p.m.
Message ID <1349183622.15753.149.camel@ted>
Download mbox | patch
Permalink /patch/37601/
State Accepted
Commit e2519ae2b09273cfaf1ca0cee1ca50f13ee56ffb
Headers show

Comments

Richard Purdie - Oct. 2, 2012, 1:13 p.m.
chrpath is assumed to be provided by the build host system. This means
we need to provide a replacement version and install into a specific directory
to avoid races.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
McClintock Matthew-B29882 - Oct. 2, 2012, 4:22 p.m.
Docs need to be updated, there was also a build warning if it was not
installed - did that get removed too?

-M

On Tue, Oct 2, 2012 at 8:13 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> chrpath is assumed to be provided by the build host system. This means
> we need to provide a replacement version and install into a specific directory
> to avoid races.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/recipes-devtools/chrpath/chrpath_0.14.bb b/meta/recipes-devtools/chrpath/chrpath_0.14.bb
> index 679f1aa..bb9b4b6 100644
> --- a/meta/recipes-devtools/chrpath/chrpath_0.14.bb
> +++ b/meta/recipes-devtools/chrpath/chrpath_0.14.bb
> @@ -20,4 +20,7 @@ inherit autotools
>  # relocatable, so use the one we've just built
>  CHRPATH_BIN_virtclass-native = "${S}/chrpath"
>
> +PROVIDES_append_virtclass-native = " chrpath-replacement-native"
> +NATIVE_PACKAGE_PATH_SUFFIX = "/${PN}"
> +
>  BBCLASSEXTEND = "native nativesdk"
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Oct. 2, 2012, 4:29 p.m.
On Tue, 2012-10-02 at 16:22 +0000, McClintock Matthew-B29882 wrote:
> Docs need to be updated, there was also a build warning if it was not
> installed - did that get removed too?

You still need chrpath installed, this just avoids a different set of
problems in nativesdk and corrected ASSUME_PROVIDED.

Cheers,

Richard
McClintock Matthew-B29882 - Oct. 2, 2012, 5:30 p.m.
On Tue, Oct 2, 2012 at 11:29 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2012-10-02 at 16:22 +0000, McClintock Matthew-B29882 wrote:
>> Docs need to be updated, there was also a build warning if it was not
>> installed - did that get removed too?
>
> You still need chrpath installed, this just avoids a different set of
> problems in nativesdk and corrected ASSUME_PROVIDED.

You still need it installed on your host?

-M

>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Oct. 2, 2012, 8:19 p.m.
On Tue, 2012-10-02 at 17:30 +0000, McClintock Matthew-B29882 wrote:
> On Tue, Oct 2, 2012 at 11:29 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Tue, 2012-10-02 at 16:22 +0000, McClintock Matthew-B29882 wrote:
> >> Docs need to be updated, there was also a build warning if it was not
> >> installed - did that get removed too?
> >
> > You still need chrpath installed, this just avoids a different set of
> > problems in nativesdk and corrected ASSUME_PROVIDED.
> 
> You still need it installed on your host?

Correct, it gets used for native sstate for example.

I've tried to remove this before and you get stuck in circular
dependencies which I decided weren’t worth the pain.

Cheers,

Richard

Patch

diff --git a/meta/recipes-devtools/chrpath/chrpath_0.14.bb b/meta/recipes-devtools/chrpath/chrpath_0.14.bb
index 679f1aa..bb9b4b6 100644
--- a/meta/recipes-devtools/chrpath/chrpath_0.14.bb
+++ b/meta/recipes-devtools/chrpath/chrpath_0.14.bb
@@ -20,4 +20,7 @@  inherit autotools
 # relocatable, so use the one we've just built
 CHRPATH_BIN_virtclass-native = "${S}/chrpath"
 
+PROVIDES_append_virtclass-native = " chrpath-replacement-native"
+NATIVE_PACKAGE_PATH_SUFFIX = "/${PN}"
+
 BBCLASSEXTEND = "native nativesdk"