Patchwork [meta-webserver,6/6] xdebug: add new recipe

login
register
mail settings
Submitter Paul Eggleton
Date Oct. 1, 2012, 4:14 p.m.
Message ID <00be8d19fe238a3ef1df3371ab354b9122b56d2c.1349107616.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/37549/
State Superseded
Headers show

Comments

Paul Eggleton - Oct. 1, 2012, 4:14 p.m.
Add new recipe for the Xdebug PHP debugger/profiler.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb |   29 +++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
Koen Kooi - Oct. 3, 2012, 10:21 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 01-10-12 18:14, Paul Eggleton schreef:
> Add new recipe for the Xdebug PHP debugger/profiler.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> --- 
> meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb |   29
> +++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644
> meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
> 
> diff --git a/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
> b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb new file mode 100644 
> index 0000000..5bd374c --- /dev/null +++
> b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb @@ -0,0 +1,29 @@ 
> +SUMMARY = "Debugging and profiling extension for PHP"

Missing DESCRIPTION

> +LICENSE = "Xdebug" +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=34df3a274aa12b795417c65634c07f16" + +DEPENDS =
> "modphp" + +PR = "r0"

default....

> + +SRC_URI = "http://xdebug.org/files/xdebug-${PV}.tgz" + 
> +SRC_URI[md5sum] = "5e5c467e920240c20f165687d7ac3709" +SRC_URI[sha256sum]
> = "11d340eb7f87909a596bac054cc927df757dc2fc7c90b50a832c30e9bf84c9ad" + 
> +inherit autotools + +EXTRA_OECONF += "--enable-xdebug
> -with-php-config=${STAGING_BINDIR_CROSS}/php-config" + +do_configure() { 
> +	${STAGING_BINDIR_CROSS}/phpize +	oe_runconf +}

Why not do autotools_do_configure?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQbBG/MkyGM64RGpERAoDSAJ4x/Ulx1MXZlAdrtkFUs11WXd75qQCgns2l
6+VrxCzuKm6zn9sbgFa65+U=
=ph3p
-----END PGP SIGNATURE-----
Paul Eggleton - Oct. 3, 2012, 11:28 a.m.
On Wednesday 03 October 2012 12:21:51 Koen Kooi wrote:
> Op 01-10-12 18:14, Paul Eggleton schreef:
> > Add new recipe for the Xdebug PHP debugger/profiler.
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> ---
> > meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb |   29
> > +++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644
> > meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
> > 
> > diff --git a/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
> > b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb new file mode 100644
> > index 0000000..5bd374c --- /dev/null +++
> > b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb @@ -0,0 +1,29 @@
> > +SUMMARY = "Debugging and profiling extension for PHP"
> 
> Missing DESCRIPTION

No, this is deliberate - presumably you're aware that the default value of 
DESCRIPTION is "${SUMMARY}" ? The opposite is not true, which leads to 
packages with useless summaries if you set DESCRIPTION and not SUMMARY; so if 
it's just one line the single variable to set is SUMMARY. I know we have a lot 
of recipes that have this issue; we should probably address that on a wider 
basis.

> > +LICENSE = "Xdebug" +LIC_FILES_CHKSUM =
> > "file://LICENSE;md5=34df3a274aa12b795417c65634c07f16" + +DEPENDS =
> > "modphp" + +PR = "r0"
> 
> default....

See reply to patch 2/6.

> > + +SRC_URI = "http://xdebug.org/files/xdebug-${PV}.tgz" +
> > +SRC_URI[md5sum] = "5e5c467e920240c20f165687d7ac3709" +SRC_URI[sha256sum]
> > = "11d340eb7f87909a596bac054cc927df757dc2fc7c90b50a832c30e9bf84c9ad" +
> > +inherit autotools + +EXTRA_OECONF += "--enable-xdebug
> > -with-php-config=${STAGING_BINDIR_CROSS}/php-config" + +do_configure() {
> > +	${STAGING_BINDIR_CROSS}/phpize +	oe_runconf +}
> 
> Why not do autotools_do_configure?

Because AFAICT PHP modules are somewhat unusual when it comes to configure, and 
totally break if you try to autoreconf. IIRC this was the only way I could get 
the thing to build.

Cheers,
Paul
Koen Kooi - Oct. 3, 2012, 11:47 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 03-10-12 13:28, Paul Eggleton schreef:
> On Wednesday 03 October 2012 12:21:51 Koen Kooi wrote:
>> Op 01-10-12 18:14, Paul Eggleton schreef:
>>> Add new recipe for the Xdebug PHP debugger/profiler.
>>> 
>>> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> --- 
>>> meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb |   29 
>>> +++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode
>>> 100644 meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
>>> 
>>> diff --git a/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb 
>>> b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb new file mode
>>> 100644 index 0000000..5bd374c --- /dev/null +++ 
>>> b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb @@ -0,0 +1,29 @@ 
>>> +SUMMARY = "Debugging and profiling extension for PHP"
>> 
>> Missing DESCRIPTION
> 
> No, this is deliberate - presumably you're aware that the default value
> of DESCRIPTION is "${SUMMARY}" ? The opposite is not true, which leads to
>  packages with useless summaries if you set DESCRIPTION and not SUMMARY;
> so if it's just one line the single variable to set is SUMMARY. I know we
> have a lot of recipes that have this issue; we should probably address
> that on a wider basis.
> 
>>> +LICENSE = "Xdebug" +LIC_FILES_CHKSUM = 
>>> "file://LICENSE;md5=34df3a274aa12b795417c65634c07f16" + +DEPENDS = 
>>> "modphp" + +PR = "r0"
>> 
>> default....
> 
> See reply to patch 2/6.

Extra work for M1.4, but it's your sandbox to play in...

>>> + +SRC_URI = "http://xdebug.org/files/xdebug-${PV}.tgz" + 
>>> +SRC_URI[md5sum] = "5e5c467e920240c20f165687d7ac3709"
>>> +SRC_URI[sha256sum] =
>>> "11d340eb7f87909a596bac054cc927df757dc2fc7c90b50a832c30e9bf84c9ad" + 
>>> +inherit autotools + +EXTRA_OECONF += "--enable-xdebug 
>>> -with-php-config=${STAGING_BINDIR_CROSS}/php-config" +
>>> +do_configure() { +	${STAGING_BINDIR_CROSS}/phpize +	oe_runconf +}
>> 
>> Why not do autotools_do_configure?
> 
> Because AFAICT PHP modules are somewhat unusual when it comes to
> configure, and totally break if you try to autoreconf. IIRC this was the
> only way I could get the thing to build.

Can you add a comment saying that? A lot of recipes in OE classic replace
the configure step, but our autotools support has improved a lot, so a
comment saying what is going wrong will help people updating the recipe.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQbCXoMkyGM64RGpERAhBMAJ47+3mA0f3FwWl2NvK3h/joP/6FEQCcCH+y
mt9mrA8R/2QKMkfHH51QG2I=
=VWa7
-----END PGP SIGNATURE-----
Paul Eggleton - Oct. 3, 2012, 1:08 p.m.
On Wednesday 03 October 2012 13:47:52 Koen Kooi wrote:
> >> Why not do autotools_do_configure?
> > 
> > Because AFAICT PHP modules are somewhat unusual when it comes to
> > configure, and totally break if you try to autoreconf. IIRC this was the
> > only way I could get the thing to build.
> 
> Can you add a comment saying that? A lot of recipes in OE classic replace
> the configure step, but our autotools support has improved a lot, so a
> comment saying what is going wrong will help people updating the recipe.

That's a good point, I've added a comment within do_configure on the branch 
noting why it's been done that way.

Cheers,
Paul

Patch

diff --git a/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
new file mode 100644
index 0000000..5bd374c
--- /dev/null
+++ b/meta-webserver/recipes-php/xdebug/xdebug_2.2.1.bb
@@ -0,0 +1,29 @@ 
+SUMMARY = "Debugging and profiling extension for PHP"
+LICENSE = "Xdebug"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=34df3a274aa12b795417c65634c07f16"
+
+DEPENDS = "modphp"
+
+PR = "r0"
+
+SRC_URI = "http://xdebug.org/files/xdebug-${PV}.tgz"
+
+SRC_URI[md5sum] = "5e5c467e920240c20f165687d7ac3709"
+SRC_URI[sha256sum] = "11d340eb7f87909a596bac054cc927df757dc2fc7c90b50a832c30e9bf84c9ad"
+
+inherit autotools
+
+EXTRA_OECONF += "--enable-xdebug -with-php-config=${STAGING_BINDIR_CROSS}/php-config"
+
+do_configure() {
+	${STAGING_BINDIR_CROSS}/phpize
+	oe_runconf
+}
+
+do_install() {
+	oe_runmake install INSTALL_ROOT=${D}
+}
+
+FILES_${PN} += "${libdir}/php5/extensions/*/*.so"
+FILES_${PN}-dbg += "${libdir}/php5/extensions/*/.debug"
+