Patchwork Fix invalid test for network error

login
register
mail settings
Submitter Bogdan Marinescu
Date Oct. 1, 2012, 2:17 p.m.
Message ID <1349101037-5831-1-git-send-email-bogdan.a.marinescu@intel.com>
Download mbox | patch
Permalink /patch/37525/
State Accepted
Commit 9fcd0866f0e30a50182434f6bcae13bf9575807f
Headers show

Comments

Bogdan Marinescu - Oct. 1, 2012, 2:17 p.m.
The test for network error in sanity.bbclass was negated.

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - Oct. 1, 2012, 9:10 p.m.
The commit message should include the filename such as:

sanity.bbclass: Fix invalid test for network error

Sau!


On 10/01/2012 07:17 AM, Bogdan Marinescu wrote:
> The test for network error in sanity.bbclass was negated.
>
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>   meta/classes/sanity.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index e2095dd..f2e9a74 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -174,7 +174,7 @@ def check_sanity_tmpdir_change(tmpdir, data):
>       # Check that we can fetch from various network transports
>       errmsg = check_connectivity(data)
>       testmsg = testmsg + check_connectivity(data)
> -    return testmsg, errmsg == ""
> +    return testmsg, errmsg != ""
>
>   def check_sanity_version_change(data):
>       # Sanity checks to be done when SANITY_VERSION changes
>
Saul Wold - Oct. 3, 2012, 1:47 a.m.
On 10/01/2012 07:17 AM, Bogdan Marinescu wrote:
> The test for network error in sanity.bbclass was negated.
>
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>   meta/classes/sanity.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index e2095dd..f2e9a74 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -174,7 +174,7 @@ def check_sanity_tmpdir_change(tmpdir, data):
>       # Check that we can fetch from various network transports
>       errmsg = check_connectivity(data)
>       testmsg = testmsg + check_connectivity(data)
> -    return testmsg, errmsg == ""
> +    return testmsg, errmsg != ""
>
>   def check_sanity_version_change(data):
>       # Sanity checks to be done when SANITY_VERSION changes
>

Merged into OE-Core with update subject

Thanks
	Sau!

Patch

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index e2095dd..f2e9a74 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -174,7 +174,7 @@  def check_sanity_tmpdir_change(tmpdir, data):
     # Check that we can fetch from various network transports
     errmsg = check_connectivity(data)
     testmsg = testmsg + check_connectivity(data)
-    return testmsg, errmsg == ""
+    return testmsg, errmsg != ""
         
 def check_sanity_version_change(data):
     # Sanity checks to be done when SANITY_VERSION changes