From patchwork Fri Sep 28 17:27:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel, 1/2] utils.py: Check for duplication dependency entries Date: Fri, 28 Sep 2012 17:27:49 -0000 From: Mark Hatle X-Patchwork-Id: 37449 Message-Id: <1348853270-29676-1-git-send-email-mark.hatle@windriver.com> To: explode_dep_versions is not able to have duplicate entries. Previously duplicate entries ended up with the last item being the one returned to the caller. Instead we now throw a ValueType exception. This will ensure the caller always gets the full set of declared dependencies. Signed-off-by: Mark Hatle --- lib/bb/utils.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/bb/utils.py b/lib/bb/utils.py index 82dab6b..fa5d2ab 100644 --- a/lib/bb/utils.py +++ b/lib/bb/utils.py @@ -159,6 +159,8 @@ def explode_dep_versions(s): lastver = lastver + " " + (i[:-1] or "") r[lastdep] = lastver elif not inversion: + if i in r: + raise ValueError("Error, item %s appeared in dependency string '%s' multiple times. explode_dep_versions cannot cope with this." % (i, s)) r[i] = None lastdep = i lastver = ""