Patchwork [0/3] license.bbclass fixes

login
register
mail settings
Submitter Elizabeth Flanagan
Date Sept. 26, 2012, 9:50 p.m.
Message ID <cover.1348695851.git.elizabeth.flanagan@intel.com>
Download mbox
Permalink /patch/37307/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib eflanagan/LICENSE_PATH

Comments

Elizabeth Flanagan - Sept. 26, 2012, 9:50 p.m.
[YOCTO #3118]

license.conf hasn't been being parsed. This commit series ensures that 
license.conf is parsed, that it contains useful variables that should be
in a global conf file and that those variables are not kept within 
license.bbclass.

This also fixes an discreprancy between the documentation of LICENSE_PATH (which
is what we tell people to use) and what we were using "LICENSE_DIR". This ensures
that when the end user needs to add additional licenses, that they use 
LICENSE_PATH += "path/to/additional/licenses" and that it works.

The following changes since commit 0b09e50810162a07ef0aecee91ee32b4a36334a3:

  busybox: Fix misplaced quote (2012-09-26 18:28:36 +0100)

are available in the git repository at:
  git://git.yoctoproject.org/poky-contrib eflanagan/LICENSE_PATH
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=eflanagan/LICENSE_PATH

Elizabeth Flanagan (3):
  license.bbclass: Variable standardization
  bitbake.conf: parse license config
  license.conf/bbclass: Move globals to license.conf

 meta/classes/license.bbclass |   67 +-----------------------------------------
 meta/conf/bitbake.conf       |    1 +
 meta/conf/licenses.conf      |   64 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 66 insertions(+), 66 deletions(-)
Saul Wold - Sept. 27, 2012, 5:08 p.m.
On 09/26/2012 02:50 PM, Elizabeth Flanagan wrote:
> [YOCTO #3118]
>
> license.conf hasn't been being parsed. This commit series ensures that
> license.conf is parsed, that it contains useful variables that should be
> in a global conf file and that those variables are not kept within
> license.bbclass.
>
So where is the inherit license bbclass?

Sau!

> This also fixes an discreprancy between the documentation of LICENSE_PATH (which
> is what we tell people to use) and what we were using "LICENSE_DIR". This ensures
> that when the end user needs to add additional licenses, that they use
> LICENSE_PATH += "path/to/additional/licenses" and that it works.
>

> The following changes since commit 0b09e50810162a07ef0aecee91ee32b4a36334a3:
>
>    busybox: Fix misplaced quote (2012-09-26 18:28:36 +0100)
>
> are available in the git repository at:
>    git://git.yoctoproject.org/poky-contrib eflanagan/LICENSE_PATH
>    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=eflanagan/LICENSE_PATH
>
> Elizabeth Flanagan (3):
>    license.bbclass: Variable standardization
>    bitbake.conf: parse license config
>    license.conf/bbclass: Move globals to license.conf
>
>   meta/classes/license.bbclass |   67 +-----------------------------------------
>   meta/conf/bitbake.conf       |    1 +
>   meta/conf/licenses.conf      |   64 ++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 66 insertions(+), 66 deletions(-)
>
Elizabeth Flanagan - Sept. 27, 2012, 11:50 p.m.
On Thu, Sep 27, 2012 at 10:08 AM, Saul Wold <sgw@linux.intel.com> wrote:
> On 09/26/2012 02:50 PM, Elizabeth Flanagan wrote:
>>
>> [YOCTO #3118]
>>
>> license.conf hasn't been being parsed. This commit series ensures that
>> license.conf is parsed, that it contains useful variables that should be
>> in a global conf file and that those variables are not kept within
>> license.bbclass.
>>
> So where is the inherit license bbclass?

For the yocto project it's an INHERIT +=  within poky.conf.
meta-angstrom does not inherit it within
conf/distro/include/angstrom.inc.

-b

>
> Sau!
>
>
>> This also fixes an discreprancy between the documentation of LICENSE_PATH
>> (which
>> is what we tell people to use) and what we were using "LICENSE_DIR". This
>> ensures
>> that when the end user needs to add additional licenses, that they use
>> LICENSE_PATH += "path/to/additional/licenses" and that it works.
>>
>
>> The following changes since commit
>> 0b09e50810162a07ef0aecee91ee32b4a36334a3:
>>
>>    busybox: Fix misplaced quote (2012-09-26 18:28:36 +0100)
>>
>> are available in the git repository at:
>>    git://git.yoctoproject.org/poky-contrib eflanagan/LICENSE_PATH
>>
>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=eflanagan/LICENSE_PATH
>>
>> Elizabeth Flanagan (3):
>>    license.bbclass: Variable standardization
>>    bitbake.conf: parse license config
>>    license.conf/bbclass: Move globals to license.conf
>>
>>   meta/classes/license.bbclass |   67
>> +-----------------------------------------
>>   meta/conf/bitbake.conf       |    1 +
>>   meta/conf/licenses.conf      |   64
>> ++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 66 insertions(+), 66 deletions(-)
>>
>
Saul Wold - Sept. 27, 2012, 11:56 p.m.
On 09/27/2012 04:50 PM, Flanagan, Elizabeth wrote:
> On Thu, Sep 27, 2012 at 10:08 AM, Saul Wold <sgw@linux.intel.com> wrote:
>> On 09/26/2012 02:50 PM, Elizabeth Flanagan wrote:
>>>
>>> [YOCTO #3118]
>>>
>>> license.conf hasn't been being parsed. This commit series ensures that
>>> license.conf is parsed, that it contains useful variables that should be
>>> in a global conf file and that those variables are not kept within
>>> license.bbclass.
>>>
>> So where is the inherit license bbclass?
>
> For the yocto project it's an INHERIT +=  within poky.conf.
> meta-angstrom does not inherit it within
> conf/distro/include/angstrom.inc.
>
> -b
>
Acked-by: Saul Wold <sgw@linux.intel.com?>
>>
>> Sau!
>>
>>
>>> This also fixes an discreprancy between the documentation of LICENSE_PATH
>>> (which
>>> is what we tell people to use) and what we were using "LICENSE_DIR". This
>>> ensures
>>> that when the end user needs to add additional licenses, that they use
>>> LICENSE_PATH += "path/to/additional/licenses" and that it works.
>>>
>>
>>> The following changes since commit
>>> 0b09e50810162a07ef0aecee91ee32b4a36334a3:
>>>
>>>     busybox: Fix misplaced quote (2012-09-26 18:28:36 +0100)
>>>
>>> are available in the git repository at:
>>>     git://git.yoctoproject.org/poky-contrib eflanagan/LICENSE_PATH
>>>
>>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=eflanagan/LICENSE_PATH
>>>
>>> Elizabeth Flanagan (3):
>>>     license.bbclass: Variable standardization
>>>     bitbake.conf: parse license config
>>>     license.conf/bbclass: Move globals to license.conf
>>>
>>>    meta/classes/license.bbclass |   67
>>> +-----------------------------------------
>>>    meta/conf/bitbake.conf       |    1 +
>>>    meta/conf/licenses.conf      |   64
>>> ++++++++++++++++++++++++++++++++++++++++
>>>    3 files changed, 66 insertions(+), 66 deletions(-)
>>>
>>
>
>
>
Richard Purdie - Sept. 28, 2012, 10:20 a.m.
On Wed, 2012-09-26 at 14:50 -0700, Elizabeth Flanagan wrote:
> [YOCTO #3118]
> 
> license.conf hasn't been being parsed. This commit series ensures that 
> license.conf is parsed, that it contains useful variables that should be
> in a global conf file and that those variables are not kept within 
> license.bbclass.
> 
> This also fixes an discreprancy between the documentation of LICENSE_PATH (which
> is what we tell people to use) and what we were using "LICENSE_DIR". This ensures
> that when the end user needs to add additional licenses, that they use 
> LICENSE_PATH += "path/to/additional/licenses" and that it works.
> 
> The following changes since commit 0b09e50810162a07ef0aecee91ee32b4a36334a3:
> 
>   busybox: Fix misplaced quote (2012-09-26 18:28:36 +0100)
> 
> are available in the git repository at:
>   git://git.yoctoproject.org/poky-contrib eflanagan/LICENSE_PATH
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=eflanagan/LICENSE_PATH
> 
> Elizabeth Flanagan (3):
>   license.bbclass: Variable standardization
>   bitbake.conf: parse license config
>   license.conf/bbclass: Move globals to license.conf

Merged to master, thanks.

Richard