Patchwork [bitbake-devel] hob/builder: When you stop a build, Hob should tell you stopping is happening

login
register
mail settings
Submitter Constantin Musca
Date Sept. 26, 2012, 8:08 a.m.
Message ID <1348646895-20634-1-git-send-email-constantinx.musca@intel.com>
Download mbox | patch
Permalink /patch/37243/
State New
Headers show

Comments

Constantin Musca - Sept. 26, 2012, 8:08 a.m.
- use the progress bar text to indicate the stopping status
- the text should say: 'Stopping the build...'

[YOCTO #3152]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
---
 bitbake/lib/bb/ui/crumbs/builder.py |    2 ++
 1 file changed, 2 insertions(+)
Richard Purdie - Sept. 27, 2012, 3:42 p.m.
On Wed, 2012-09-26 at 11:08 +0300, Constantin Musca wrote:
> - use the progress bar text to indicate the stopping status
> - the text should say: 'Stopping the build...'
> 
> [YOCTO #3152]
> 
> Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/builder.py |    2 ++
>  1 file changed, 2 insertions(+)

Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
index 267fde1..4dbffd6 100755
--- a/bitbake/lib/bb/ui/crumbs/builder.py
+++ b/bitbake/lib/bb/ui/crumbs/builder.py
@@ -1375,6 +1375,8 @@  class Builder(gtk.Window):
         if response != gtk.RESPONSE_CANCEL:
             self.stopping = True
         if response == gtk.RESPONSE_OK:
+            self.build_details_page.progress_bar.set_title("Stopping the build...")
+            self.build_details_page.progress_bar.set_rcstyle("stop")
             self.cancel_build_sync()
         elif response == gtk.RESPONSE_YES:
             self.cancel_build_sync(True)