Patchwork at: atd remove useless --make-pidfile option.

login
register
mail settings
Submitter xin.ouyang@windriver.com
Date Sept. 26, 2012, 7:09 a.m.
Message ID <1348643353-32175-1-git-send-email-Xin.Ouyang@windriver.com>
Download mbox | patch
Permalink /patch/37231/
State Accepted
Commit f10d236cda704cd91e185f8dc9c3f52461e2dad1
Headers show

Comments

xin.ouyang@windriver.com - Sept. 26, 2012, 7:09 a.m.
For start-stop-daemon, --make-pidfile is used when starting a
program that does not create its own pid file.
atd would create its own /var/run/atd.pid, so remove this option.

Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
---
 meta/recipes-extended/at/at_3.1.13.bb |    2 +-
 meta/recipes-extended/at/files/S99at  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Saul Wold - Sept. 27, 2012, 3:51 p.m.
On 09/26/2012 12:09 AM, Xin Ouyang wrote:
> For start-stop-daemon, --make-pidfile is used when starting a
> program that does not create its own pid file.
> atd would create its own /var/run/atd.pid, so remove this option.
>
> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
> ---
>   meta/recipes-extended/at/at_3.1.13.bb |    2 +-
>   meta/recipes-extended/at/files/S99at  |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/at/at_3.1.13.bb b/meta/recipes-extended/at/at_3.1.13.bb
> index a391d6e..3580e09 100644
> --- a/meta/recipes-extended/at/at_3.1.13.bb
> +++ b/meta/recipes-extended/at/at_3.1.13.bb
> @@ -11,7 +11,7 @@ PAM_DEPS = "libpam libpam-runtime pam-plugin-env pam-plugin-limits"
>
>   RCONFLICTS_${PN} = "atd"
>   RREPLACES_${PN} = "atd"
> -PR = "r3"
> +PR = "r4"
>
>   SRC_URI = "${DEBIAN_MIRROR}/main/a/at/at_${PV}.orig.tar.gz \
>       file://configure.patch \
> diff --git a/meta/recipes-extended/at/files/S99at b/meta/recipes-extended/at/files/S99at
> index bcfcbda..386f8a4 100644
> --- a/meta/recipes-extended/at/files/S99at
> +++ b/meta/recipes-extended/at/files/S99at
> @@ -7,7 +7,7 @@ umask 077
>
>   start() {
>   	echo -n "Starting atd: "
> -	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
> +	start-stop-daemon --start --quiet --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
>   	echo "OK"
>   }
>   stop() {
>

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-extended/at/at_3.1.13.bb b/meta/recipes-extended/at/at_3.1.13.bb
index a391d6e..3580e09 100644
--- a/meta/recipes-extended/at/at_3.1.13.bb
+++ b/meta/recipes-extended/at/at_3.1.13.bb
@@ -11,7 +11,7 @@  PAM_DEPS = "libpam libpam-runtime pam-plugin-env pam-plugin-limits"
 
 RCONFLICTS_${PN} = "atd"
 RREPLACES_${PN} = "atd"
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "${DEBIAN_MIRROR}/main/a/at/at_${PV}.orig.tar.gz \
     file://configure.patch \
diff --git a/meta/recipes-extended/at/files/S99at b/meta/recipes-extended/at/files/S99at
index bcfcbda..386f8a4 100644
--- a/meta/recipes-extended/at/files/S99at
+++ b/meta/recipes-extended/at/files/S99at
@@ -7,7 +7,7 @@  umask 077
 
 start() {
 	echo -n "Starting atd: "
-	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
+	start-stop-daemon --start --quiet --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
 	echo "OK"
 }
 stop() {