Patchwork sqlite3: enable USE_PREAD

login
register
mail settings
Submitter Phil Blundell
Date Sept. 22, 2012, 4:50 p.m.
Message ID <1348332621.4444.219.camel@x121e.pbcl.net>
Download mbox | patch
Permalink /patch/37067/
State Accepted
Commit e4bd65e68c3d0dd798ff69c2e9491e5b2dcafdc3
Headers show

Comments

Phil Blundell - Sept. 22, 2012, 4:50 p.m.
This gives a small but measureable performance improvement for
I/O heavy workloads.

Signed-off-by: Phil Blundell <pb@pbcl.net>
---
 meta/recipes-support/sqlite/sqlite3.inc       |    4 ++++
 meta/recipes-support/sqlite/sqlite3_3.7.13.bb |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)
Richard Purdie - Sept. 24, 2012, 10:20 a.m.
On Sat, 2012-09-22 at 17:50 +0100, Phil Blundell wrote:
> This gives a small but measureable performance improvement for
> I/O heavy workloads.
> 
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
>  meta/recipes-support/sqlite/sqlite3.inc       |    4 ++++
>  meta/recipes-support/sqlite/sqlite3_3.7.13.bb |    2 +-
>  2 files changed, 5 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
index 0cc5d65..70841f8 100644
--- a/meta/recipes-support/sqlite/sqlite3.inc
+++ b/meta/recipes-support/sqlite/sqlite3.inc
@@ -17,6 +17,10 @@  export config_TARGET_LINK = "${CCLD}"
 export config_TARGET_CFLAGS = "${CFLAGS}"
 export config_TARGET_LFLAGS = "${LDFLAGS}"
 
+# pread() is in POSIX.1-2001 so any reasonable system must surely support it
+BUILD_CFLAGS += "-DUSE_PREAD"
+TARGET_CFLAGS += "-DUSE_PREAD"
+
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
 
 FILES_${PN} = "${bindir}/*"
diff --git a/meta/recipes-support/sqlite/sqlite3_3.7.13.bb b/meta/recipes-support/sqlite/sqlite3_3.7.13.bb
index 4e050a3..48b50ac 100644
--- a/meta/recipes-support/sqlite/sqlite3_3.7.13.bb
+++ b/meta/recipes-support/sqlite/sqlite3_3.7.13.bb
@@ -2,7 +2,7 @@  require sqlite3.inc
 
 LIC_FILES_CHKSUM = "file://sqlite3.h;endline=11;md5=65f0a57ca6928710b418c094b3570bb0"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://www.sqlite.org/sqlite-autoconf-3071300.tar.gz"
 S = "${WORKDIR}/sqlite-autoconf-3071300"