Patchwork [bitbake-devel,v2,1/4] hob: don't show error dialog for errors during building

login
register
mail settings
Submitter Paul Eggleton
Date Sept. 21, 2012, 2:47 p.m.
Message ID <cb9e4516cecd5299bb68a17238e4f83718bdb025.1348238757.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/37005/
State New
Headers show

Comments

Paul Eggleton - Sept. 21, 2012, 2:47 p.m.
During building we already report errors in a special tab and
indicate when the build has failed; bringing up a dialog was a
regression introduced in bitbake revision
5bab81b124087d63d6eb62a861e1241714fcd483.

Fixes [YOCTO #3151].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
index 8fc1732..49db2de 100644
--- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
@@ -183,10 +183,11 @@  class HobHandler(gobject.GObject):
             self.emit("sanity-failed", event._msg)
 
         elif isinstance(event, logging.LogRecord):
-            if event.levelno >= logging.ERROR:
-                formatter = bb.msg.BBLogFormatter()
-                msg = formatter.format(event)
-                self.error_msg += msg + '\n'
+            if not self.building:
+                if event.levelno >= logging.ERROR:
+                    formatter = bb.msg.BBLogFormatter()
+                    msg = formatter.format(event)
+                    self.error_msg += msg + '\n'
 
         elif isinstance(event, bb.event.TargetsTreeGenerated):
             self.current_phase = "data generation"