Patchwork [bitbake-devel,hob] Remove stray "distro" combobox from simple settings

login
register
mail settings
Submitter Bogdan Marinescu
Date Sept. 20, 2012, 10:27 a.m.
Message ID <1348136876-8840-1-git-send-email-bogdan.a.marinescu@intel.com>
Download mbox | patch
Permalink /patch/36955/
State New
Headers show

Comments

Bogdan Marinescu - Sept. 20, 2012, 10:27 a.m.
The "distro" combobox was moved to advanced settings, but it
was also present in simple settings. This patch removed it
from simple settings.
This patch is meant to be applied over my previous "fix settings"
patch, version 1 only (version 2 of the patch already contains
this fix).

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/hig.py |   10 ----------
 1 file changed, 10 deletions(-)

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hig.py b/bitbake/lib/bb/ui/crumbs/hig.py
index e043f93..f304a68 100644
--- a/bitbake/lib/bb/ui/crumbs/hig.py
+++ b/bitbake/lib/bb/ui/crumbs/hig.py
@@ -195,7 +195,6 @@  class SimpleSettingsDialog (CrumbsDialog, SettingsUIHelper):
         self.max_threads = max_threads
 
         # class members for internal use
-        self.distro_combo = None
         self.dldir_text = None
         self.sstatedir_text = None
         self.sstatemirror_text = None
@@ -330,7 +329,6 @@  class SimpleSettingsDialog (CrumbsDialog, SettingsUIHelper):
         self.refresh_proxy_components()
 
     def response_cb(self, dialog, response_id):        
-        #self.configuration.curr_distro = self.distro_combo.get_active_text()
         self.configuration.dldir = self.dldir_text.get_text()
         self.configuration.sstatedir = self.sstatedir_text.get_text()
         self.configuration.sstatemirror = self.sstatemirror_text.get_text()
@@ -358,14 +356,6 @@  class SimpleSettingsDialog (CrumbsDialog, SettingsUIHelper):
 
         sub_vbox = gtk.VBox(False, 6)
         advanced_vbox.pack_start(sub_vbox, expand=False, fill=False)
-        label = self.gen_label_widget("<span weight=\"bold\">Select distro:</span>")
-        tooltip = "Selects the Yocto Project distribution you want"
-        distro_widget, self.distro_combo = self.gen_combo_widget(self.configuration.curr_distro, self.all_distros, tooltip)
-        sub_vbox.pack_start(label, expand=False, fill=False)
-        sub_vbox.pack_start(distro_widget, expand=False, fill=False)
-
-        sub_vbox = gtk.VBox(False, 6)
-        advanced_vbox.pack_start(sub_vbox, expand=False, fill=False)
         label = self.gen_label_widget("<span weight=\"bold\">BB number threads:</span>")
         tooltip = "Sets the number of threads that BitBake tasks can simultaneously run. See the <a href=\""
         tooltip += "http://www.yoctoproject.org/docs/current/poky-ref-manual/"