Patchwork [RFC,0/7] Postinstall improvements

login
register
mail settings
Submitter Laurentiu Palcu
Date Sept. 19, 2012, 11:49 a.m.
Message ID <cover.1348052899.git.laurentiu.palcu@intel.com>
Download mbox
Permalink /patch/36917/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib lpalcu/pi

Comments

Laurentiu Palcu - Sept. 19, 2012, 11:49 a.m.
Hi,

It's been quite a long time since I sent the first version of postinstall
improvements which, after some debate, we decided it needed run-once
support of postinst scriptlets on host. This patcheset (RFC actually) adds
that.

So, in order to achieve this goal I took advantage of
ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
scriptlets is time consuming (even on host) and execute repeatedly,
then we can postpone the running and run the scriplet just once. The idea is
to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
this directory and execute them.

This actual patchset does the above for the gtk icon cache generation which
takes a very long time to run on target and even on some hosts.

The people willing to give this patchset a test, are most than welcome. Also,
please feel free to review.

Thanks,
Laurentiu

The following changes since commit 913944d904266bf90af0cad94b4f0fb3652bd29d:

  upstream_tracking: update lsb and ltp (2012-09-14 17:12:52 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib lpalcu/pi
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=lpalcu/pi

Laurentiu Palcu (7):
  gtk+: enable gtk+-native
  image.bbclass: run postinst scripts once, at rootfs time
  rootfs generation: export two new variables to postinst scriptlets
  gtk-icon-cache: run the icon generation at rootfs time
  gdk-pixbuf: generate the pixbuf loader's cache ar rootfs time
  sato-icon-theme: make use of the gtk-icon-cache postinst scriptlet
  postinst changes: bump PR to all recipes inheriting gnome and
    gtk-icon-cache

 meta/classes/gtk-icon-cache.bbclass                |   21 +++++++++++++----
 meta/classes/image.bbclass                         |   24 +++++++++++++++++++-
 meta/classes/package_rpm.bbclass                   |    2 ++
 meta/classes/rootfs_deb.bbclass                    |    2 ++
 meta/classes/rootfs_ipk.bbclass                    |    2 ++
 .../connman/connman-gnome_0.7.bb                   |    2 ++
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb |   24 ++++++++++++--------
 meta/recipes-gnome/gnome/gnome-common_2.28.0.bb    |    2 +-
 meta/recipes-gnome/gnome/gnome-desktop.inc         |    2 +-
 meta/recipes-gnome/gnome/gnome-doc-utils_0.20.6.bb |    2 +-
 meta/recipes-gnome/gnome/gnome-keyring_2.32.1.bb   |    2 +-
 meta/recipes-gnome/gnome/gnome-mime-data_2.18.0.bb |    2 +-
 meta/recipes-gnome/gnome/libgdata_0.7.1.bb         |    2 ++
 .../recipes-gnome/gnome/libgnome-keyring_2.32.0.bb |    2 +-
 meta/recipes-gnome/gnome/metacity_2.30.3.bb        |    2 +-
 meta/recipes-gnome/gthumb/gthumb_2.12.4.bb         |    2 +-
 meta/recipes-gnome/gtk+/gtk+_2.24.8.bb             |    5 +++-
 .../gtk-engines/gtk-engines_2.20.2.bb              |    2 +-
 .../hicolor-icon-theme/hicolor-icon-theme_0.12.bb  |    2 +-
 meta/recipes-gnome/json-glib/json-glib_0.14.2.bb   |    2 +-
 meta/recipes-gnome/libglade/libglade_2.6.4.bb      |    2 +-
 meta/recipes-gnome/librsvg/librsvg_2.32.1.bb       |    2 +-
 meta/recipes-graphics/mutter/mutter_2.29.1.bb      |    2 +-
 meta/recipes-graphics/mutter/mutter_git.bb         |    2 +-
 .../sato-icon-theme/sato-icon-theme.inc            |   13 ++++++-----
 .../sato-icon-theme/sato-icon-theme_0.4.1.bb       |    2 +-
 .../recipes-support/consolekit/consolekit_0.4.5.bb |    2 +-
 meta/recipes-support/libcroco/libcroco_0.6.3.bb    |    2 +-
 meta/recipes-support/vte/vte_0.28.2.bb             |    2 +-
 29 files changed, 94 insertions(+), 41 deletions(-)
Andreas Müller - Sept. 20, 2012, 3:38 p.m.
On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
<laurentiu.palcu@intel.com> wrote:
>
>
> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>> <laurentiu.palcu@intel.com> wrote:
>>> Hi,
>>>
>>> It's been quite a long time since I sent the first version of postinstall
>>> improvements which, after some debate, we decided it needed run-once
>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>> that.
>>>
>>> So, in order to achieve this goal I took advantage of
>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>> then we can postpone the running and run the scriplet just once. The idea is
>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>> this directory and execute them.
>>>
>>> This actual patchset does the above for the gtk icon cache generation which
>>> takes a very long time to run on target and even on some hosts.
>>>
>>> The people willing to give this patchset a test, are most than welcome. Also,
>>> please feel free to review.
>>>
>>> Thanks,
>>> Laurentiu
>>>
>> Thanks for taking care. I will give it a test tonight and hope to have
>> results tomorrow.
> It would be great if you could give it a try and let me know your results.
>
I removed gtk-native append in meta-oe, build from scratch and tested
the image. No issues so far - seems you have done a great job -
Thanks!

Andreas
Andreas Müller - Sept. 20, 2012, 4:12 p.m.
On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
> <laurentiu.palcu@intel.com> wrote:
>>
>>
>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>> <laurentiu.palcu@intel.com> wrote:
>>>> Hi,
>>>>
>>>> It's been quite a long time since I sent the first version of postinstall
>>>> improvements which, after some debate, we decided it needed run-once
>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>> that.
>>>>
>>>> So, in order to achieve this goal I took advantage of
>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>> this directory and execute them.
>>>>
>>>> This actual patchset does the above for the gtk icon cache generation which
>>>> takes a very long time to run on target and even on some hosts.
>>>>
>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>> please feel free to review.
>>>>
>>>> Thanks,
>>>> Laurentiu
>>>>
>>> Thanks for taking care. I will give it a test tonight and hope to have
>>> results tomorrow.
>> It would be great if you could give it a try and let me know your results.
>>
> I removed gtk-native append in meta-oe, build from scratch and tested
> the image. No issues so far - seems you have done a great job -
> Thanks!
>
Aargh I really would like to consider this done but I found suspicious
when browsing on the machine with the new image (hicolor- and
gnome-icon-theme installed):

* in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
* /usr/share/icons/hicolor/icon-theme.cache is there but it has the
date of 01.01.2000 (have no rtc backup on the machine). I would expect
this file to have build host's date.

So I checked the contents on the build machine in image's rootfs:

* in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
* /usr/share/icons/hicolor/icon-theme.cache is there but has only
64,5KB (the version on the machine is 2,3MB!!).


Andreas
Laurentiu Palcu - Sept. 20, 2012, 6:15 p.m.
On 09/20/2012 07:12 PM, Andreas Müller wrote:
> On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
>> <laurentiu.palcu@intel.com> wrote:
>>>
>>>
>>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>>> <laurentiu.palcu@intel.com> wrote:
>>>>> Hi,
>>>>>
>>>>> It's been quite a long time since I sent the first version of postinstall
>>>>> improvements which, after some debate, we decided it needed run-once
>>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>>> that.
>>>>>
>>>>> So, in order to achieve this goal I took advantage of
>>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>>> this directory and execute them.
>>>>>
>>>>> This actual patchset does the above for the gtk icon cache generation which
>>>>> takes a very long time to run on target and even on some hosts.
>>>>>
>>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>>> please feel free to review.
>>>>>
>>>>> Thanks,
>>>>> Laurentiu
>>>>>
>>>> Thanks for taking care. I will give it a test tonight and hope to have
>>>> results tomorrow.
>>> It would be great if you could give it a try and let me know your results.
>>>
>> I removed gtk-native append in meta-oe, build from scratch and tested
Any special reason you removed it?

>> the image. No issues so far - seems you have done a great job -
>> Thanks!
>>
> Aargh I really would like to consider this done but I found suspicious
> when browsing on the machine with the new image (hicolor- and
> gnome-icon-theme installed):
Let's hope we'll have it done soon. Thanks a lot for testing it. Can you
instruct me what image did you use and give some more details in order
to debug it on my side?

> 
> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
> * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
> date of 01.01.2000 (have no rtc backup on the machine). I would expect
> this file to have build host's date.
> 
> So I checked the contents on the build machine in image's rootfs:
> 
> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
That's weird... You could add some debug info in the intercept script
itself to see if it really scans the gnome directory and if there are
any errors.

> * /usr/share/icons/hicolor/icon-theme.cache is there but has only
> 64,5KB (the version on the machine is 2,3MB!!).
On my build machine (I used Sato image) the icon-theme.cache has 2.5MB.
There must be something wrong somewhere... At least this directory
should have been cached properly.

If you give all the details I asked above, I'll give it a try myself.
> 
> 
> Andreas
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Martin Jansa - Sept. 20, 2012, 8:54 p.m.
On Thu, Sep 20, 2012 at 09:15:02PM +0300, Laurentiu Palcu wrote:
> 
> 
> On 09/20/2012 07:12 PM, Andreas Müller wrote:
> > On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
> > <schnitzeltony@googlemail.com> wrote:
> >> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
> >> <laurentiu.palcu@intel.com> wrote:
> >>>
> >>>
> >>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
> >>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
> >>>> <laurentiu.palcu@intel.com> wrote:
> >>>>> Hi,
> >>>>>
> >>>>> It's been quite a long time since I sent the first version of postinstall
> >>>>> improvements which, after some debate, we decided it needed run-once
> >>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
> >>>>> that.
> >>>>>
> >>>>> So, in order to achieve this goal I took advantage of
> >>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
> >>>>> scriptlets is time consuming (even on host) and execute repeatedly,
> >>>>> then we can postpone the running and run the scriplet just once. The idea is
> >>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
> >>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
> >>>>> this directory and execute them.
> >>>>>
> >>>>> This actual patchset does the above for the gtk icon cache generation which
> >>>>> takes a very long time to run on target and even on some hosts.
> >>>>>
> >>>>> The people willing to give this patchset a test, are most than welcome. Also,
> >>>>> please feel free to review.
> >>>>>
> >>>>> Thanks,
> >>>>> Laurentiu
> >>>>>
> >>>> Thanks for taking care. I will give it a test tonight and hope to have
> >>>> results tomorrow.
> >>> It would be great if you could give it a try and let me know your results.
> >>>
> >> I removed gtk-native append in meta-oe, build from scratch and tested
> Any special reason you removed it?

That BBCLASSEXTEND was in meta-oe for long time (for gtk+3):

http://lists.linuxtogo.org/pipermail/openembedded-commits/2012-January/062622.html

Last time I've tried to merge that .bbappend to oe-core it was refused:
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/019648.html

But now it's in oe-core and there is no reason to keep it in meta-oe too.

Cheers,

> 
> >> the image. No issues so far - seems you have done a great job -
> >> Thanks!
> >>
> > Aargh I really would like to consider this done but I found suspicious
> > when browsing on the machine with the new image (hicolor- and
> > gnome-icon-theme installed):
> Let's hope we'll have it done soon. Thanks a lot for testing it. Can you
> instruct me what image did you use and give some more details in order
> to debug it on my side?
> 
> > 
> > * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
> > * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
> > date of 01.01.2000 (have no rtc backup on the machine). I would expect
> > this file to have build host's date.
> > 
> > So I checked the contents on the build machine in image's rootfs:
> > 
> > * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
> That's weird... You could add some debug info in the intercept script
> itself to see if it really scans the gnome directory and if there are
> any errors.
> 
> > * /usr/share/icons/hicolor/icon-theme.cache is there but has only
> > 64,5KB (the version on the machine is 2,3MB!!).
> On my build machine (I used Sato image) the icon-theme.cache has 2.5MB.
> There must be something wrong somewhere... At least this directory
> should have been cached properly.
> 
> If you give all the details I asked above, I'll give it a try myself.
> > 
> > 
> > Andreas
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> > 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Laurentiu Palcu - Sept. 26, 2012, 7:09 a.m.
On 09/20/2012 07:12 PM, Andreas Müller wrote:
> On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
>> <laurentiu.palcu@intel.com> wrote:
>>>
>>>
>>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>>> <laurentiu.palcu@intel.com> wrote:
>>>>> Hi,
>>>>>
>>>>> It's been quite a long time since I sent the first version of postinstall
>>>>> improvements which, after some debate, we decided it needed run-once
>>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>>> that.
>>>>>
>>>>> So, in order to achieve this goal I took advantage of
>>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>>> this directory and execute them.
>>>>>
>>>>> This actual patchset does the above for the gtk icon cache generation which
>>>>> takes a very long time to run on target and even on some hosts.
>>>>>
>>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>>> please feel free to review.
>>>>>
>>>>> Thanks,
>>>>> Laurentiu
>>>>>
>>>> Thanks for taking care. I will give it a test tonight and hope to have
>>>> results tomorrow.
>>> It would be great if you could give it a try and let me know your results.
>>>
>> I removed gtk-native append in meta-oe, build from scratch and tested
>> the image. No issues so far - seems you have done a great job -
>> Thanks!
>>
> Aargh I really would like to consider this done but I found suspicious
> when browsing on the machine with the new image (hicolor- and
> gnome-icon-theme installed):
> 
> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
> * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
> date of 01.01.2000 (have no rtc backup on the machine). I would expect
> this file to have build host's date.
> 
> So I checked the contents on the build machine in image's rootfs:
> 
> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
> * /usr/share/icons/hicolor/icon-theme.cache is there but has only
> 64,5KB (the version on the machine is 2,3MB!!).
Did you have any chance to debug the issue on your setup? I tried to
replicate your environment but I failed. Lots of build errors, so I gave
up. It would have taken me more time to make your setup work than
debugging the real problem.

Another alternative would be for you to prepare a tarball with all the
repos and configs that you use and put it somewhere where I can take it.
It would be easier for me to directly start debugging your issue.

Thanks,
Laurentiu
> 
> 
> Andreas
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Andreas Müller - Sept. 26, 2012, 7:41 a.m.
On Wed, Sep 26, 2012 at 9:09 AM, Laurentiu Palcu
<laurentiu.palcu@intel.com> wrote:
>
>
> On 09/20/2012 07:12 PM, Andreas Müller wrote:
>> On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
>> <schnitzeltony@googlemail.com> wrote:
>>> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
>>> <laurentiu.palcu@intel.com> wrote:
>>>>
>>>>
>>>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> It's been quite a long time since I sent the first version of postinstall
>>>>>> improvements which, after some debate, we decided it needed run-once
>>>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>>>> that.
>>>>>>
>>>>>> So, in order to achieve this goal I took advantage of
>>>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>>>> this directory and execute them.
>>>>>>
>>>>>> This actual patchset does the above for the gtk icon cache generation which
>>>>>> takes a very long time to run on target and even on some hosts.
>>>>>>
>>>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>>>> please feel free to review.
>>>>>>
>>>>>> Thanks,
>>>>>> Laurentiu
>>>>>>
>>>>> Thanks for taking care. I will give it a test tonight and hope to have
>>>>> results tomorrow.
>>>> It would be great if you could give it a try and let me know your results.
>>>>
>>> I removed gtk-native append in meta-oe, build from scratch and tested
>>> the image. No issues so far - seems you have done a great job -
>>> Thanks!
>>>
>> Aargh I really would like to consider this done but I found suspicious
>> when browsing on the machine with the new image (hicolor- and
>> gnome-icon-theme installed):
>>
>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>> * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
>> date of 01.01.2000 (have no rtc backup on the machine). I would expect
>> this file to have build host's date.
>>
>> So I checked the contents on the build machine in image's rootfs:
>>
>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>> * /usr/share/icons/hicolor/icon-theme.cache is there but has only
>> 64,5KB (the version on the machine is 2,3MB!!).
> Did you have any chance to debug the issue on your setup? I tried to
> replicate your environment but I failed. Lots of build errors, so I gave
> up. It would have taken me more time to make your setup work than
> debugging the real problem.
>
> Another alternative would be for you to prepare a tarball with all the
> repos and configs that you use and put it somewhere where I can take it.
> It would be easier for me to directly start debugging your issue.
>
Sorry but I am occupied by other issues at the moment. Hope to find
time at the weekend to add some debug messages to see what's going on.

Andreas
Andreas Müller - Oct. 3, 2012, 11:37 p.m.
On Wed, Sep 26, 2012 at 9:41 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Wed, Sep 26, 2012 at 9:09 AM, Laurentiu Palcu
> <laurentiu.palcu@intel.com> wrote:
>>
>>
>> On 09/20/2012 07:12 PM, Andreas Müller wrote:
>>> On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
>>> <schnitzeltony@googlemail.com> wrote:
>>>> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>
>>>>>
>>>>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>>>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> It's been quite a long time since I sent the first version of postinstall
>>>>>>> improvements which, after some debate, we decided it needed run-once
>>>>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>>>>> that.
>>>>>>>
>>>>>>> So, in order to achieve this goal I took advantage of
>>>>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>>>>> this directory and execute them.
>>>>>>>
>>>>>>> This actual patchset does the above for the gtk icon cache generation which
>>>>>>> takes a very long time to run on target and even on some hosts.
>>>>>>>
>>>>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>>>>> please feel free to review.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Laurentiu
>>>>>>>
>>>>>> Thanks for taking care. I will give it a test tonight and hope to have
>>>>>> results tomorrow.
>>>>> It would be great if you could give it a try and let me know your results.
>>>>>
>>>> I removed gtk-native append in meta-oe, build from scratch and tested
>>>> the image. No issues so far - seems you have done a great job -
>>>> Thanks!
>>>>
>>> Aargh I really would like to consider this done but I found suspicious
>>> when browsing on the machine with the new image (hicolor- and
>>> gnome-icon-theme installed):
>>>
>>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>>> * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
>>> date of 01.01.2000 (have no rtc backup on the machine). I would expect
>>> this file to have build host's date.
>>>
>>> So I checked the contents on the build machine in image's rootfs:
>>>
>>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>>> * /usr/share/icons/hicolor/icon-theme.cache is there but has only
>>> 64,5KB (the version on the machine is 2,3MB!!).
>> Did you have any chance to debug the issue on your setup? I tried to
>> replicate your environment but I failed. Lots of build errors, so I gave
>> up. It would have taken me more time to make your setup work than
>> debugging the real problem.
>>
>> Another alternative would be for you to prepare a tarball with all the
>> repos and configs that you use and put it somewhere where I can take it.
>> It would be easier for me to directly start debugging your issue.
>>
> Sorry but I am occupied by other issues at the moment. Hope to find
> time at the weekend to add some debug messages to see what's going on.
>
Oh it's that simple: run_intercept_scriptlets is not called here (I
don't know what caused 'mini hicolor-icon-theme's cache)! You can
reproduce that e.g. by enabling buildhistory.

I simply replaced in image.bbclass

ROOTFS_POSTPROCESS_COMMAND ?= "run_intercept_scriptlets"
by
ROOTFS_POSTPROCESS_COMMAND =+ "run_intercept_scriptlets;"

an now see larger caches for all my icon themes. But the sizes are
still different from those mentioned above. Will run-test tomorrow.

Andreas
Andreas Müller - Oct. 4, 2012, 7:16 p.m.
On Thu, Oct 4, 2012 at 1:37 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Wed, Sep 26, 2012 at 9:41 AM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> On Wed, Sep 26, 2012 at 9:09 AM, Laurentiu Palcu
>> <laurentiu.palcu@intel.com> wrote:
>>>
>>>
>>> On 09/20/2012 07:12 PM, Andreas Müller wrote:
>>>> On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
>>>> <schnitzeltony@googlemail.com> wrote:
>>>>> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
>>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>>>>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>>>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> It's been quite a long time since I sent the first version of postinstall
>>>>>>>> improvements which, after some debate, we decided it needed run-once
>>>>>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>>>>>> that.
>>>>>>>>
>>>>>>>> So, in order to achieve this goal I took advantage of
>>>>>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>>>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>>>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>>>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>>>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>>>>>> this directory and execute them.
>>>>>>>>
>>>>>>>> This actual patchset does the above for the gtk icon cache generation which
>>>>>>>> takes a very long time to run on target and even on some hosts.
>>>>>>>>
>>>>>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>>>>>> please feel free to review.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Laurentiu
>>>>>>>>
>>>>>>> Thanks for taking care. I will give it a test tonight and hope to have
>>>>>>> results tomorrow.
>>>>>> It would be great if you could give it a try and let me know your results.
>>>>>>
>>>>> I removed gtk-native append in meta-oe, build from scratch and tested
>>>>> the image. No issues so far - seems you have done a great job -
>>>>> Thanks!
>>>>>
>>>> Aargh I really would like to consider this done but I found suspicious
>>>> when browsing on the machine with the new image (hicolor- and
>>>> gnome-icon-theme installed):
>>>>
>>>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>>>> * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
>>>> date of 01.01.2000 (have no rtc backup on the machine). I would expect
>>>> this file to have build host's date.
>>>>
>>>> So I checked the contents on the build machine in image's rootfs:
>>>>
>>>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>>>> * /usr/share/icons/hicolor/icon-theme.cache is there but has only
>>>> 64,5KB (the version on the machine is 2,3MB!!).
>>> Did you have any chance to debug the issue on your setup? I tried to
>>> replicate your environment but I failed. Lots of build errors, so I gave
>>> up. It would have taken me more time to make your setup work than
>>> debugging the real problem.
>>>
>>> Another alternative would be for you to prepare a tarball with all the
>>> repos and configs that you use and put it somewhere where I can take it.
>>> It would be easier for me to directly start debugging your issue.
>>>
>> Sorry but I am occupied by other issues at the moment. Hope to find
>> time at the weekend to add some debug messages to see what's going on.
>>
> Oh it's that simple: run_intercept_scriptlets is not called here (I
> don't know what caused 'mini hicolor-icon-theme's cache)! You can
> reproduce that e.g. by enabling buildhistory.
>
> I simply replaced in image.bbclass
>
> ROOTFS_POSTPROCESS_COMMAND ?= "run_intercept_scriptlets"
> by
> ROOTFS_POSTPROCESS_COMMAND =+ "run_intercept_scriptlets;"
>
> an now see larger caches for all my icon themes. But the sizes are
> still different from those mentioned above. Will run-test tomorrow.
>
> Andreas
Hey Laurentiu,

With the minor change mentioned above I tested all my working images
without issues. Thanks for taking care and speeding up first boot.

Andreas
Laurentiu Palcu - Oct. 5, 2012, 6:39 a.m.
On 10/04/2012 10:16 PM, Andreas Müller wrote:
> On Thu, Oct 4, 2012 at 1:37 AM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> On Wed, Sep 26, 2012 at 9:41 AM, Andreas Müller
>> <schnitzeltony@googlemail.com> wrote:
>>> On Wed, Sep 26, 2012 at 9:09 AM, Laurentiu Palcu
>>> <laurentiu.palcu@intel.com> wrote:
>>>>
>>>>
>>>> On 09/20/2012 07:12 PM, Andreas Müller wrote:
>>>>> On Thu, Sep 20, 2012 at 5:38 PM, Andreas Müller
>>>>> <schnitzeltony@googlemail.com> wrote:
>>>>>> On Wed, Sep 19, 2012 at 5:33 PM, Laurentiu Palcu
>>>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 09/19/2012 04:41 PM, Andreas Müller wrote:
>>>>>>>> On Wed, Sep 19, 2012 at 1:49 PM, Laurentiu Palcu
>>>>>>>> <laurentiu.palcu@intel.com> wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> It's been quite a long time since I sent the first version of postinstall
>>>>>>>>> improvements which, after some debate, we decided it needed run-once
>>>>>>>>> support of postinst scriptlets on host. This patcheset (RFC actually) adds
>>>>>>>>> that.
>>>>>>>>>
>>>>>>>>> So, in order to achieve this goal I took advantage of
>>>>>>>>> ROOTFS_POSTPROCESS_COMMAND variable. Basically, if running some postinst
>>>>>>>>> scriptlets is time consuming (even on host) and execute repeatedly,
>>>>>>>>> then we can postpone the running and run the scriplet just once. The idea is
>>>>>>>>> to put the scriptlet in the ${WORKDIR}/intercept_scripts directory. When the
>>>>>>>>> ROOTFS_POSTPROCESS_COMMAND is executed, it will pick up all the scripts in
>>>>>>>>> this directory and execute them.
>>>>>>>>>
>>>>>>>>> This actual patchset does the above for the gtk icon cache generation which
>>>>>>>>> takes a very long time to run on target and even on some hosts.
>>>>>>>>>
>>>>>>>>> The people willing to give this patchset a test, are most than welcome. Also,
>>>>>>>>> please feel free to review.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Laurentiu
>>>>>>>>>
>>>>>>>> Thanks for taking care. I will give it a test tonight and hope to have
>>>>>>>> results tomorrow.
>>>>>>> It would be great if you could give it a try and let me know your results.
>>>>>>>
>>>>>> I removed gtk-native append in meta-oe, build from scratch and tested
>>>>>> the image. No issues so far - seems you have done a great job -
>>>>>> Thanks!
>>>>>>
>>>>> Aargh I really would like to consider this done but I found suspicious
>>>>> when browsing on the machine with the new image (hicolor- and
>>>>> gnome-icon-theme installed):
>>>>>
>>>>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>>>>> * /usr/share/icons/hicolor/icon-theme.cache is there but it has the
>>>>> date of 01.01.2000 (have no rtc backup on the machine). I would expect
>>>>> this file to have build host's date.
>>>>>
>>>>> So I checked the contents on the build machine in image's rootfs:
>>>>>
>>>>> * in the folder /usr/share/icons/gnome *no* icon-theme.cache is found
>>>>> * /usr/share/icons/hicolor/icon-theme.cache is there but has only
>>>>> 64,5KB (the version on the machine is 2,3MB!!).
>>>> Did you have any chance to debug the issue on your setup? I tried to
>>>> replicate your environment but I failed. Lots of build errors, so I gave
>>>> up. It would have taken me more time to make your setup work than
>>>> debugging the real problem.
>>>>
>>>> Another alternative would be for you to prepare a tarball with all the
>>>> repos and configs that you use and put it somewhere where I can take it.
>>>> It would be easier for me to directly start debugging your issue.
>>>>
>>> Sorry but I am occupied by other issues at the moment. Hope to find
>>> time at the weekend to add some debug messages to see what's going on.
>>>
>> Oh it's that simple: run_intercept_scriptlets is not called here (I
>> don't know what caused 'mini hicolor-icon-theme's cache)! You can
>> reproduce that e.g. by enabling buildhistory.
>>
>> I simply replaced in image.bbclass
>>
>> ROOTFS_POSTPROCESS_COMMAND ?= "run_intercept_scriptlets"
>> by
>> ROOTFS_POSTPROCESS_COMMAND =+ "run_intercept_scriptlets;"
>>
>> an now see larger caches for all my icon themes. But the sizes are
>> still different from those mentioned above. Will run-test tomorrow.
>>
>> Andreas
> Hey Laurentiu,
> 
> With the minor change mentioned above I tested all my working images
> without issues. Thanks for taking care and speeding up first boot.

Thanks Andreas for your help with the tests and for finding the issue.
Unfortunately the patches will not be able to get into 1.3 (we're a
little late for that). I'll prepare another patch-set as soon as I'll
find some spare time and, hopefully, we'll get the patches in for 1.4.

Thanks,
Laurentiu

> 
> Andreas
>
Andreas Müller - Oct. 5, 2012, 8:43 p.m.
On Fri, Oct 5, 2012 at 8:39 AM, Laurentiu Palcu
<laurentiu.palcu@intel.com> wrote:
>>>
>>> ROOTFS_POSTPROCESS_COMMAND ?= "run_intercept_scriptlets"
>>> by
>>> ROOTFS_POSTPROCESS_COMMAND =+ "run_intercept_scriptlets;"
>>>
>>> an now see larger caches for all my icon themes. But the sizes are
>>> still different from those mentioned above. Will run-test tomorrow.
>>>
>>> Andreas
>> Hey Laurentiu,
>>
>> With the minor change mentioned above I tested all my working images
>> without issues. Thanks for taking care and speeding up first boot.
>
> Thanks Andreas for your help with the tests and for finding the issue.
> Unfortunately the patches will not be able to get into 1.3 (we're a
> little late for that). I'll prepare another patch-set as soon as I'll
> find some spare time and, hopefully, we'll get the patches in for 1.4.
>
> Thanks,
> Laurentiu
>
>>
>> Andreas
>>
Although I would like to get this in I agree. Meanwhile I will put the
modified patches in on one of my build machines to get further
experience with them.

Andreas