Patchwork python-scons_1.3.0: add missing dependencies

login
register
mail settings
Submitter Víctor Manuel Jáquez Leal
Date Jan. 25, 2011, 3:51 p.m.
Message ID <1295970665-14658-1-git-send-email-vjaquez@igalia.com>
Download mbox | patch
Permalink /patch/369/
State Accepted
Headers show

Comments

Víctor Manuel Jáquez Leal - Jan. 25, 2011, 3:51 p.m.
In order to launch scons in a board it depends on a couple python packages
which were not managed by the recipe.

This patch adds them.

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
---
 recipes/python/python-scons_1.3.0.bb |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Koen Kooi - Jan. 25, 2011, 3:59 p.m.
Some small nitpicks, see below

Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:

> In order to launch scons in a board it depends on a couple python packages
> which were not managed by the recipe.
> 
> This patch adds them.
> 
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
> ---
> recipes/python/python-scons_1.3.0.bb |    8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/python/python-scons_1.3.0.bb b/recipes/python/python-scons_1.3.0.bb
> index 792e3a5..0dc3236 100644
> --- a/recipes/python/python-scons_1.3.0.bb
> +++ b/recipes/python/python-scons_1.3.0.bb
> @@ -1,8 +1,16 @@
> DESCRIPTION = "A Software Construction Tool"
> SECTION = "devel/python"
> PRIORITY = "optional"
> +RDEPENDS_${PN} = "python-shell \
> +	       python-stringold \
> +	       python-lang \
> +	       python-io \
> +	       python-fcntl \
> +	       python-pickle \
> +	       python-crypt"

We generally put variables in the order OE uses them, so RDEPENDS should go next to do_package/FILES/etc. Historically it was on top, but that stopped making sense after switching to RDEPENDS_${PN}

> LICENSE = "GPL"

Could you fix that while you're at it? It would be  nice to know if it's GPLv2 or GPLv2+.

Other than that, the patch looks OK to me[1].

regards,

Koen

[1] Sconstructs still make my eyes bleed, but that's not the point
Víctor Manuel Jáquez Leal - Jan. 25, 2011, 4:18 p.m.
On Tue, Jan 25, 2011 at 04:59:25PM +0100, Koen Kooi wrote:
> Some small nitpicks, see below
> 
> Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
> 
> > In order to launch scons in a board it depends on a couple python packages
> > which were not managed by the recipe.
> > 

[snip]

> 
> We generally put variables in the order OE uses them, so RDEPENDS should go
> next to do_package/FILES/etc. Historically it was on top, but that stopped
> making sense after switching to RDEPENDS_${PN}

Done.

> 
> > LICENSE = "GPL"
> 
> Could you fix that while you're at it? It would be  nice to know if it's
> GPLv2 or GPLv2+.

Verified. It is MIT not GPL!

> 
> Other than that, the patch looks OK to me[1].
> 
> regards,
> 
> Koen
> 
> [1] Sconstructs still make my eyes bleed, but that's not the point

I do not like it either at all, but v8 uses it.

vmjl
Koen Kooi - Jan. 25, 2011, 4:22 p.m.
Op 25 jan 2011, om 17:18 heeft Víctor M. Jáquez L. het volgende geschreven:

> On Tue, Jan 25, 2011 at 04:59:25PM +0100, Koen Kooi wrote:
>> Some small nitpicks, see below
>> 
>> Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
>> 
>>> In order to launch scons in a board it depends on a couple python packages
>>> which were not managed by the recipe.
>>> 
> 
> [snip]
> 
>> 
>> We generally put variables in the order OE uses them, so RDEPENDS should go
>> next to do_package/FILES/etc. Historically it was on top, but that stopped
>> making sense after switching to RDEPENDS_${PN}
> 
> Done.
> 
>> 
>>> LICENSE = "GPL"
>> 
>> Could you fix that while you're at it? It would be  nice to know if it's
>> GPLv2 or GPLv2+.
> 
> Verified. It is MIT not GPL!

Good catch!

> 
>> 
>> Other than that, the patch looks OK to me[1].
>> 
>> regards,
>> 
>> Koen
>> 
>> [1] Sconstructs still make my eyes bleed, but that's not the point
> 
> I do not like it either at all, but v8 uses it.
> 
> vmjl

Patch

diff --git a/recipes/python/python-scons_1.3.0.bb b/recipes/python/python-scons_1.3.0.bb
index 792e3a5..0dc3236 100644
--- a/recipes/python/python-scons_1.3.0.bb
+++ b/recipes/python/python-scons_1.3.0.bb
@@ -1,8 +1,16 @@ 
 DESCRIPTION = "A Software Construction Tool"
 SECTION = "devel/python"
 PRIORITY = "optional"
+RDEPENDS_${PN} = "python-shell \
+	       python-stringold \
+	       python-lang \
+	       python-io \
+	       python-fcntl \
+	       python-pickle \
+	       python-crypt"
 LICENSE = "GPL"
 SRCNAME = "scons"
+PR = "r1"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz;name=scons \
            file://toolchain-from-env.SConscript \