Patchwork binutils.inc: binutils will build differently if this feature is enabled, so add a dependency

login
mail settings
Submitter Matthew McClintock
Date Sept. 18, 2012, 10:08 p.m.
Message ID <1348006091-14992-7-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/36861/
State Accepted
Commit 0788cf349fe37ef4a36c626dbc396c97d1ab14d7
Headers show

Comments

Matthew McClintock - Sept. 18, 2012, 10:08 p.m.
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
Not sure if we should try to fix via configure options

 meta/recipes-devtools/binutils/binutils.inc |    2 ++
 1 file changed, 2 insertions(+)
Ross Burton - Sept. 19, 2012, 4:35 a.m.
"this feature"?  Please use descriptive commit logs, so s/this
feature/mulitarch/.

Ross
McClintock Matthew-B29882 - Sept. 19, 2012, 4:52 a.m.
On Tue, Sep 18, 2012 at 11:35 PM, Burton, Ross <ross.burton@intel.com> wrote:
> "this feature"?  Please use descriptive commit logs, so s/this
> feature/mulitarch/.

I will update this and send a v2, after I wait a bit for more comments.

-M

>
> Ross
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
index ee748a4..ff64882 100644
--- a/meta/recipes-devtools/binutils/binutils.inc
+++ b/meta/recipes-devtools/binutils/binutils.inc
@@ -80,6 +80,8 @@  export CC_FOR_BUILD = "LD_LIBRARY_PATH= ${BUILD_CC}"
 export CPP_FOR_BUILD = "${BUILD_CPP}"
 export CFLAGS_FOR_BUILD = "${BUILD_CFLAGS}"
 
+MULTIARCH := "${@bb.utils.contains("DISTRO_FEATURES", "multiarch", "yes", "no", d)}"
+do_configure[vardeps] += "MULTIARCH"
 do_configure () {
 	(cd ${S}; gnu-configize) || die "Failed to run gnu-configize"
 	oe_runconf