Patchwork [1/1] rpm 5.4.9: DEPENDS on bison-native

login
register
mail settings
Submitter Robert Yang
Date Sept. 18, 2012, 10:18 a.m.
Message ID <0c67727e1f680f450680af0cad3dca4b8a295998.1347950270.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/36723/
State New
Headers show

Comments

Robert Yang - Sept. 18, 2012, 10:18 a.m.
The rpm should depend on bison-native, otherwise errors when "bitbake
rpm-native" in a fresh build:

| make[4]: Entering directory `/path/to/rpm-native-5.4.9-r46/rpm-5.4.9/syck/lib'
| bison -d -t -v -p syck -o gram.c gram.y
| make[4]: bison: Command not found

Basically, both the rpm-native and rpm should depend on bison-native,
but don't need depend on bison, but it seems that it isn't necessary
to add another depend line:

DEPENDS_virtclass-native = "libpcre-native ... bison-native"

So just add it to the DEPENDS.

[YOCTO #3123]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-devtools/rpm/rpm_5.4.9.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - Sept. 18, 2012, 10:28 a.m.
On Tue, 2012-09-18 at 18:18 +0800, Robert Yang wrote:
> The rpm should depend on bison-native, otherwise errors when "bitbake
> rpm-native" in a fresh build:
> 
> | make[4]: Entering directory `/path/to/rpm-native-5.4.9-r46/rpm-5.4.9/syck/lib'
> | bison -d -t -v -p syck -o gram.c gram.y
> | make[4]: bison: Command not found
> 
> Basically, both the rpm-native and rpm should depend on bison-native,
> but don't need depend on bison, but it seems that it isn't necessary
> to add another depend line:
> 
> DEPENDS_virtclass-native = "libpcre-native ... bison-native"
> 
> So just add it to the DEPENDS.
> 
> [YOCTO #3123]
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/recipes-devtools/rpm/rpm_5.4.9.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> index e276cc3..ee0e86f 100644
> --- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> +++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> @@ -42,8 +42,8 @@ HOMEPAGE = "http://rpm5.org/"
>  LICENSE = "LGPLv2.1"
>  LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
>  
> -DEPENDS = "libpcre attr acl popt ossp-uuid file"
> -PR = "r46"
> +DEPENDS = "libpcre attr acl popt ossp-uuid file bison"
> +PR = "r47"

According to what you wrote above ("but don't need depend on bison"),
this should be:

DEPENDS = "libpcre attr acl popt ossp-uuid file bison-native"

?

Cheers,

Richard
Robert Yang - Sept. 18, 2012, 11:45 a.m.
On 09/18/2012 06:28 PM, Richard Purdie wrote:
> On Tue, 2012-09-18 at 18:18 +0800, Robert Yang wrote:
>> The rpm should depend on bison-native, otherwise errors when "bitbake
>> rpm-native" in a fresh build:
>>
>> | make[4]: Entering directory `/path/to/rpm-native-5.4.9-r46/rpm-5.4.9/syck/lib'
>> | bison -d -t -v -p syck -o gram.c gram.y
>> | make[4]: bison: Command not found
>>
>> Basically, both the rpm-native and rpm should depend on bison-native,
>> but don't need depend on bison, but it seems that it isn't necessary
>> to add another depend line:
>>
>> DEPENDS_virtclass-native = "libpcre-native ... bison-native"
>>
>> So just add it to the DEPENDS.
>>
>> [YOCTO #3123]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-devtools/rpm/rpm_5.4.9.bb | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
>> index e276cc3..ee0e86f 100644
>> --- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
>> +++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
>> @@ -42,8 +42,8 @@ HOMEPAGE = "http://rpm5.org/"
>>   LICENSE = "LGPLv2.1"
>>   LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
>>
>> -DEPENDS = "libpcre attr acl popt ossp-uuid file"
>> -PR = "r46"
>> +DEPENDS = "libpcre attr acl popt ossp-uuid file bison"
>> +PR = "r47"
>
> According to what you wrote above ("but don't need depend on bison"),
> this should be:
>
> DEPENDS = "libpcre attr acl popt ossp-uuid file bison-native"
>
> ?
>

Yes, thanks, what I had thought was that rpm-native would depend on
bison-native, but missed rpm's depends.

I have updated it and pushed into the git repo:

git://git.pokylinux.org/poky-contrib robert/rpmdepend

// Robert

> Cheers,
>
> Richard
>
>
>
>

Patch

diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
index e276cc3..ee0e86f 100644
--- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
+++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
@@ -42,8 +42,8 @@  HOMEPAGE = "http://rpm5.org/"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
 
-DEPENDS = "libpcre attr acl popt ossp-uuid file"
-PR = "r46"
+DEPENDS = "libpcre attr acl popt ossp-uuid file bison"
+PR = "r47"
 
 # rpm2cpio is a shell script, which is part of the rpm src.rpm.  It is needed
 # in order to extract the distribution SRPM into a format we can extract...