Patchwork [1/2] ncurses: Update gnu-config files to version used by OE-Core

login
register
mail settings
Submitter Marcin Juszkiewicz
Date Sept. 18, 2012, 9 a.m.
Message ID <1347958808-20182-1-git-send-email-marcin.juszkiewicz@linaro.org>
Download mbox | patch
Permalink /patch/36709/
State New
Headers show

Comments

Marcin Juszkiewicz - Sept. 18, 2012, 9 a.m.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 meta/recipes-core/ncurses/ncurses.inc |    5 +++++
 1 file changed, 5 insertions(+)
Koen Kooi - Sept. 18, 2012, 10:40 a.m.
Op 18 sep. 2012, om 11:00 heeft Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> het volgende geschreven:

> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> meta/recipes-core/ncurses/ncurses.inc |    5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> index 91b1f34..3ff0914 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -59,6 +59,11 @@ ncurses_configure() {
> 	cd ..
> }
> 
> +# Update gnu-config files to version used by OE-Core
> +do_configure_prepend() {
> +	install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.{guess,sub} ${S}
> +}
> +

Apart from the missing PR bumps, isn't autotools.bbclass supposed to handle this?
Marcin Juszkiewicz - Sept. 18, 2012, 10:43 a.m.
W dniu 18.09.2012 12:40, Koen Kooi pisze:
>> +# Update gnu-config files to version used by OE-Core
>> +do_configure_prepend() {
>> +	install -m 0755
${STAGING_DATADIR_NATIVE}/gnu-config/config.{guess,sub} ${S}
>> +}

> Apart from the missing PR bumps

For normal OE builds situation does not change too much so that's why I
skipped PR bump. For 64-bit ARM it does not build without it so no PR as
well.

> isn't autotools.bbclass supposed to handle this?

autotools.bbclass does it in own do_configure. But both db and ncurses
uses own do_configure without calling autoreconf.

Patch

diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
index 91b1f34..3ff0914 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -59,6 +59,11 @@  ncurses_configure() {
 	cd ..
 }
 
+# Update gnu-config files to version used by OE-Core
+do_configure_prepend() {
+	install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.{guess,sub} ${S}
+}
+
 # Override the function from the autotools class; ncurses requires a
 # patched autoconf213 to generate the configure script. This autoconf
 # is not available so that the shipped script will be used.