Patchwork [for-denzil,pulseaudio-updates,01/10] pulseaudio: disable tcpwrap by default

login
register
mail settings
Submitter Koen Kooi
Date Sept. 17, 2012, 12:07 p.m.
Message ID <1347883657-17529-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/36635/
State New
Headers show

Comments

Koen Kooi - Sept. 17, 2012, 12:07 p.m.
From: Saul Wold <sgw@linux.intel.com>

This ensures that tcpwrapper usage is always disabled, this was
inconsistent because it would test for libwrap and sometimes enable
and sometimes not.

This ensures consistent build reproducibility.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    1 +
 .../pulseaudio/pulseaudio_1.1.bb                   |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
Koen Kooi - Sept. 19, 2012, 5:57 a.m.
So Scott asked me to explain why these pulseaudio updates are needed in denzil, and it's mainly because of udev. The old bluez is using deprecated udev API that went away in newer releases and I'm trying to get a more recent udev into meta-oe to fix bugs people have reported.
I must admit that pulseaudio 1.x to 2.x is a big step, so patch 7 through 10 are questionable and could be replaced with backporting the udev api fix from git. But I opted for cherry-picking from master to leverage the oe-core QA.

regards,

Koen

Op 17 sep. 2012, om 14:07 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:

> From: Saul Wold <sgw@linux.intel.com>
> 
> This ensures that tcpwrapper usage is always disabled, this was
> inconsistent because it would test for libwrap and sometimes enable
> and sometimes not.
> 
> This ensures consistent build reproducibility.
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    1 +
> .../pulseaudio/pulseaudio_1.1.bb                   |    2 +-
> 2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index a653af5..a2f0d9f 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -31,6 +31,7 @@ EXTRA_OECONF = "\
> 		--without-hal \
> 		--disable-hal \
> 		--disable-orc \
> +		--enable-tcpwrap=no \
> 		--with-access-group=audio \
> "
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
> index fd61149..d2ed3c8 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
> @@ -1,6 +1,6 @@
> require pulseaudio.inc
> 
> -PR = "r8"
> +PR = "r9"
> 
> DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
> 
> -- 
> 1.7.7.6
>
Martin Jansa - Sept. 19, 2012, 8:57 a.m.
On Wed, Sep 19, 2012 at 07:57:00AM +0200, Koen Kooi wrote:
> So Scott asked me to explain why these pulseaudio updates are needed in denzil, and it's mainly because of udev. The old bluez is using deprecated udev API that went away in newer releases and I'm trying to get a more recent udev into meta-oe to fix bugs people have reported.
> I must admit that pulseaudio 1.x to 2.x is a big step, so patch 7 through 10 are questionable and could be replaced with backporting the udev api fix from git. But I opted for cherry-picking from master to leverage the oe-core QA.

I'm not using denzil, but something like this could help in meta-oe
http://git.openembedded.org/meta-openembedded/commit/?id=9e2751773cd523b338d7962030356a1bce327174

> regards,
> 
> Koen
> 
> Op 17 sep. 2012, om 14:07 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
> 
> > From: Saul Wold <sgw@linux.intel.com>
> > 
> > This ensures that tcpwrapper usage is always disabled, this was
> > inconsistent because it would test for libwrap and sometimes enable
> > and sometimes not.
> > 
> > This ensures consistent build reproducibility.
> > 
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> > meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    1 +
> > .../pulseaudio/pulseaudio_1.1.bb                   |    2 +-
> > 2 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > index a653af5..a2f0d9f 100644
> > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > @@ -31,6 +31,7 @@ EXTRA_OECONF = "\
> > 		--without-hal \
> > 		--disable-hal \
> > 		--disable-orc \
> > +		--enable-tcpwrap=no \
> > 		--with-access-group=audio \
> > "
> > 
> > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
> > index fd61149..d2ed3c8 100644
> > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
> > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
> > @@ -1,6 +1,6 @@
> > require pulseaudio.inc
> > 
> > -PR = "r8"
> > +PR = "r9"
> > 
> > DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
> > 
> > -- 
> > 1.7.7.6
> > 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index a653af5..a2f0d9f 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -31,6 +31,7 @@  EXTRA_OECONF = "\
 		--without-hal \
 		--disable-hal \
 		--disable-orc \
+		--enable-tcpwrap=no \
 		--with-access-group=audio \
 "
 
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
index fd61149..d2ed3c8 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_1.1.bb
@@ -1,6 +1,6 @@ 
 require pulseaudio.inc
 
-PR = "r8"
+PR = "r9"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"