Patchwork [bitbake-devel] hob: rename 'View log' to 'Open log'

login
register
mail settings
Submitter Constantin Musca
Date Sept. 14, 2012, 9:58 a.m.
Message ID <1347616733-27180-1-git-send-email-constantinx.musca@intel.com>
Download mbox | patch
Permalink /patch/36533/
State New
Headers show

Comments

Constantin Musca - Sept. 14, 2012, 9:58 a.m.
Rename all the 'View log' buttons to 'Open log' for
consistency.

[YOCTO #3045]
---
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py     |   12 ++++++------
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py |   12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)
Richard Purdie - Sept. 20, 2012, 9:30 a.m.
On Fri, 2012-09-14 at 12:58 +0300, Constantin Musca wrote:
> Rename all the 'View log' buttons to 'Open log' for
> consistency.
> 
> [YOCTO #3045]
> ---
>  bitbake/lib/bb/ui/crumbs/imagedetailspage.py     |   12 ++++++------
>  bitbake/lib/bb/ui/crumbs/packageselectionpage.py |   12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)


Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
index cb3ca86..1d26ad6 100755
--- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
+++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
@@ -249,12 +249,12 @@  class ImageDetailsPage (HobPage):
         view_files_button = HobAltButton("View files")
         view_files_button.connect("clicked", self.view_files_clicked_cb, image_addr)
         view_files_button.set_tooltip_text("Open the directory containing the image files")
-        view_log_button = None
+        open_log_button = None
         if log_file:
-            view_log_button = HobAltButton("View log")
-            view_log_button.connect("clicked", self.view_log_clicked_cb, log_file)
-            view_log_button.set_tooltip_text("Open the building log files")
-        self.image_detail = self.DetailBox(varlist=varlist, vallist=vallist, button=view_files_button, button2=view_log_button)
+            open_log_button = HobAltButton("Open log")
+            open_log_button.connect("clicked", self.open_log_clicked_cb, log_file)
+            open_log_button.set_tooltip_text("Open the build's log file")
+        self.image_detail = self.DetailBox(varlist=varlist, vallist=vallist, button=view_files_button, button2=open_log_button)
         self.box_group_area.pack_start(self.image_detail, expand=False, fill=True)
 
         # The default kernel box for the qemu images
@@ -333,7 +333,7 @@  class ImageDetailsPage (HobPage):
     def view_files_clicked_cb(self, button, image_addr):
         subprocess.call("xdg-open /%s" % image_addr, shell=True)
 
-    def view_log_clicked_cb(self, button, log_file):
+    def open_log_clicked_cb(self, button, log_file):
         if log_file:
             os.system("xdg-open /%s" % log_file)
 
diff --git a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
index e3d35ef..edbafbd 100755
--- a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
+++ b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
@@ -165,7 +165,7 @@  class PackageSelectionPage (HobPage):
             if binb:
                 self.builder.show_binb_dialog(binb)
 
-    def view_log_clicked_cb(self, button, log_file):
+    def open_log_clicked_cb(self, button, log_file):
         if log_file:
             os.system("xdg-open /%s" % log_file)
 
@@ -173,13 +173,13 @@  class PackageSelectionPage (HobPage):
         children = self.button_box.get_children() or []
         for child in children:
             self.button_box.remove(child)
-        # re-packed the buttons as request, add the 'view log' button if build success
+        # re-packed the buttons as request, add the 'open log' button if build success
         self.button_box.pack_end(self.build_image_button, expand=False, fill=False)
         if log_file:
-            view_log_button = HobAltButton("View log")
-            view_log_button.connect("clicked", self.view_log_clicked_cb, log_file)
-            view_log_button.set_tooltip_text("Open the building log files")
-            self.button_box.pack_end(view_log_button, expand=False, fill=False)
+            open_log_button = HobAltButton("Open log")
+            open_log_button.connect("clicked", self.open_log_clicked_cb, log_file)
+            open_log_button.set_tooltip_text("Open the build's log file")
+            self.button_box.pack_end(open_log_button, expand=False, fill=False)
         self.button_box.pack_end(self.back_button, expand=False, fill=False)
         self.show_all()