Patchwork [1/2] gst-ffmpeg: add LICENSE_FLAGS

login
register
mail settings
Submitter Paul Eggleton
Date Sept. 13, 2012, 11:03 a.m.
Message ID <6ccf7a1f517e37ce7a8467f4a2432b1ae957e837.1347534093.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/36469/
State Accepted
Commit b616c9461da221d99086b6cc4f30d6f3745a91f1
Headers show

Comments

Paul Eggleton - Sept. 13, 2012, 11:03 a.m.
This likely requires some form of license to use in a commercial
product.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 .../gstreamer/gst-ffmpeg_0.10.13.bb                |    1 +
 1 file changed, 1 insertion(+)
Saul Wold - Sept. 14, 2012, 6:28 a.m.
On 09/13/2012 04:03 AM, Paul Eggleton wrote:
> This likely requires some form of license to use in a commercial
> product.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>   .../gstreamer/gst-ffmpeg_0.10.13.bb                |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb b/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb
> index efab2cf..2107704 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb
> @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>                       file://gst-libs/ext/libav/COPYING.GPLv3;md5=d32239bcb673463ab874e80d47fae504 \
>                       file://gst-libs/ext/libav/COPYING.LGPLv2.1;md5=e344c8fa836c3a41c4cbd79d7bd3a379 \
>                       file://gst-libs/ext/libav/COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02"
> +LICENSE_FLAGS = "commercial"
>   HOMEPAGE = "http://www.gstreamer.net/"
>   DEPENDS = "gstreamer gst-plugins-base zlib bzip2"
>
>

Failures from MUT:


http://autobuilder.yoctoproject.org:8010/builders/meta-intel-gpl/builds/47/steps/shell_42/logs/stdio

Seems to add some new ERRORS:

ERROR: Nothing PROVIDES 'libcroco-native' (but 
virtual:native:/srv/home/pokybuild/yocto-autobuilder/yocto-slave/meta-intel-gpl/build/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb 
DEPENDS on or otherwise requires it)
ERROR: Nothing RPROVIDES 'gst-ffmpeg' (but 
/srv/home/pokybuild/yocto-autobuilder/yocto-slave/meta-intel-gpl/build/yocto/meta-intel/common/recipes-multimedia/gstreamer/gst-va-intel.bb 
RDEPENDS on or otherwise requires it)
ERROR: gst-ffmpeg was skipped: because it has a restricted license not 
whitelisted in LICENSE_FLAGS_WHITELIST
NOTE: Runtime target 'gst-ffmpeg' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['gst-ffmpeg']
ERROR: Nothing RPROVIDES 'gst-va-intel-general' (but 
/srv/home/pokybuild/yocto-autobuilder/yocto-slave/meta-intel-gpl/build/yocto/meta-intel/common/recipes-multimedia/gstreamer/gst-va-intel.bb 
RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'gst-va-intel-general'
NOTE: Runtime target 'gst-va-intel-general' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['gst-va-intel-general']
ERROR: Nothing RPROVIDES 'gst-va-intel-video' (but 
/srv/home/pokybuild/yocto-autobuilder/yocto-slave/meta-intel-gpl/build/yocto/meta-intel/common/recipes-multimedia/gstreamer/gst-va-intel.bb 
RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'gst-va-intel-video'
NOTE: Runtime target 'gst-va-intel-video' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['gst-va-intel-video']
Ross Burton - Sept. 14, 2012, 9:23 a.m.
On 14 September 2012 07:28, Saul Wold <sgw@linux.intel.com> wrote:
> ERROR: Nothing RPROVIDES 'gst-ffmpeg' (but
> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/meta-intel-gpl/build/yocto/meta-intel/common/recipes-multimedia/gstreamer/gst-va-intel.bb
> RDEPENDS on or otherwise requires it)

That's interesting, I wasn't aware gst-va required ffmpeg.  At the
most it should be a recommends as elements are pluggable, and to be
honest I'm pretty sure that's a bad dependency.

Ross
Tom Zanussi - Sept. 14, 2012, 1:34 p.m.
On Fri, 2012-09-14 at 10:23 +0100, Burton, Ross wrote:
> On 14 September 2012 07:28, Saul Wold <sgw@linux.intel.com> wrote:
> > ERROR: Nothing RPROVIDES 'gst-ffmpeg' (but
> > /srv/home/pokybuild/yocto-autobuilder/yocto-slave/meta-intel-gpl/build/yocto/meta-intel/common/recipes-multimedia/gstreamer/gst-va-intel.bb
> > RDEPENDS on or otherwise requires it)
> 
> That's interesting, I wasn't aware gst-va required ffmpeg.  At the
> most it should be a recommends as elements are pluggable, and to be
> honest I'm pretty sure that's a bad dependency.
> 

So some of the meta-intel BSPs add this as RRECOMMENDS to get video
acceleration support under gstreamer:

MACHINE_EXTRA_RRECOMMENDS += "gst-va-intel"

and that adds a runtime dependency on gst-ffmpeg, which in turn uses a
local ffmpeg that does this to enable video video acceleration:

        --enable-vaapi \

but also does this to avoid being 'commercial':

        --enable-gpl \

So unless there's something that requires gst-ffmpeg to be commercial, I
don't think gst-ffmpeg actually needs commercial LICENSE_FLAGS.  What
was the reason it was added now after all this time in the first place?

Tom

> Ross
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb b/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb
index efab2cf..2107704 100644
--- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg_0.10.13.bb
@@ -10,6 +10,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
                     file://gst-libs/ext/libav/COPYING.GPLv3;md5=d32239bcb673463ab874e80d47fae504 \
                     file://gst-libs/ext/libav/COPYING.LGPLv2.1;md5=e344c8fa836c3a41c4cbd79d7bd3a379 \
                     file://gst-libs/ext/libav/COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02"
+LICENSE_FLAGS = "commercial"
 HOMEPAGE = "http://www.gstreamer.net/"
 DEPENDS = "gstreamer gst-plugins-base zlib bzip2"