Patchwork cml1.bbclass: fix kernel menuconfig

login
register
mail settings
Submitter Andreas Müller
Date Sept. 12, 2012, 1:19 p.m.
Message ID <1347455995-24565-1-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/36425/
State New
Headers show

Comments

Andreas Müller - Sept. 12, 2012, 1:19 p.m.
At some host environments the menuconfig displayed wrong characters ang turned
unusable.

Similar suggested in [1]

[1] http://lists.linuxtogo.org/pipermail/openembedded-core/2012-August/027130.html

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/classes/cml1.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Sept. 12, 2012, 1:31 p.m.
On Wed, 2012-09-12 at 15:19 +0200, Andreas Müller wrote:
> At some host environments the menuconfig displayed wrong characters ang turned
> unusable.
> 
> Similar suggested in [1]
> 
> [1] http://lists.linuxtogo.org/pipermail/openembedded-core/2012-August/027130.html
> 
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta/classes/cml1.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 67f17ad..c773684 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -9,7 +9,7 @@ addtask configure after do_unpack do_patch before do_compile
>  
>  inherit terminal
>  
> -OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS HOST_LOADLIBES"
> +OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOST_LOADLIBES"
>  HOST_EXTRACFLAGS = "${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
>  HOSTLDFLAGS = "${BUILD_LDFLAGS}"
>  HOST_LOADLIBES = "-lncurses"

This effectively just reverts the previous change. The real problem is
that ncurses-native is broken. Could we figure out how/why
ncurses-native is broken and fix the real problem rather than hacking
around it please?

FWIW I've been unable to reproduce this locally :(.

Cheers,

Richard
Bruce Ashfield - Sept. 12, 2012, 1:38 p.m.
On Wed, Sep 12, 2012 at 9:31 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2012-09-12 at 15:19 +0200, Andreas Müller wrote:
>> At some host environments the menuconfig displayed wrong characters ang turned
>> unusable.
>>
>> Similar suggested in [1]
>>
>> [1] http://lists.linuxtogo.org/pipermail/openembedded-core/2012-August/027130.html
>>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> ---
>>  meta/classes/cml1.bbclass |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
>> index 67f17ad..c773684 100644
>> --- a/meta/classes/cml1.bbclass
>> +++ b/meta/classes/cml1.bbclass
>> @@ -9,7 +9,7 @@ addtask configure after do_unpack do_patch before do_compile
>>
>>  inherit terminal
>>
>> -OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS HOST_LOADLIBES"
>> +OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOST_LOADLIBES"
>>  HOST_EXTRACFLAGS = "${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
>>  HOSTLDFLAGS = "${BUILD_LDFLAGS}"
>>  HOST_LOADLIBES = "-lncurses"
>
> This effectively just reverts the previous change. The real problem is
> that ncurses-native is broken. Could we figure out how/why
> ncurses-native is broken and fix the real problem rather than hacking
> around it please?
>
> FWIW I've been unable to reproduce this locally :(.

I've also tried to reproduce this periodically and have never seen it where
I can debug it properly.

I'm also not disputing that this is an issue .. just one I can't get at yet
either.

Cheers,

Bruce

>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Samuel Stirtzel - Sept. 12, 2012, 2:21 p.m.
2012/9/12 Bruce Ashfield <bruce.ashfield@gmail.com>:
> On Wed, Sep 12, 2012 at 9:31 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> FWIW I've been unable to reproduce this locally :(.
>
> I've also tried to reproduce this periodically and have never seen it where
> I can debug it properly.
>
> I'm also not disputing that this is an issue .. just one I can't get at yet
> either.

It seems like this issue is only triggered on Fedora machines..
(At least there were 2 reports of this issue on Fedora)

So far I've got no problems with (K)Ubuntu machines.
But I've seen this on a Fedora 17 one too.

>
> Cheers,
>
> Bruce
>
Martin Jansa - Sept. 12, 2012, 2:22 p.m.
On Wed, Sep 12, 2012 at 04:21:15PM +0200, Samuel Stirtzel wrote:
> 2012/9/12 Bruce Ashfield <bruce.ashfield@gmail.com>:
> > On Wed, Sep 12, 2012 at 9:31 AM, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> >> FWIW I've been unable to reproduce this locally :(.
> >
> > I've also tried to reproduce this periodically and have never seen it where
> > I can debug it properly.
> >
> > I'm also not disputing that this is an issue .. just one I can't get at yet
> > either.
> 
> It seems like this issue is only triggered on Fedora machines..
> (At least there were 2 reports of this issue on Fedora)

and Gentoo

> So far I've got no problems with (K)Ubuntu machines.
> But I've seen this on a Fedora 17 one too.
> 
> >
> > Cheers,
> >
> > Bruce
> >
> 
> -- 
> Regards
> Samuel
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 67f17ad..c773684 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -9,7 +9,7 @@  addtask configure after do_unpack do_patch before do_compile
 
 inherit terminal
 
-OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS HOST_LOADLIBES"
+OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOST_LOADLIBES"
 HOST_EXTRACFLAGS = "${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
 HOSTLDFLAGS = "${BUILD_LDFLAGS}"
 HOST_LOADLIBES = "-lncurses"