Patchwork [2/3] runqemu: Explicitly specify MACHINE when calling bitbake

login
register
mail settings
Submitter Khem Raj
Date Sept. 12, 2012, 5:59 a.m.
Message ID <1347429555-32159-2-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/36401/
State Accepted
Commit 5c3fec058a2d370fbb625901ca1822ce04927ac2
Headers show

Comments

Khem Raj - Sept. 12, 2012, 5:59 a.m.
When using runqemu with distros outside oe-core then
MACHINE may not be there in local.conf so use the one
thats available in environment of runqemu which is actually
the correct one.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 scripts/runqemu |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Scott Garman - Sept. 12, 2012, 10:12 p.m.
On 09/11/2012 10:59 PM, Khem Raj wrote:
> When using runqemu with distros outside oe-core then
> MACHINE may not be there in local.conf so use the one
> thats available in environment of runqemu which is actually
> the correct one.

Looks simple enough.

Acked-by: Scott Garman <scott.a.garman@intel.com>

>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   scripts/runqemu |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index a3c3509..e843946 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -281,7 +281,7 @@ setup_tmpdir() {
>               exit 1; }
>
>           # We have bitbake in PATH, get OE_TMPDIR from bitbake
> -        OE_TMPDIR=`bitbake -e | grep ^TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
> +        OE_TMPDIR=`MACHINE=$MACHINE bitbake -e | grep ^TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
>           if [ -z "$OE_TMPDIR" ]; then
>               echo "Error: this script needs to be run from your build directory,"
>               echo "or you need to explicitly set OE_TMPDIR in your environment"
>
Saul Wold - Sept. 14, 2012, 3:42 p.m.
On 09/11/2012 10:59 PM, Khem Raj wrote:
> When using runqemu with distros outside oe-core then
> MACHINE may not be there in local.conf so use the one
> thats available in environment of runqemu which is actually
> the correct one.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   scripts/runqemu |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index a3c3509..e843946 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -281,7 +281,7 @@ setup_tmpdir() {
>               exit 1; }
>
>           # We have bitbake in PATH, get OE_TMPDIR from bitbake
> -        OE_TMPDIR=`bitbake -e | grep ^TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
> +        OE_TMPDIR=`MACHINE=$MACHINE bitbake -e | grep ^TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
>           if [ -z "$OE_TMPDIR" ]; then
>               echo "Error: this script needs to be run from your build directory,"
>               echo "or you need to explicitly set OE_TMPDIR in your environment"
>

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/scripts/runqemu b/scripts/runqemu
index a3c3509..e843946 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -281,7 +281,7 @@  setup_tmpdir() {
             exit 1; }
 
         # We have bitbake in PATH, get OE_TMPDIR from bitbake
-        OE_TMPDIR=`bitbake -e | grep ^TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
+        OE_TMPDIR=`MACHINE=$MACHINE bitbake -e | grep ^TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
         if [ -z "$OE_TMPDIR" ]; then
             echo "Error: this script needs to be run from your build directory,"
             echo "or you need to explicitly set OE_TMPDIR in your environment"