From patchwork Tue Sep 11 16:51:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel,1/3] hob: don't reorder layers list Date: Tue, 11 Sep 2012 16:51:59 -0000 From: Paul Eggleton X-Patchwork-Id: 36333 Message-Id: <1d0b24190ed3cc08ef87691665ddc24cbe46dec6.1347382193.git.paul.eggleton@linux.intel.com> To: bitbake-devel@lists.openembedded.org We cannot reorder this list - it must stay in the order shown in the dialog (which may in future be configurable by the user). Fixes [YOCTO #2649]. Signed-off-by: Paul Eggleton --- bitbake/lib/bb/ui/crumbs/hig.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/bitbake/lib/bb/ui/crumbs/hig.py b/bitbake/lib/bb/ui/crumbs/hig.py index 3695fa0..d41a6b5 100644 --- a/bitbake/lib/bb/ui/crumbs/hig.py +++ b/bitbake/lib/bb/ui/crumbs/hig.py @@ -1029,14 +1029,8 @@ class LayerSelectionDialog (CrumbsDialog): table_layer.attach(scroll, 0, 10, 0, 1) layer_store = gtk.ListStore(gobject.TYPE_STRING) - core_iter = None for layer in layers: - if layer.endswith("/meta"): - core_iter = layer_store.prepend([layer]) - elif layer.endswith("/meta-hob") and core_iter: - layer_store.insert_after(core_iter, [layer]) - else: - layer_store.append([layer]) + layer_store.append([layer]) col1 = gtk.TreeViewColumn('Enabled') layer_tv.append_column(col1) @@ -1110,10 +1104,7 @@ class LayerSelectionDialog (CrumbsDialog): layers.append(model.get_value(it, 0)) it = model.iter_next(it) - orig_layers = sorted(self.layers) - layers.sort() - - self.layers_changed = (orig_layers != layers) + self.layers_changed = (self.layers != layers) self.layers = layers """