Patchwork [2011.03-maintenance] gdk-pixbuf: add missing dependencies

login
register
mail settings
Submitter Steffen Sledz
Date Sept. 11, 2012, 12:42 p.m.
Message ID <1347367374-10517-1-git-send-email-sledz@dresearch-fe.de>
Download mbox | patch
Permalink /patch/36279/
State Accepted
Headers show

Comments

Steffen Sledz - Sept. 11, 2012, 12:42 p.m.
This fixes an error in do_configure step for target and native build.

| checking for BASE_DEPENDENCIES... configure: error: Package requirements (glib-2.0 >= 2.12.0    atk >= 1.9.0    pango >= 1.12.0    cairo >= 1.2.0) were not met:
|
| No package 'atk' found
| No package 'pango' found
| No package 'cairo' found

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/gtk+/gdk-pixbuf_2.10.14.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ross Burton - Sept. 11, 2012, 12:59 p.m.
On 11 September 2012 13:42, Steffen Sledz <sledz@dresearch-fe.de> wrote:
> | No package 'atk' found
> | No package 'pango' found
> | No package 'cairo' found

Those are spurious dependencies in a very old version of gdk-pixbuf.

oe-core master has 2.24.1 at the moment, is there a good reason why
meta-oe is hanging onto 2.10.14?

Ross
Martin Jansa - Sept. 11, 2012, 1:02 p.m.
On Tue, Sep 11, 2012 at 01:59:21PM +0100, Burton, Ross wrote:
> On 11 September 2012 13:42, Steffen Sledz <sledz@dresearch-fe.de> wrote:
> > | No package 'atk' found
> > | No package 'pango' found
> > | No package 'cairo' found
> 
> Those are spurious dependencies in a very old version of gdk-pixbuf.
> 
> oe-core master has 2.24.1 at the moment, is there a good reason why
> meta-oe is hanging onto 2.10.14?

2011.03-maintenance != meta-oe
Paul Eggleton - Sept. 11, 2012, 1:03 p.m.
On Tuesday 11 September 2012 13:59:21 Burton, Ross wrote:
> On 11 September 2012 13:42, Steffen Sledz <sledz@dresearch-fe.de> wrote:
> > | No package 'atk' found
> > | No package 'pango' found
> > | No package 'cairo' found
> 
> Those are spurious dependencies in a very old version of gdk-pixbuf.
> 
> oe-core master has 2.24.1 at the moment, is there a good reason why
> meta-oe is hanging onto 2.10.14?

This is the OE-Classic 2011.03-maintenance branch. I was surprised too until I 
realised where this was :)

Cheers,
Paul
Ross Burton - Sept. 11, 2012, 1:39 p.m.
On 11 September 2012 14:03, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
>> oe-core master has 2.24.1 at the moment, is there a good reason why
>> meta-oe is hanging onto 2.10.14?
>
> This is the OE-Classic 2011.03-maintenance branch. I was surprised too until I
> realised where this was :)

Oh, wow.  In that case I recommend either patching out those
dependencies instead, or upgrading to a more modern version of
gdk-pixbuf.

Ross
Steffen Sledz - Sept. 12, 2012, 9:44 a.m.
On 11.09.2012 15:39, Burton, Ross wrote:
> On 11 September 2012 14:03, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
>>> oe-core master has 2.24.1 at the moment, is there a good reason why
>>> meta-oe is hanging onto 2.10.14?
>>
>> This is the OE-Classic 2011.03-maintenance branch. I was surprised too until I
>> realised where this was :)
> 
> Oh, wow.  In that case I recommend either patching out those
> dependencies instead, or upgrading to a more modern version of
> gdk-pixbuf.

This is a maintenance branch. Tom normally does not accept upgrade patches if there's no critical problem it fixes.

I just wanted to fix a build problem introduced with Khem's commit.

Steffen
Tom Rini - Sept. 14, 2012, 10:07 p.m.
On Tue, Sep 11, 2012 at 02:42:54PM +0200, Steffen Sledz wrote:

> This fixes an error in do_configure step for target and native build.
> 
> | checking for BASE_DEPENDENCIES... configure: error: Package requirements (glib-2.0 >= 2.12.0    atk >= 1.9.0    pango >= 1.12.0    cairo >= 1.2.0) were not met:
> |
> | No package 'atk' found
> | No package 'pango' found
> | No package 'cairo' found
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>

Applied, thanks!

Patch

diff --git a/recipes/gtk+/gdk-pixbuf_2.10.14.bb b/recipes/gtk+/gdk-pixbuf_2.10.14.bb
index c41a2be..e9493f9 100644
--- a/recipes/gtk+/gdk-pixbuf_2.10.14.bb
+++ b/recipes/gtk+/gdk-pixbuf_2.10.14.bb
@@ -4,7 +4,7 @@  HOMEPAGE = "http://www.gtk.org/"
 SECTION = "libs"
 LICENSE = "LGPL"
 PRIORITY = "optional"
-DEPENDS = "libpng gettext glib-2.0"
+DEPENDS = "libpng gettext glib-2.0 atk pango cairo"
 PR = "r2"
 
 S = "${WORKDIR}/gtk+-${PV}"