| Submitter | Paul Eggleton |
|---|---|
| Date | Sept. 11, 2012, 11 a.m. |
| Message ID | <1347361205-9711-1-git-send-email-paul.eggleton@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/36277/ |
| State | New |
| Headers | show |
Comments
On Tue, 2012-09-11 at 12:00 +0100, Paul Eggleton wrote: > Error messages that use arguments need to be formatted properly, or we > don't get the full message. Use a formatter to do this when an error > occurs. > > Partial fix for [YOCTO #2983]. > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> > --- > bitbake/lib/bb/ui/crumbs/hobeventhandler.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Merged to master, thanks. Richard
Patch
diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py index dac2f74..35cbded 100644 --- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py +++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py @@ -177,7 +177,9 @@ class HobHandler(gobject.GObject): elif isinstance(event, logging.LogRecord): if event.levelno >= logging.ERROR: - self.error_msg += event.msg + '\n' + formatter = bb.msg.BBLogFormatter() + formatter.format(event) + self.error_msg += event.message + '\n' elif isinstance(event, bb.event.TargetsTreeGenerated): self.current_phase = "data generation"
Error messages that use arguments need to be formatted properly, or we don't get the full message. Use a formatter to do this when an error occurs. Partial fix for [YOCTO #2983]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> --- bitbake/lib/bb/ui/crumbs/hobeventhandler.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)