Patchwork matchbox-session: Should have high ALTERNATIE_PRIORITY than mini-x-session

login
register
mail settings
Submitter Saul Wold
Date Sept. 6, 2012, 9:58 p.m.
Message ID <1346968713-16778-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/36077/
State Accepted
Commit d9fde0aaab26cbd657ffa56781754c85eec6f83a
Headers show

Comments

Saul Wold - Sept. 6, 2012, 9:58 p.m.
By having a high priority it will be installed instead of the mini-x-session
when both are in a give set of packagegroups, as it stands now the
mini-x-session is installed by default on sato which is wrong!

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 .../matchbox-session/matchbox-session_0.1.bb       |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Saul Wold - Sept. 6, 2012, 10:03 p.m.
On 09/06/2012 02:58 PM, Saul Wold wrote:
> By having a high priority it will be installed instead of the mini-x-session
> when both are in a give set of packagegroups, as it stands now the
> mini-x-session is installed by default on sato which is wrong!
>
This issue occurred because during the packagegroup reorganization, the 
mini-x-session was added to core-x11-base

The mini-x-session is really targeted for the build appliance and maybe 
it's name caused some confusion.  I would suggest we might want to 
create a different x-session file for core-x11-base and/or rename the 
mini-x-session, since it's not appropriate.


> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>   .../matchbox-session/matchbox-session_0.1.bb       |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb b/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb
> index f4be279..b9e83a5 100644
> --- a/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb
> +++ b/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb
> @@ -11,13 +11,13 @@ RCONFLICTS_${PN} = "matchbox-common"
>   SRC_URI = "file://matchbox-session"
>   S = "${WORKDIR}"
>
> -PR = "r3"
> +PR = "r4"
>
>   inherit update-alternatives
>
>   ALTERNATIVE_${PN} = "x-session-manager"
>   ALTERNATIVE_TARGET[x-session-manager] = "${bindir}/matchbox-session"
> -ALTERNATIVE_PRIORITY = "10"
> +ALTERNATIVE_PRIORITY = "100"
>
>   do_install() {
>   	install -d ${D}/${bindir}
>

Patch

diff --git a/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb b/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb
index f4be279..b9e83a5 100644
--- a/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb
+++ b/meta/recipes-graphics/matchbox-session/matchbox-session_0.1.bb
@@ -11,13 +11,13 @@  RCONFLICTS_${PN} = "matchbox-common"
 SRC_URI = "file://matchbox-session"
 S = "${WORKDIR}"
 
-PR = "r3"
+PR = "r4"
 
 inherit update-alternatives
 
 ALTERNATIVE_${PN} = "x-session-manager"
 ALTERNATIVE_TARGET[x-session-manager] = "${bindir}/matchbox-session"
-ALTERNATIVE_PRIORITY = "10"
+ALTERNATIVE_PRIORITY = "100"
 
 do_install() {
 	install -d ${D}/${bindir}