| Submitter | Ross Burton |
|---|---|
| Date | Sept. 6, 2012, 3:29 p.m. |
| Message ID | <1346945375-5770-1-git-send-email-ross.burton@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/36061/ |
| State | Accepted |
| Commit | eef5cca4f364545759d8cf624f38e3cd6e8fd295 |
| Headers | show |
Comments
On 09/06/2012 08:29 AM, Ross Burton wrote: > The examples pull in a GTK+ build dependency, so remove that too. > > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb > index ac63f94..0fc34df 100644 > --- a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb > +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb > @@ -5,14 +5,14 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \ > file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=622921ffad8cb18ab906c56052788a3f \ > file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe" > > -DEPENDS += "gst-plugins-base gconf cairo jpeg libpng gtk+ zlib libid3tag flac \ > +DEPENDS += "gst-plugins-base gconf cairo jpeg libpng zlib libid3tag flac \ > speex libsoup-2.4 pulseaudio" You seem to be changing DEPENDS here also with no reason why. Sau! > -PR = "r2" > +PR = "r3" > > inherit gettext gconf > > EXTRA_OECONF += "--disable-aalib --disable-esd --disable-shout2 --disable-libcaca --disable-hal --without-check \ > - --disable-orc" > + --disable-orc --disable-examples" > > do_configure_prepend() { > # This m4 file contains nastiness which conflicts with libtool 2.2.2 >
Hi Saul,
On 6 September 2012 19:56, Saul Wold <sgw@linux.intel.com> wrote:
>You seem to be changing DEPENDS here also with no reason why.
From the commit log:
"The examples pull in a GTK+ build dependency, so remove that too."
Ross
On 09/06/2012 08:29 AM, Ross Burton wrote: > The examples pull in a GTK+ build dependency, so remove that too. > > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb > index ac63f94..0fc34df 100644 > --- a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb > +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb > @@ -5,14 +5,14 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \ > file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=622921ffad8cb18ab906c56052788a3f \ > file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe" > > -DEPENDS += "gst-plugins-base gconf cairo jpeg libpng gtk+ zlib libid3tag flac \ > +DEPENDS += "gst-plugins-base gconf cairo jpeg libpng zlib libid3tag flac \ > speex libsoup-2.4 pulseaudio" > -PR = "r2" > +PR = "r3" > > inherit gettext gconf > > EXTRA_OECONF += "--disable-aalib --disable-esd --disable-shout2 --disable-libcaca --disable-hal --without-check \ > - --disable-orc" > + --disable-orc --disable-examples" > > do_configure_prepend() { > # This m4 file contains nastiness which conflicts with libtool 2.2.2 > Merged into OE-Core Thanks Sau!
Patch
diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb index ac63f94..0fc34df 100644 --- a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb @@ -5,14 +5,14 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \ file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=622921ffad8cb18ab906c56052788a3f \ file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe" -DEPENDS += "gst-plugins-base gconf cairo jpeg libpng gtk+ zlib libid3tag flac \ +DEPENDS += "gst-plugins-base gconf cairo jpeg libpng zlib libid3tag flac \ speex libsoup-2.4 pulseaudio" -PR = "r2" +PR = "r3" inherit gettext gconf EXTRA_OECONF += "--disable-aalib --disable-esd --disable-shout2 --disable-libcaca --disable-hal --without-check \ - --disable-orc" + --disable-orc --disable-examples" do_configure_prepend() { # This m4 file contains nastiness which conflicts with libtool 2.2.2
The examples pull in a GTK+ build dependency, so remove that too. Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)