Patchwork [PATCHv4,2/3] liblockdev: new recipe, new version of libcec requires it

login
register
mail settings
Submitter ml@communistcode.co.uk
Date Sept. 5, 2012, 3:21 p.m.
Message ID <1346858494-4849-2-git-send-email-ml@communistcode.co.uk>
Download mbox | patch
Permalink /patch/35963/
State Superseded
Headers show

Comments

ml@communistcode.co.uk - Sept. 5, 2012, 3:21 p.m.
From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>

V4

- Remove debian packaging patch, it is not needed

Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
 .../liblockdev/liblockdev_1.0.3.bb                 | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
Andrei Gherzan - Sept. 5, 2012, 3:41 p.m.
On Wed, Sep 5, 2012 at 6:21 PM, <ml@communistcode.co.uk> wrote:

> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>
> V4
>
> - Remove debian packaging patch, it is not needed
>
>
What means it is not needed anymore? Included in upstream? Fixed in yocto?


> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>  .../liblockdev/liblockdev_1.0.3.bb                 | 26
> ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/liblockdev/
> liblockdev_1.0.3.bb
>
>
Where is the removed patch?


> diff --git a/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bbb/meta-oe/recipes-extended/liblockdev/
> liblockdev_1.0.3.bb
> new file mode 100644
> index 0000000..be5ce44
> --- /dev/null
> +++ b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
> @@ -0,0 +1,26 @@
> +DESCRIPTION = "Manage character and block device lockfiles."
> +HOMEPAGE = "
> http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary"
> +
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=d8045f3b8f929c1cb29a1e3fd737b499"
> +
> +PV = "1.0.3"
> +
> +SRC_URI = "
> http://ftp.de.debian.org/debian/pool/main/l/lockdev/lockdev_${PV}.orig.tar.gz
> "
> +
> +SRC_URI[md5sum] = "64b9c1b87b125fc348e892e24625524a"
> +SRC_URI[sha256sum] =
> "ccae635d7ac3fdd50897eceb250872b3d9a191d298f213e7f0c836910d869f82"
> +
> +S = "${WORKDIR}/lockdev-${PV}"
> +
> +do_compile() {
> +  oe_runmake CC="${CC}" LD="${LD}" shared
> +}
> +
> +do_install() {
> +  oe_runmake basedir="${D}" incdir="${D}${includedir}"
> libdir="${D}${libdir}" install_dev
> +}
> +
> +FILES_{PN} = "${includedir}/* \
> +              ${libdir}/* \
> +"
> --
> 1.7.12
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
ml@communistcode.co.uk - Sept. 5, 2012, 3:49 p.m.
On 05/09/12 16:41, Andrei Gherzan wrote:
> On Wed, Sep 5, 2012 at 6:21 PM, <ml@communistcode.co.uk> wrote:
>
>> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>>
>> V4
>>
>> - Remove debian packaging patch, it is not needed
>>
>>
> What means it is not needed anymore? Included in upstream? Fixed in yocto?
>
>
>> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>> ---
>>   .../liblockdev/liblockdev_1.0.3.bb                 | 26
>> ++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>   create mode 100644 meta-oe/recipes-extended/liblockdev/
>> liblockdev_1.0.3.bb
>>
>>
> Where is the removed patch?
>
>
>> diff --git a/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bbb/meta-oe/recipes-extended/liblockdev/
>> liblockdev_1.0.3.bb
>> new file mode 100644
>> index 0000000..be5ce44
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
>> @@ -0,0 +1,26 @@
>> +DESCRIPTION = "Manage character and block device lockfiles."
>> +HOMEPAGE = "
>> http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary"
>> +
>> +LICENSE = "LGPLv2.1"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=d8045f3b8f929c1cb29a1e3fd737b499"
>> +
>> +PV = "1.0.3"
>> +
>> +SRC_URI = "
>> http://ftp.de.debian.org/debian/pool/main/l/lockdev/lockdev_${PV}.orig.tar.gz
>> "
>> +
>> +SRC_URI[md5sum] = "64b9c1b87b125fc348e892e24625524a"
>> +SRC_URI[sha256sum] =
>> "ccae635d7ac3fdd50897eceb250872b3d9a191d298f213e7f0c836910d869f82"
>> +
>> +S = "${WORKDIR}/lockdev-${PV}"
>> +
>> +do_compile() {
>> +  oe_runmake CC="${CC}" LD="${LD}" shared
>> +}
>> +
>> +do_install() {
>> +  oe_runmake basedir="${D}" incdir="${D}${includedir}"
>> libdir="${D}${libdir}" install_dev
>> +}
>> +
>> +FILES_{PN} = "${includedir}/* \
>> +              ${libdir}/* \
>> +"
>> --
>> 1.7.12
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Sorry, this has been confusing!

I had erroneously added a patch in my V1 git send-patch for building 
liblockdev which wasn't required so I removed it and rebased my patches 
without it.
Andrei Gherzan - Sept. 5, 2012, 3:50 p.m.
On Wed, Sep 5, 2012 at 6:49 PM, Jack Mitchell <ml@communistcode.co.uk>wrote:

> On 05/09/12 16:41, Andrei Gherzan wrote:
>
>> On Wed, Sep 5, 2012 at 6:21 PM, <ml@communistcode.co.uk> wrote:
>>
>>  From: Jack Mitchell <jack.mitchell@dbbroadcast.co.**uk<jack.mitchell@dbbroadcast.co.uk>
>>> >
>>>
>>> V4
>>>
>>> - Remove debian packaging patch, it is not needed
>>>
>>>
>>>  What means it is not needed anymore? Included in upstream? Fixed in
>> yocto?
>>
>>
>>  Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.**uk<jack.mitchell@dbbroadcast.co.uk>
>>> >
>>> ---
>>>   .../liblockdev/liblockdev_1.0.**3.bb <http://liblockdev_1.0.3.bb>
>>>             | 26
>>> ++++++++++++++++++++++
>>>   1 file changed, 26 insertions(+)
>>>   create mode 100644 meta-oe/recipes-extended/**liblockdev/
>>> liblockdev_1.0.3.bb
>>>
>>>
>>>  Where is the removed patch?
>>
>>
>>  diff --git a/meta-oe/recipes-extended/**liblockdev/liblockdev_1.0.3.**
>>> bbb/meta-oe/recipes-extended/**liblockdev/
>>> liblockdev_1.0.3.bb
>>> new file mode 100644
>>> index 0000000..be5ce44
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-extended/**liblockdev/liblockdev_1.0.3.bb
>>> @@ -0,0 +1,26 @@
>>> +DESCRIPTION = "Manage character and block device lockfiles."
>>> +HOMEPAGE = "
>>> http://anonscm.debian.org/**gitweb/?p=lockdev/lockdev.git;**a=summary<http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary>
>>> "
>>> +
>>> +LICENSE = "LGPLv2.1"
>>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=**d8045f3b8f929c1cb29a1e3fd737b4
>>> **99"
>>> +
>>> +PV = "1.0.3"
>>> +
>>> +SRC_URI = "
>>> http://ftp.de.debian.org/**debian/pool/main/l/lockdev/**
>>> lockdev_${PV}.orig.tar.gz<http://ftp.de.debian.org/debian/pool/main/l/lockdev/lockdev_$%7BPV%7D.orig.tar.gz>
>>> "
>>> +
>>> +SRC_URI[md5sum] = "**64b9c1b87b125fc348e892e2462552**4a"
>>> +SRC_URI[sha256sum] =
>>> "**ccae635d7ac3fdd50897eceb250872**b3d9a191d298f213e7f0c836910d86**9f82"
>>> +
>>> +S = "${WORKDIR}/lockdev-${PV}"
>>> +
>>> +do_compile() {
>>> +  oe_runmake CC="${CC}" LD="${LD}" shared
>>> +}
>>> +
>>> +do_install() {
>>> +  oe_runmake basedir="${D}" incdir="${D}${includedir}"
>>> libdir="${D}${libdir}" install_dev
>>> +}
>>> +
>>> +FILES_{PN} = "${includedir}/* \
>>> +              ${libdir}/* \
>>> +"
>>> --
>>> 1.7.12
>>>
>>>
>>> ______________________________**_________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.**openembedded.org<Openembedded-devel@lists.openembedded.org>
>>> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**
>>> openembedded-devel<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel>
>>>
>>>  ______________________________**_________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.**openembedded.org<Openembedded-devel@lists.openembedded.org>
>> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**
>> openembedded-devel<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel>
>>
>
> Sorry, this has been confusing!
>
> I had erroneously added a patch in my V1 git send-patch for building
> liblockdev which wasn't required so I removed it and rebased my patches
> without it.
>
>
Got it now.
Koen Kooi - Sept. 6, 2012, 11:16 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 05-09-12 17:21, ml@communistcode.co.uk schreef:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> 
> V4
> 
> - Remove debian packaging patch, it is not needed
> 
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk> --- 
> .../liblockdev/liblockdev_1.0.3.bb                 | 26
> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode
> 100644 meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
> 
> diff --git a/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
> b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb new file mode
> 100644 index 0000000..be5ce44 --- /dev/null +++
> b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb @@ -0,0 +1,26
> @@ +DESCRIPTION = "Manage character and block device lockfiles." 
> +HOMEPAGE =
> "http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary" + 
> +LICENSE = "LGPLv2.1" +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=d8045f3b8f929c1cb29a1e3fd737b499" + +PV = "1.0.3"

That's superfluous


> +FILES_{PN} = "${includedir}/* \ +              ${libdir}/* \ +"

This concerns me, what is going wrong in the regular FILES_${PN} situation?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQSIYUMkyGM64RGpERAq3vAJ9JrlmJY5WRA4sKpp1xs+m5jcQCdwCfSgmr
u+zcjBy1Y1NbD+muNrVgCts=
=11Ia
-----END PGP SIGNATURE-----
ml@communistcode.co.uk - Sept. 6, 2012, 11:22 a.m.
On 06/09/12 12:16, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 05-09-12 17:21, ml@communistcode.co.uk schreef:
>> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>>
>> V4
>>
>> - Remove debian packaging patch, it is not needed
>>
>> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk> ---
>> .../liblockdev/liblockdev_1.0.3.bb                 | 26
>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode
>> 100644 meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
>>
>> diff --git a/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
>> b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb new file mode
>> 100644 index 0000000..be5ce44 --- /dev/null +++
>> b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb @@ -0,0 +1,26
>> @@ +DESCRIPTION = "Manage character and block device lockfiles."
>> +HOMEPAGE =
>> "http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary" +
>> +LICENSE = "LGPLv2.1" +LIC_FILES_CHKSUM =
>> "file://LICENSE;md5=d8045f3b8f929c1cb29a1e3fd737b499" + +PV = "1.0.3"
> That's superfluous
>
>
>> +FILES_{PN} = "${includedir}/* \ +              ${libdir}/* \ +"
> This concerns me, what is going wrong in the regular FILES_${PN} situation?
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFQSIYUMkyGM64RGpERAq3vAJ9JrlmJY5WRA4sKpp1xs+m5jcQCdwCfSgmr
> u+zcjBy1Y1NbD+muNrVgCts=
> =11Ia
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

If I remember correctly it wasn't picking up the include files, however 
that may have been before I added the incdir="${D}${includedir}" to 
oe_runmake. Let me check it out.

Patch

diff --git a/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
new file mode 100644
index 0000000..be5ce44
--- /dev/null
+++ b/meta-oe/recipes-extended/liblockdev/liblockdev_1.0.3.bb
@@ -0,0 +1,26 @@ 
+DESCRIPTION = "Manage character and block device lockfiles."
+HOMEPAGE = "http://anonscm.debian.org/gitweb/?p=lockdev/lockdev.git;a=summary"
+
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=d8045f3b8f929c1cb29a1e3fd737b499"
+
+PV = "1.0.3"
+
+SRC_URI = "http://ftp.de.debian.org/debian/pool/main/l/lockdev/lockdev_${PV}.orig.tar.gz"
+
+SRC_URI[md5sum] = "64b9c1b87b125fc348e892e24625524a"
+SRC_URI[sha256sum] = "ccae635d7ac3fdd50897eceb250872b3d9a191d298f213e7f0c836910d869f82"
+
+S = "${WORKDIR}/lockdev-${PV}"
+
+do_compile() {
+  oe_runmake CC="${CC}" LD="${LD}" shared
+}
+
+do_install() {
+  oe_runmake basedir="${D}" incdir="${D}${includedir}" libdir="${D}${libdir}" install_dev
+}
+
+FILES_{PN} = "${includedir}/* \
+              ${libdir}/* \
+"