diff mbox series

[meta-oe,PATCHv4] xsetroot: upgrade 1.1.2 -> 1.1.3

Message ID 20231208125633.336439-1-alperyasinak1@gmail.com
State Accepted
Headers show
Series [meta-oe,PATCHv4] xsetroot: upgrade 1.1.2 -> 1.1.3 | expand

Commit Message

Alper Ak Dec. 8, 2023, 12:56 p.m. UTC
By default, xsetroot depends on libxmu and xbitmaps

xsetroot dependencies -> https://gitlab.freedesktop.org/xorg/app/xsetroot/-/blob/master/configure.ac?ref_type=heads#L41

xbitmaps has no dependency on libxmu but it was added as a dependency in version 1.1.2. When upgrading xbitmaps to version 1.1.3, libxmu removed from the dependencies
Since xsetroot depends on xbitmaps, and libxmu was removed from xbitmaps dependencies, encountered missing libxmu dependencies error.

xbitmaps dependencies -> https://gitlab.freedesktop.org/xorg/data/bitmaps/-/blob/master/configure.ac?ref_type=heads
xbitmaps upgrade 1.1.2 to 1.1.3 -> https://github.com/openembedded/meta-openembedded/commit/5430b16813c87dc5d69a2ae21bc6d5f2b73cd8d5

So, added libxmu as a dependency to xsetroot for fixing build issue.

Changelog:

* gitlab CI: stop requiring Signed-off-by in commits
* Handle -Wsign-compare warnings
* Variable scope reductions as recommended by cppcheck
* Build xz tarballs instead of bzip2
* CI: add a basic build test
* Update configure.ac bug URL for gitlab migration
* Update README for gitlab migration

Signed-off-by: alperak <alperyasinak1@gmail.com>
---
 .../xorg-app/{xsetroot_1.1.2.bb => xsetroot_1.1.3.bb}       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename meta-oe/recipes-graphics/xorg-app/{xsetroot_1.1.2.bb => xsetroot_1.1.3.bb} (66%)

Comments

Khem Raj Dec. 13, 2023, 7:07 a.m. UTC | #1
On Fri, 08 Dec 2023 15:56:33 +0300, alperak wrote:
> By default, xsetroot depends on libxmu and xbitmaps
> 
> xsetroot dependencies -> https://gitlab.freedesktop.org/xorg/app/xsetroot/-/blob/master/configure.ac?ref_type=heads#L41
> 
> xbitmaps has no dependency on libxmu but it was added as a dependency in version 1.1.2. When upgrading xbitmaps to version 1.1.3, libxmu removed from the dependencies
> Since xsetroot depends on xbitmaps, and libxmu was removed from xbitmaps dependencies, encountered missing libxmu dependencies error.
> 
> [...]

Applied, thanks!

[1/1] xsetroot: upgrade 1.1.2 -> 1.1.3
      commit: 1a84a1ebbe197552077b4610c6fdcd459532113e

Best regards,
diff mbox series

Patch

diff --git a/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.2.bb b/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.3.bb
similarity index 66%
rename from meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.2.bb
rename to meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.3.bb
index a9a8acf05..7e909f90c 100644
--- a/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.2.bb
+++ b/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.3.bb
@@ -7,7 +7,7 @@  SECTION = "x11/app"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=6ea29dbee22324787c061f039e0529de"
 
-DEPENDS += "xbitmaps libxcursor"
+DEPENDS += "xbitmaps libxcursor libxmu"
 
-SRC_URI[md5sum] = "5fe769c8777a6e873ed1305e4ce2c353"
-SRC_URI[sha256sum] = "10c442ba23591fb5470cea477a0aa5f679371f4f879c8387a1d9d05637ae417c"
+SRC_URI_EXT = "xz"
+SRC_URI[sha256sum] = "6081b45a9eb4426e045d259d1e144b32417fb635e5b96aa90647365ac96638d1"