Patchwork [3/3] libcec: update libcec to latest version (1.8.2) as to include RasPi support

login
register
mail settings
Submitter ml@communistcode.co.uk
Date Sept. 5, 2012, 2:02 p.m.
Message ID <1346853750-503-3-git-send-email-ml@communistcode.co.uk>
Download mbox | patch
Permalink /patch/35939/
State Superseded
Headers show

Comments

ml@communistcode.co.uk - Sept. 5, 2012, 2:02 p.m.
From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>

- Now depends on liblockdev
- Slight licence change - new md5sum

Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
 meta-oe/recipes-extended/libcec/libcec_git.bb | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Paul Eggleton - Sept. 5, 2012, 2:16 p.m.
On Wednesday 05 September 2012 15:02:30 ml@communistcode.co.uk wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> 
> - Now depends on liblockdev
> - Slight licence change - new md5sum
> 
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>  meta-oe/recipes-extended/libcec/libcec_git.bb | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta-oe/recipes-extended/libcec/libcec_git.bb
> b/meta-oe/recipes-extended/libcec/libcec_git.bb index 142b2e2..f3cb39e
> 100644
> --- a/meta-oe/recipes-extended/libcec/libcec_git.bb
> +++ b/meta-oe/recipes-extended/libcec/libcec_git.bb
> @@ -1,14 +1,14 @@
>  DESCRIPTION = "USB CEC Adaptor communication Library"
>  HOMEPAGE = "http://libcec.pulse-eight.com/"
> 
> -LICENSE = "GPLv2+"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=185ead350fec5fc223da0f65f9a802af"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=5e8e16396992369f73f3d28875f846da"
> 
> -DEPENDS = "udev"
> +DEPENDS = "udev liblockdev"
> 
>  PR = "r1"
> -PV = "1.4.0"
> -SRCREV = "2db8981f49fbd167ddbbf19c1fbadd064abc332a"
> +PV = "1.8.2"
> +SRCREV = "34a9cecdd92f6b2844f9c4054da202b152ab2217"
>  SRC_URI = "git://github.com/Pulse-Eight/libcec.git"
> 
>  S = "${WORKDIR}/git"

It's not totally clear but it doesn't look like 1.8.2 has been released yet 
judging from their website; if that's the case then PV should be set to 
"1.8.1+git${SRCPV}".

Cheers,
Paul
Martin Jansa - Sept. 5, 2012, 7:28 p.m.
On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
> On Wednesday 05 September 2012 15:02:30 ml@communistcode.co.uk wrote:
> > From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> > 
> > - Now depends on liblockdev
> > - Slight licence change - new md5sum
> > 
> > Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> > ---
> >  meta-oe/recipes-extended/libcec/libcec_git.bb | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/meta-oe/recipes-extended/libcec/libcec_git.bb
> > b/meta-oe/recipes-extended/libcec/libcec_git.bb index 142b2e2..f3cb39e
> > 100644
> > --- a/meta-oe/recipes-extended/libcec/libcec_git.bb
> > +++ b/meta-oe/recipes-extended/libcec/libcec_git.bb
> > @@ -1,14 +1,14 @@
> >  DESCRIPTION = "USB CEC Adaptor communication Library"
> >  HOMEPAGE = "http://libcec.pulse-eight.com/"
> > 
> > -LICENSE = "GPLv2+"
> > -LIC_FILES_CHKSUM = "file://COPYING;md5=185ead350fec5fc223da0f65f9a802af"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=5e8e16396992369f73f3d28875f846da"
> > 
> > -DEPENDS = "udev"
> > +DEPENDS = "udev liblockdev"
> > 
> >  PR = "r1"
> > -PV = "1.4.0"
> > -SRCREV = "2db8981f49fbd167ddbbf19c1fbadd064abc332a"
> > +PV = "1.8.2"
> > +SRCREV = "34a9cecdd92f6b2844f9c4054da202b152ab2217"
> >  SRC_URI = "git://github.com/Pulse-Eight/libcec.git"
> > 
> >  S = "${WORKDIR}/git"
> 
> It's not totally clear but it doesn't look like 1.8.2 has been released yet 
> judging from their website; if that's the case then PV should be set to 
> "1.8.1+git${SRCPV}".

Or rather
"1.8.1+gitr${SRCPV}"
like most meta-* recipes

Cheers,
Paul Eggleton - Sept. 5, 2012, 9:32 p.m.
On Wednesday 05 September 2012 21:28:18 Martin Jansa wrote:
> On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
> > It's not totally clear but it doesn't look like 1.8.2 has been released
> > yet judging from their website; if that's the case then PV should be set
> > to "1.8.1+git${SRCPV}".
> 
> Or rather
> "1.8.1+gitr${SRCPV}"
> like most meta-* recipes

This was discussed not that long ago IIRC - the r is superfluous for git. In 
fact if you look at most OE-Core recipes that use SRCPV they do not precede it 
with r.

Cheers,
Paul
ml@communistcode.co.uk - Sept. 6, 2012, 8:12 a.m.
On 05/09/12 22:32, Paul Eggleton wrote:
> On Wednesday 05 September 2012 21:28:18 Martin Jansa wrote:
>> On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
>>> It's not totally clear but it doesn't look like 1.8.2 has been released
>>> yet judging from their website; if that's the case then PV should be set
>>> to "1.8.1+git${SRCPV}".
>> Or rather
>> "1.8.1+gitr${SRCPV}"
>> like most meta-* recipes
> This was discussed not that long ago IIRC - the r is superfluous for git. In
> fact if you look at most OE-Core recipes that use SRCPV they do not precede it
> with r.
>
> Cheers,
> Paul
>

So even though it is the 1.8.1 release commit it should still be tagged 
with the git SRCPV?
Paul Eggleton - Sept. 6, 2012, 8:30 a.m.
On Thursday 06 September 2012 09:12:52 Jack Mitchell wrote:
> On 05/09/12 22:32, Paul Eggleton wrote:
> > On Wednesday 05 September 2012 21:28:18 Martin Jansa wrote:
> >> On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
> >>> It's not totally clear but it doesn't look like 1.8.2 has been released
> >>> yet judging from their website; if that's the case then PV should be set
> >>> to "1.8.1+git${SRCPV}".
> >> 
> >> Or rather
> >> "1.8.1+gitr${SRCPV}"
> >> like most meta-* recipes
> > 
> > This was discussed not that long ago IIRC - the r is superfluous for git.
> > In fact if you look at most OE-Core recipes that use SRCPV they do not
> > precede it with r.
> > 
> > Cheers,
> > Paul
> 
> So even though it is the 1.8.1 release commit it should still be tagged
> with the git SRCPV?

Well, I don't personally think so - if it really is 1.8.1 (and it's pointing 
at the same revision as the "1.8.1" tag, so it ought to be) then I don't think 
it should be needed.

Cheers,
Paul
Andrei Gherzan - Sept. 6, 2012, 8:37 a.m.
On Thu, Sep 6, 2012 at 11:12 AM, Jack Mitchell <ml@communistcode.co.uk>wrote:

> On 05/09/12 22:32, Paul Eggleton wrote:
>
>> On Wednesday 05 September 2012 21:28:18 Martin Jansa wrote:
>>
>>> On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
>>>
>>>> It's not totally clear but it doesn't look like 1.8.2 has been released
>>>> yet judging from their website; if that's the case then PV should be set
>>>> to "1.8.1+git${SRCPV}".
>>>>
>>> Or rather
>>> "1.8.1+gitr${SRCPV}"
>>> like most meta-* recipes
>>>
>> This was discussed not that long ago IIRC - the r is superfluous for git.
>> In
>> fact if you look at most OE-Core recipes that use SRCPV they do not
>> precede it
>> with r.
>>
>> Cheers,
>> Paul
>>
>>
> So even though it is the 1.8.1 release commit it should still be tagged
> with the git SRCPV?
>
>
No. The SRCPV should be there to indicate that your version is something in
between 2 official versions. In your case as there is not
1.8.2 officially you state that this package is 1.8.1 but at a
later SRCPV commit.

You need v1.8.2? There is no rpi support in 1.8.1? Why don't you update to
that version?

Andrei
ml@communistcode.co.uk - Sept. 6, 2012, 8:47 a.m.
On 06/09/12 09:37, Andrei Gherzan wrote:
> On Thu, Sep 6, 2012 at 11:12 AM, Jack Mitchell <ml@communistcode.co.uk>wrote:
>
>> On 05/09/12 22:32, Paul Eggleton wrote:
>>
>>> On Wednesday 05 September 2012 21:28:18 Martin Jansa wrote:
>>>
>>>> On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
>>>>
>>>>> It's not totally clear but it doesn't look like 1.8.2 has been released
>>>>> yet judging from their website; if that's the case then PV should be set
>>>>> to "1.8.1+git${SRCPV}".
>>>>>
>>>> Or rather
>>>> "1.8.1+gitr${SRCPV}"
>>>> like most meta-* recipes
>>>>
>>> This was discussed not that long ago IIRC - the r is superfluous for git.
>>> In
>>> fact if you look at most OE-Core recipes that use SRCPV they do not
>>> precede it
>>> with r.
>>>
>>> Cheers,
>>> Paul
>>>
>>>
>> So even though it is the 1.8.1 release commit it should still be tagged
>> with the git SRCPV?
>>
>>
> No. The SRCPV should be there to indicate that your version is something in
> between 2 official versions. In your case as there is not
> 1.8.2 officially you state that this package is 1.8.1 but at a
> later SRCPV commit.
>
> You need v1.8.2? There is no rpi support in 1.8.1? Why don't you update to
> that version?
>
> Andrei

There is RPi support merged in 1.8.1 - I had read the changelog to get 
the version number and they had listed 1.8.2 in it which lead me to 
believe it was already at 1.8.2 but it was just a 'work in progress' 1.8.2.

The current commit is the 1.8.1 tag and has the features I need so I 
don't need to put in a 1.8.1+wip.

Regards,
ml@communistcode.co.uk - Sept. 6, 2012, 8:48 a.m.
On 06/09/12 09:30, Paul Eggleton wrote:
> On Thursday 06 September 2012 09:12:52 Jack Mitchell wrote:
>> On 05/09/12 22:32, Paul Eggleton wrote:
>>> On Wednesday 05 September 2012 21:28:18 Martin Jansa wrote:
>>>> On Wed, Sep 05, 2012 at 03:16:10PM +0100, Paul Eggleton wrote:
>>>>> It's not totally clear but it doesn't look like 1.8.2 has been released
>>>>> yet judging from their website; if that's the case then PV should be set
>>>>> to "1.8.1+git${SRCPV}".
>>>> Or rather
>>>> "1.8.1+gitr${SRCPV}"
>>>> like most meta-* recipes
>>> This was discussed not that long ago IIRC - the r is superfluous for git.
>>> In fact if you look at most OE-Core recipes that use SRCPV they do not
>>> precede it with r.
>>>
>>> Cheers,
>>> Paul
>> So even though it is the 1.8.1 release commit it should still be tagged
>> with the git SRCPV?
> Well, I don't personally think so - if it really is 1.8.1 (and it's pointing
> at the same revision as the "1.8.1" tag, so it ought to be) then I don't think
> it should be needed.
>
> Cheers,
> Paul
>

Ok, that is how I envisioned it - thanks for clearing it up.

Patch

diff --git a/meta-oe/recipes-extended/libcec/libcec_git.bb b/meta-oe/recipes-extended/libcec/libcec_git.bb
index 142b2e2..f3cb39e 100644
--- a/meta-oe/recipes-extended/libcec/libcec_git.bb
+++ b/meta-oe/recipes-extended/libcec/libcec_git.bb
@@ -1,14 +1,14 @@ 
 DESCRIPTION = "USB CEC Adaptor communication Library"
 HOMEPAGE = "http://libcec.pulse-eight.com/"
 
-LICENSE = "GPLv2+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=185ead350fec5fc223da0f65f9a802af"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=5e8e16396992369f73f3d28875f846da"
 
-DEPENDS = "udev"
+DEPENDS = "udev liblockdev"
 
 PR = "r1"
-PV = "1.4.0"
-SRCREV = "2db8981f49fbd167ddbbf19c1fbadd064abc332a"
+PV = "1.8.2"
+SRCREV = "34a9cecdd92f6b2844f9c4054da202b152ab2217"
 SRC_URI = "git://github.com/Pulse-Eight/libcec.git"
 
 S = "${WORKDIR}/git"