Patchwork [bitbake-devel] hob/imagedetailspage: "Image ready" icon appers only after the image was generated

login
register
mail settings
Submitter Cristiana Voicu
Date Sept. 3, 2012, 11:22 a.m.
Message ID <1346671324-4295-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/35711/
State New
Headers show

Comments

Cristiana Voicu - Sept. 3, 2012, 11:22 a.m.
Now, "Your image is ready" icon doesn't appear when you come back on Imagedetails
page. It appears only after the image was generated.

[YOCTO #2984]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - Sept. 7, 2012, 11:03 a.m.
On Mon, 2012-09-03 at 14:22 +0300, Cristiana Voicu wrote:
> Now, "Your image is ready" icon doesn't appear when you come back on Imagedetails
> page. It appears only after the image was generated.
> 
> [YOCTO #2984]
> 
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/imagedetailspage.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
index 40eb7a4..ea26ba3 100755
--- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
+++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
@@ -183,7 +183,7 @@  class ImageDetailsPage (HobPage):
         self.pack_start(self.group_align, expand=True, fill=True)
 
         self.build_result = None
-        if self.build_succeeded:
+        if self.build_succeeded and self.builder.current_step == self.builder.IMAGE_GENERATING:
             # building is the previous step
             icon = gtk.Image()
             pixmap_path = hic.ICON_INDI_CONFIRM_FILE