Patchwork [PATCHv3] sysstat: Explicitly disable sensors support.

login
register
mail settings
Submitter Marc Ferland
Date Aug. 30, 2012, 3:22 p.m.
Message ID <1346340161-2649-1-git-send-email-ferlandm@sonatest.com>
Download mbox | patch
Permalink /patch/35549/
State New
Headers show

Comments

Marc Ferland - Aug. 30, 2012, 3:22 p.m.
Since no lmsensors recipe exists by default in oe-core, explicitly disable
support for it in sysstat. In my case sysstat would fail linking complaining
about undefined references when adding my own lmsensors recipe.

Signed-off-by: Marc Ferland <ferlandm@sonatest.com>
---
 meta/recipes-extended/sysstat/sysstat.inc       |    2 ++
 meta/recipes-extended/sysstat/sysstat_10.0.3.bb |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
Saul Wold - Aug. 30, 2012, 5:02 p.m.
On 08/30/2012 08:22 AM, Marc Ferland wrote:
> Since no lmsensors recipe exists by default in oe-core, explicitly disable
> support for it in sysstat. In my case sysstat would fail linking complaining
> about undefined references when adding my own lmsensors recipe.
>
> Signed-off-by: Marc Ferland <ferlandm@sonatest.com>
> ---
>   meta/recipes-extended/sysstat/sysstat.inc       |    2 ++
>   meta/recipes-extended/sysstat/sysstat_10.0.3.bb |    2 +-
>   2 files changed, 3 insertions(+), 1 deletions(-)
>
You seem to be a little behind the master branch as it's on sysstat_10.0.5

Please rebase your patch to master.

Thanks
	Sau!

> diff --git a/meta/recipes-extended/sysstat/sysstat.inc b/meta/recipes-extended/sysstat/sysstat.inc
> index 9da40a7..287bb54 100644
> --- a/meta/recipes-extended/sysstat/sysstat.inc
> +++ b/meta/recipes-extended/sysstat/sysstat.inc
> @@ -3,12 +3,14 @@ DESCRIPTION = "The sysstat utilities are a collection of performance monitoring
>   HOMEPAGE = "http://sebastien.godard.pagesperso-orange.fr/"
>   LICENSE = "GPLv2+"
>   SECTION = "console/utils"
> +INC_PR = "r1"
>
>   SRC_URI = "http://pagesperso-orange.fr/sebastien.godard/sysstat-${PV}.tar.gz \
>   		   file://99_sysstat"
>
>   inherit autotools gettext
>
> +EXTRA_OECONF += "--disable-sensors"
>   EXTRA_OEMAKE += 'LFLAGS=""'
>
>   do_install() {
> diff --git a/meta/recipes-extended/sysstat/sysstat_10.0.3.bb b/meta/recipes-extended/sysstat/sysstat_10.0.3.bb
> index 7ef6c60..e9b95d8 100644
> --- a/meta/recipes-extended/sysstat/sysstat_10.0.3.bb
> +++ b/meta/recipes-extended/sysstat/sysstat_10.0.3.bb
> @@ -2,7 +2,7 @@ require sysstat.inc
>
>   LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
>
> -PR = "r1"
> +PR = "${INC_PR}.1"
>
>   SRC_URI[md5sum] = "0e1ed5200f31f69a3b90ff1e81c07745"
>   SRC_URI[sha256sum] = "7c0dd172f09edaff100b33db29ef502e15e71867b505c6d519f76a24fabcc1f5"
>
Marc Ferland - Aug. 30, 2012, 5:31 p.m.
Saul Wold <sgw@linux.intel.com> writes:

> On 08/30/2012 08:22 AM, Marc Ferland wrote:
>> Since no lmsensors recipe exists by default in oe-core, explicitly disable
>> support for it in sysstat. In my case sysstat would fail linking complaining
>> about undefined references when adding my own lmsensors recipe.
>>
>> Signed-off-by: Marc Ferland <ferlandm@sonatest.com>
>> ---
>>   meta/recipes-extended/sysstat/sysstat.inc       |    2 ++
>>   meta/recipes-extended/sysstat/sysstat_10.0.3.bb |    2 +-
>>   2 files changed, 3 insertions(+), 1 deletions(-)
>>
> You seem to be a little behind the master branch as it's on sysstat_10.0.5
>
> Please rebase your patch to master.
>
I failed to mention that this patch is based on denzil. I will send
another patch this time for master.

BTW, what is the preferred "--subject-prefix" to use to identify where the
patch should be merge?

Marc

Patch

diff --git a/meta/recipes-extended/sysstat/sysstat.inc b/meta/recipes-extended/sysstat/sysstat.inc
index 9da40a7..287bb54 100644
--- a/meta/recipes-extended/sysstat/sysstat.inc
+++ b/meta/recipes-extended/sysstat/sysstat.inc
@@ -3,12 +3,14 @@  DESCRIPTION = "The sysstat utilities are a collection of performance monitoring
 HOMEPAGE = "http://sebastien.godard.pagesperso-orange.fr/"
 LICENSE = "GPLv2+"
 SECTION = "console/utils"
+INC_PR = "r1"
 
 SRC_URI = "http://pagesperso-orange.fr/sebastien.godard/sysstat-${PV}.tar.gz \
 		   file://99_sysstat"
 
 inherit autotools gettext
 
+EXTRA_OECONF += "--disable-sensors"
 EXTRA_OEMAKE += 'LFLAGS=""'
 
 do_install() {
diff --git a/meta/recipes-extended/sysstat/sysstat_10.0.3.bb b/meta/recipes-extended/sysstat/sysstat_10.0.3.bb
index 7ef6c60..e9b95d8 100644
--- a/meta/recipes-extended/sysstat/sysstat_10.0.3.bb
+++ b/meta/recipes-extended/sysstat/sysstat_10.0.3.bb
@@ -2,7 +2,7 @@  require sysstat.inc
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
 
-PR = "r1"
+PR = "${INC_PR}.1"
 
 SRC_URI[md5sum] = "0e1ed5200f31f69a3b90ff1e81c07745"
 SRC_URI[sha256sum] = "7c0dd172f09edaff100b33db29ef502e15e71867b505c6d519f76a24fabcc1f5"