Patchwork glib-2.0: don't disable all debugging functionality

login
register
mail settings
Submitter Ross Burton
Date Aug. 30, 2012, 2:51 p.m.
Message ID <1346338319-17685-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/35547/
State Accepted
Commit 4337545ea05ec9d9f64244bb6be83fab329478d1
Headers show

Comments

Ross Burton - Aug. 30, 2012, 2:51 p.m.
GLib will use "minimal" debugging on non-development builds and the extra safety
net and ability to debug at all is totally worth the small performance cost.

If someone has a need for every ounce of performance, a simple .bbappend can
restore this option.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb |    2 +-
 meta/recipes-core/glib-2.0/glib.inc           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Saul Wold - Aug. 31, 2012, 4:07 p.m.
On 08/30/2012 07:51 AM, Ross Burton wrote:
> GLib will use "minimal" debugging on non-development builds and the extra safety
> net and ability to debug at all is totally worth the small performance cost.
>
> If someone has a need for every ounce of performance, a simple .bbappend can
> restore this option.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb |    2 +-
>   meta/recipes-core/glib-2.0/glib.inc           |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> index 8f7cd69..7bc97d68 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> @@ -1,6 +1,6 @@
>   require glib.inc
>
> -PR = "r4"
> +PR = "r5"
>   PE = "1"
>
>   DEPENDS += "libffi python-argparse-native zlib"
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 3540cd5..9dca440 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -27,7 +27,7 @@ S = "${WORKDIR}/glib-${PV}"
>
>   CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
>
> -EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
> +EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
>   EXTRA_OECONF_virtclass-native = "${CORECONF}"On 08/30/2012 07:51 AM, Ross Burton wrote:> GLib will use "minimal" debugging on non-development builds and the extra safety
> net and ability to debug at all is totally worth the small performance cost.
>
> If someone has a need for every ounce of performance, a simple .bbappend can
> restore this option.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb |    2 +-
>   meta/recipes-core/glib-2.0/glib.inc           |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> index 8f7cd69..7bc97d68 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> @@ -1,6 +1,6 @@
>   require glib.inc
>
> -PR = "r4"
> +PR = "r5"
>   PE = "1"
>
>   DEPENDS += "libffi python-argparse-native zlib"
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 3540cd5..9dca440 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -27,7 +27,7 @@ S = "${WORKDIR}/glib-${PV}"
>
>   CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
>
> -EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
> +EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
>   EXTRA_OECONF_virtclass-native = "${CORECONF}"
>   EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no ${CORECONF}"
>
>
>   EXTRA_OECONF_linuxstdbase = "--enable-included-prinOn 08/30/2012 07:51 AM, Ross Burton wrote:> GLib will use "minimal" debugging on non-development builds and the extra safety
> net and ability to debug at all is totally worth the small performance cost.
>
> If someone has a need for every ounce of performance, a simple .bbappend can
> restore this option.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb |    2 +-
>   meta/recipes-core/glib-2.0/glib.inc           |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> index 8f7cd69..7bc97d68 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> @@ -1,6 +1,6 @@
>   require glib.inc
>
> -PR = "r4"
> +PR = "r5"
>   PE = "1"
>
>   DEPENDS += "libffi python-argparse-native zlib"
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 3540cd5..9dca440 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -27,7 +27,7 @@ S = "${WORKDIR}/glib-${PV}"
>
>   CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
>
> -EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
> +EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
>   EXTRA_OECONF_virtclass-native = "${CORECONF}"
>   EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no ${CORECONF}"
>
> tf=no ${CORECONF}"
>
>

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
index 8f7cd69..7bc97d68 100644
--- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
+++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
@@ -1,6 +1,6 @@ 
 require glib.inc
 
-PR = "r4"
+PR = "r5"
 PE = "1"
 
 DEPENDS += "libffi python-argparse-native zlib"
diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index 3540cd5..9dca440 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -27,7 +27,7 @@  S = "${WORKDIR}/glib-${PV}"
 
 CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
 
-EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
+EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
 EXTRA_OECONF_virtclass-native = "${CORECONF}"
 EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no ${CORECONF}"