Patchwork [1/2] xserver-xorg: ship the exa module in a separate package

login
register
mail settings
Submitter Ross Burton
Date Aug. 29, 2012, 3:53 p.m.
Message ID <1346255613-13401-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/35501/
State Accepted
Commit 1a666ee1cda3c0b74daba5881fc5f62e13deec66
Headers show

Comments

Ross Burton - Aug. 29, 2012, 3:53 p.m.
EXA is used by some Xorg video drivers, it doesn't need to be shipped unless
it's being used.  Note that it's dynamically loaded so the automatic library
dependencies won't catch this, but as far as I'm aware nothing on oe-core or
meta-oe is using EXA.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc |    2 +-
 meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc |    3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
Koen Kooi - Aug. 29, 2012, 4:51 p.m.
Op 29 aug. 2012, om 17:53 heeft Ross Burton <ross.burton@intel.com> het volgende geschreven:

> EXA is used by some Xorg video drivers, it doesn't need to be shipped unless
> it's being used.  Note that it's dynamically loaded so the automatic library
> dependencies won't catch this, but as far as I'm aware nothing on oe-core or
> meta-oe is using EXA.

FWIW, the idea of those subpackages was to split every module out, but I haven't kept up with xorg modules for some years now.
Ross Burton - Aug. 30, 2012, 11:28 a.m.
On 29 August 2012 17:51, Koen Kooi <koen@dominion.thruhere.net> wrote:
> FWIW, the idea of those subpackages was to split every module out, but I haven't kept up with xorg modules for some years now.

There's also a lot of work ensuring that the dependencies are in place
because they can't be automatically inferred.  I'm happy leaving
fb/fbdev/shadow/shadowfb in the main package for now...

Ross
Koen Kooi - Aug. 30, 2012, 12:17 p.m.
Op 30 aug. 2012, om 13:28 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 29 August 2012 17:51, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> FWIW, the idea of those subpackages was to split every module out, but I haven't kept up with xorg modules for some years now.
> 
> There's also a lot of work ensuring that the dependencies are in place
> because they can't be automatically inferred.  I'm happy leaving
> fb/fbdev/shadow/shadowfb in the main package for now...

Indeed. In the past I had every device using full Xorg in OE on my desk, but with the demise of kdrive and the adoption rate of OE it has become impossible to have access to each device :)
Ross Burton - Aug. 30, 2012, 12:24 p.m.
On 30 August 2012 13:17, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Indeed. In the past I had every device using full Xorg in OE on my desk, but with the demise of kdrive and the adoption rate of OE it has become impossible to have access to each device :)

Speaking of hardware I'd like to test the touchscreen calibration code
in Xorg and purge the bits that are kdrive-specific.  Any
recommendations for hardware with a touchscreen?

Ross
Koen Kooi - Aug. 30, 2012, 1:12 p.m.
Op 30 aug. 2012, om 14:24 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 30 August 2012 13:17, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Indeed. In the past I had every device using full Xorg in OE on my desk, but with the demise of kdrive and the adoption rate of OE it has become impossible to have access to each device :)
> 
> Speaking of hardware I'd like to test the touchscreen calibration code
> in Xorg and purge the bits that are kdrive-specific.  Any
> recommendations for hardware with a touchscreen?

I'm biased of course, but this is what I use: http://beagleboardtoys.com/products/#LCD7 in combination with a beaglebone. Meta-ti has the needed drivers for it.
Ross Burton - Aug. 30, 2012, 2:04 p.m.
On 30 August 2012 14:12, Koen Kooi <koen@dominion.thruhere.net> wrote:
> I'm biased of course, but this is what I use: http://beagleboardtoys.com/products/#LCD7 in combination with a beaglebone. Meta-ti has the needed drivers for it.

I presume the same applies for the ULCD7 for the -xM?

Ross
Koen Kooi - Aug. 30, 2012, 2:24 p.m.
Op 30 aug. 2012, om 16:04 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 30 August 2012 14:12, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> I'm biased of course, but this is what I use: http://beagleboardtoys.com/products/#LCD7 in combination with a beaglebone. Meta-ti has the needed drivers for it.
> 
> I presume the same applies for the ULCD7 for the -xM?

Yes, but you'd still need meta-ti for the support. The uLCD7 for xM is in need of some driver love, which is on my TODO for next week.
Saul Wold - Sept. 4, 2012, 2:46 p.m.
On 08/29/2012 08:53 AM, Ross Burton wrote:
> EXA is used by some Xorg video drivers, it doesn't need to be shipped unless
> it's being used.  Note that it's dynamically loaded so the automatic library
> dependencies won't catch this, but as far as I'm aware nothing on oe-core or
> meta-oe is using EXA.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc |    2 +-
>   meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc |    3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> index 017ac91..b588c11 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> @@ -8,5 +8,5 @@ SRC_URI += "file://crosscompile.patch \
>   SRC_URI[md5sum] = "8796fff441e5435ee36a72579008af24"
>   SRC_URI[sha256sum] = "fa415decf02027ca278b06254ccfbcceba2a83c2741405257ebf749da4a73cf2"
>
> -PR = "r4"
> +PR = "r5"
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> index 98f3d14..738ccb3 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> @@ -29,6 +29,7 @@ DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util"
>   # Split out some modules and extensions from the main package
>   # These aren't needed for basic operations and only take up space:
>   #  32.0k   libdri.soOn 08/29/2012 08:53 AM, Ross Burton wrote:> EXA is used by some Xorg video drivers, it doesn't need to be shipped unless
> it's being used.  Note that it's dynamically loaded so the automatic library
> dependencies won't catch this, but as far as I'm aware nothing on oe-core or
> meta-oe is using EXA.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc |    2 +-
>   meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc |    3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> index 017ac91..b588c11 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> @@ -8,5 +8,5 @@ SRC_URI += "file://crosscompile.patch \
>   SRC_URI[md5sum] = "8796fff441e5435ee36a72579008af24"
>   SRC_URI[sha256sum] = "fa415decf02027ca278b06254ccfbcceba2a83c2741405257ebf749da4a73cf2"
>
> -PR = "r4"
> +PR = "r5"
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> index 98f3d14..738ccb3 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> @@ -29,6 +29,7 @@ DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util"
>   # Split out some modules and extensions from the main package
>   # These aren't needed for basic operations and only take up space:
>   #  32.0k   libdri.so
> +#  91.0k   libexa.so
>   #  336.0k  libglx.so
>   #  1360k   libint10.so
>   #  180.0k  libwfb.so
> @@ -58,6 +59,7 @@ PACKAGES =+ "${PN}-security-policy \
>                ${PN}-module-libwfb  \
>                ${PN}-module-libmfb \
>                ${PN}-module-libcfb \
> +             ${PN}-module-exa \
>                ${PN}-module-xaa \
>                ${PN}-module-libxf1bpp \
>                ${PN}-module-libxf4bpp"
> @@ -91,6 +93,7 @@ FILES_${PN}-module-libafb = "${libdir}/xorg/modules/libafb.so"
>   FILES_${PN}-module-libwfb = "${libdir}/xorg/modules/libwfb.so"
>   FILES_${PN}-module-libmfb = "${libdir}/xorg/modules/libmfb.so"
>   FILES_${PN}-module-libcfb = "${libdir}/xorg/modules/libcfb.so"
> +FILES_${PN}-module-exa = "${libdir}/xorg/modules/libexa.so"
>   FILES_${PN}-module-xaa = "${libdir}/xorg/modules/libxaa.so"
>   FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so"
>   FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so"
>
> +#  91.0k   libexa.so
>   #  336.0k  libglx.so
>   #  1360k   libint10.so
>   #  180.0k  libwfb.so
> @@ -58,6 +59,7 @@ PACKAGES =+ "${PN}-security-policy \
>                ${PN}-module-libwfb  \On 08/29/2012 08:53 AM, Ross Burton wrote:> EXA is used by some Xorg video drivers, it doesn't need to be shipped unless
> it's being used.  Note that it's dynamically loaded so the automatic library
> dependencies won't catch this, but as far as I'm aware nothing on oe-core or
> meta-oe is using EXA.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc |    2 +-
>   meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc |    3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> index 017ac91..b588c11 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> @@ -8,5 +8,5 @@ SRC_URI += "file://crosscompile.patch \
>   SRC_URI[md5sum] = "8796fff441e5435ee36a72579008af24"
>   SRC_URI[sha256sum] = "fa415decf02027ca278b06254ccfbcceba2a83c2741405257ebf749da4a73cf2"
>
> -PR = "r4"
> +PR = "r5"
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> index 98f3d14..738ccb3 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> @@ -29,6 +29,7 @@ DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util"
>   # Split out some modules and extensions from the main package
>   # These aren't needed for basic operations and only take up space:
>   #  32.0k   libdri.so
> +#  91.0k   libexa.so
>   #  336.0k  libglx.so
>   #  1360k   libint10.so
>   #  180.0k  libwfb.so
> @@ -58,6 +59,7 @@ PACKAGES =+ "${PN}-security-policy \
>                ${PN}-module-libwfb  \
>                ${PN}-module-libmfb \
>                ${PN}-module-libcfb \
> +             ${PN}-module-exa \
>                ${PN}-module-xaa \
>                ${PN}-module-libxf1bpp \
>                ${PN}-module-libxf4bpp"
> @@ -91,6 +93,7 @@ FILES_${PN}-module-libafb = "${libdir}/xorg/modules/libafb.so"
>   FILES_${PN}-module-libwfb = "${libdir}/xorg/modules/libwfb.so"
>   FILES_${PN}-module-libmfb = "${libdir}/xorg/modules/libmfb.so"
>   FILES_${PN}-module-libcfb = "${libdir}/xorg/modules/libcfb.so"
> +FILES_${PN}-module-exa = "${libdir}/xorg/modules/libexa.so"
>   FILES_${PN}-module-xaa = "${libdir}/xorg/modules/libxaa.so"
>   FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so"
>   FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so"
>
>                ${PN}-module-libmfb \
>                ${PN}-module-libcfb \
> +             ${PN}-module-exa \
>                ${PN}-module-xaa \
>                ${PN}-module-libxf1bpp \
>                ${PN}-module-libxf4bpp"
> @@ -91,6 +93,7 @@ FILES_${PN}-module-libafb = "${libdir}/xorg/modules/libafb.so"
>   FILES_${PN}-module-libwfb = "${libdir}/xorg/modules/libwfb.so"
>   FILES_${PN}-module-libmfb = "${libdir}/xorg/modules/libmfb.so"
>   FILES_${PN}-module-libcfb = "${libdir}/xorg/modules/libcfb.so"
> +FILES_${PN}-module-exa = "${libdir}/xorg/modules/libexa.so"
>   FILES_${PN}-module-xaa = "${libdir}/xorg/modules/libxaa.so"
>   FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so"
>   FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so"
>
Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
index 017ac91..b588c11 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
@@ -8,5 +8,5 @@  SRC_URI += "file://crosscompile.patch \
 SRC_URI[md5sum] = "8796fff441e5435ee36a72579008af24"
 SRC_URI[sha256sum] = "fa415decf02027ca278b06254ccfbcceba2a83c2741405257ebf749da4a73cf2"
 
-PR = "r4"
+PR = "r5"
 
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
index 98f3d14..738ccb3 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
@@ -29,6 +29,7 @@  DEPENDS = "${PROTO_DEPS} ${LIB_DEPS} font-util"
 # Split out some modules and extensions from the main package
 # These aren't needed for basic operations and only take up space:
 #  32.0k   libdri.so
+#  91.0k   libexa.so
 #  336.0k  libglx.so
 #  1360k   libint10.so
 #  180.0k  libwfb.so
@@ -58,6 +59,7 @@  PACKAGES =+ "${PN}-security-policy \
              ${PN}-module-libwfb  \
              ${PN}-module-libmfb \
              ${PN}-module-libcfb \
+             ${PN}-module-exa \
              ${PN}-module-xaa \
              ${PN}-module-libxf1bpp \
              ${PN}-module-libxf4bpp"
@@ -91,6 +93,7 @@  FILES_${PN}-module-libafb = "${libdir}/xorg/modules/libafb.so"
 FILES_${PN}-module-libwfb = "${libdir}/xorg/modules/libwfb.so"
 FILES_${PN}-module-libmfb = "${libdir}/xorg/modules/libmfb.so"
 FILES_${PN}-module-libcfb = "${libdir}/xorg/modules/libcfb.so"
+FILES_${PN}-module-exa = "${libdir}/xorg/modules/libexa.so"
 FILES_${PN}-module-xaa = "${libdir}/xorg/modules/libxaa.so"
 FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so"
 FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so"