Patchwork [1/2] Add dependency libidn to 3 packages

login
register
mail settings
Submitter Kang Kai
Date Aug. 29, 2012, 10:39 a.m.
Message ID <9f48122d927aa0253b5f5a4e0f3dfe242c557d4e.1346236551.git.kai.kang@windriver.com>
Download mbox | patch
Permalink /patch/35481/
State New
Headers show

Comments

Kang Kai - Aug. 29, 2012, 10:39 a.m.
Add dependency libidn to wget, ghostscript and msmtp. These packages
check libidn automatically to build with or without libidn.
When libidn has been populate to sysroot but doesn't create rpm/deb
package, create image will fail as follow:

| Processing task-core-basic...
| Processing task-core-ssh-openssh...
| Processing task-base-extended...
| error: Failed dependencies:
| 	libidn11 >= 1.25 is needed by msmtp-1.4.24-r3.i586
| 	libidn.so.11(LIBIDN_1.0) is needed by msmtp-1.4.24-r3.i586
| 	libidn.so.11 is needed by msmtp-1.4.24-r3.i586
| 	libidn11 >= 1.25 is needed by ghostscript-9.05-r2.i586
| 	libidn.so.11(LIBIDN_1.0) is needed by ghostscript-9.05-r2.i586
| 	libidn.so.11 is needed by ghostscript-9.05-r2.i586
| ERROR: Function failed: do_rootfs (see
| /mnt/sda10/poky-all-platform/build/tmp/work/qemux86-poky-linux/core-image-lsb-1.0-r0/temp/log.do_rootfs.29665
| for further information)

Add libidn to dependence to fix this error.

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 .../ghostscript/ghostscript_9.05.bb                |    4 ++--
 meta/recipes-extended/msmtp/msmtp_1.4.24.bb        |    4 ++--
 meta/recipes-extended/wget/wget.inc                |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
Richard Purdie - Aug. 29, 2012, 10:56 p.m.
On Wed, 2012-08-29 at 18:39 +0800, Kang Kai wrote:
> Add dependency libidn to wget, ghostscript and msmtp. These packages
> check libidn automatically to build with or without libidn.
> When libidn has been populate to sysroot but doesn't create rpm/deb
> package, create image will fail as follow:

What do we gain by adding this dependency? Do we need it?

Cheers,

Richard
Kang Kai - Aug. 30, 2012, 1:51 a.m.
On 2012?08?30? 06:56, Richard Purdie wrote:
> On Wed, 2012-08-29 at 18:39 +0800, Kang Kai wrote:
>> Add dependency libidn to wget, ghostscript and msmtp. These packages
>> check libidn automatically to build with or without libidn.
>> When libidn has been populate to sysroot but doesn't create rpm/deb
>> package, create image will fail as follow:

Hi Richard,

> What do we gain by adding this dependency? Do we need it?
For wget, It can deal international domain name such as 
"http://stefan.kögl.co.at/"
It is fine to disable it, I'll send V2.

Regards,
Kai

>
> Cheers,
>
> Richard
>
>

Patch

diff --git a/meta/recipes-extended/ghostscript/ghostscript_9.05.bb b/meta/recipes-extended/ghostscript/ghostscript_9.05.bb
index dc6e481..a0de5db 100644
--- a/meta/recipes-extended/ghostscript/ghostscript_9.05.bb
+++ b/meta/recipes-extended/ghostscript/ghostscript_9.05.bb
@@ -15,9 +15,9 @@  SECTION = "console/utils"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=c5326026692dbed183f0558f926580f8"
 
-PR = "r2"
+PR = "r3"
 
-DEPENDS = "ghostscript-native tiff jpeg fontconfig cups"
+DEPENDS = "ghostscript-native tiff jpeg fontconfig cups libidn"
 DEPENDS_virtclass-native = ""
 
 SRC_URI_BASE = "http://downloads.ghostscript.com/public/ghostscript-${PV}.tar.gz"
diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.24.bb b/meta/recipes-extended/msmtp/msmtp_1.4.24.bb
index 08566ca..780bdf1 100644
--- a/meta/recipes-extended/msmtp/msmtp_1.4.24.bb
+++ b/meta/recipes-extended/msmtp/msmtp_1.4.24.bb
@@ -4,8 +4,8 @@  HOMEPAGE = "http://msmtp.sourceforge.net/"
 SECTION = "console/network"
 
 LICENSE = "GPLv3"
-DEPENDS = "zlib gnutls"
-PR = "r3"
+DEPENDS = "zlib gnutls libidn"
+PR = "r4"
 
 
 #COPYING or Licence
diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
index 3575c87..156c8a8 100644
--- a/meta/recipes-extended/wget/wget.inc
+++ b/meta/recipes-extended/wget/wget.inc
@@ -2,9 +2,9 @@  DESCRIPTION = "A console URL download utility featuring HTTP, FTP, and more."
 SECTION = "console/network"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
-DEPENDS = "openssl"
+DEPENDS = "openssl libidn"
 
-INC_PR = "r15"
+INC_PR = "r16"
 
 inherit autotools gettext update-alternatives