Patchwork [bitbake-devel] taskdata: Don't add dependencies on tasks that don't exist

login
register
mail settings
Submitter Richard Purdie
Date Aug. 28, 2012, 3:11 p.m.
Message ID <1346166694.23096.0.camel@ted>
Download mbox | patch
Permalink /patch/35455/
State New
Headers show

Comments

Richard Purdie - Aug. 28, 2012, 3:11 p.m.
"bitbake meta-toolchain" with qemu image testing enabled causes problems
since it adds a task after do_rootfs which doesn't exist in this case.

We should simply ignore these extra dependencies rather than adding
them in which is what this patch does (adding a debug message when this
happens).

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/bitbake/lib/bb/taskdata.py b/bitbake/lib/bb/taskdata.py
index aed3a16..c08186a 100644
--- a/bitbake/lib/bb/taskdata.py
+++ b/bitbake/lib/bb/taskdata.py
@@ -176,6 +176,9 @@  class TaskData:
             # Work out task dependencies
             parentids = []
             for dep in task_deps['parents'][task]:
+                if dep not in task_deps['tasks']:
+                    bb.debug(2, "Not adding dependeny of %s on %s since %s does not exist" % (task, dep, dep))
+                    continue
                 parentid = self.gettask_id(fn, dep)
                 parentids.append(parentid)
             taskid = self.gettask_id(fn, task)