| Submitter | Tom Zanussi |
|---|---|
| Date | Aug. 25, 2012, 10:57 p.m. |
| Message ID | <dc1953f169a835ec6b1dd04c78d61900f0fb53d5.1345935181.git.tom.zanussi@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/35351/ |
| State | Accepted |
| Commit | f04b0ddb7a392425ba5890026564bc3521a32c67 |
| Headers | show |
Comments
On Sat, 2012-08-25 at 17:57 -0500, tom.zanussi@intel.com wrote: > From: Tom Zanussi <tom.zanussi@intel.com> > > perf depends on bison and flex for event parsing - add them as > dependencies. Does it need these at build time or runtime? I suspect you meant to add these as RDEPENDS as it needs them at runtime? Cheers, Richard > > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com> > --- > meta/recipes-kernel/perf/perf_3.4.bb | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb > index 5fb38e6..decc911 100644 > --- a/meta/recipes-kernel/perf/perf_3.4.bb > +++ b/meta/recipes-kernel/perf/perf_3.4.bb > @@ -9,7 +9,7 @@ as well." > LICENSE = "GPLv2" > LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" > > -PR = "r4" > +PR = "r5" > > require perf.inc > > @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \ > ${MLPREFIX}binutils \ > ${TUI_DEPENDS} \ > ${SCRIPTING_DEPENDS} \ > + bison flex \ > " > > SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl perl-modules python', '',d)}"
On Sun, 2012-08-26 at 09:35 +0100, Richard Purdie wrote: > On Sat, 2012-08-25 at 17:57 -0500, tom.zanussi@intel.com wrote: > > From: Tom Zanussi <tom.zanussi@intel.com> > > > > perf depends on bison and flex for event parsing - add them as > > dependencies. > > Does it need these at build time or runtime? I suspect you meant to add > these as RDEPENDS as it needs them at runtime? > Build-time e.g. pmu.y --> pmu-bison.c --> pmu.o So it should be DEPENDS... Tom > Cheers, > > Richard > > > > > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com> > > --- > > meta/recipes-kernel/perf/perf_3.4.bb | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb > > index 5fb38e6..decc911 100644 > > --- a/meta/recipes-kernel/perf/perf_3.4.bb > > +++ b/meta/recipes-kernel/perf/perf_3.4.bb > > @@ -9,7 +9,7 @@ as well." > > LICENSE = "GPLv2" > > LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" > > > > -PR = "r4" > > +PR = "r5" > > > > require perf.inc > > > > @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \ > > ${MLPREFIX}binutils \ > > ${TUI_DEPENDS} \ > > ${SCRIPTING_DEPENDS} \ > > + bison flex \ > > " > > > > SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl perl-modules python', '',d)}" > >
Patch
diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb index 5fb38e6..decc911 100644 --- a/meta/recipes-kernel/perf/perf_3.4.bb +++ b/meta/recipes-kernel/perf/perf_3.4.bb @@ -9,7 +9,7 @@ as well." LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" -PR = "r4" +PR = "r5" require perf.inc @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \ ${MLPREFIX}binutils \ ${TUI_DEPENDS} \ ${SCRIPTING_DEPENDS} \ + bison flex \ " SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl perl-modules python', '',d)}"