Patchwork distutils-common-base.bbclass: Pick up additional .debug folders:

login
register
mail settings
Submitter Matthew McClintock
Date Aug. 23, 2012, 6:46 p.m.
Message ID <1345747597-18078-1-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/35239/
State New
Headers show

Comments

Matthew McClintock - Aug. 23, 2012, 6:46 p.m.
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/classes/distutils-common-base.bbclass |    3 +++
 1 file changed, 3 insertions(+)
Ross Burton - Aug. 23, 2012, 10:13 p.m.
On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
>    ${PYTHON_SITEPACKAGES_DIR}/.debug \
>    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
>    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
> +  ${libdir}/${PYTHON_DIR}/.debug \
> +  ${libdir}/${PYTHON_DIR}/*/.debug \
> +  ${libdir}/${PYTHON_DIR}/*/*/.debug \

I thought packages that used distutils generally put their files under
sitepackages, and not the python base directory...  Are some packages
doing it wrong?

Ross
McClintock Matthew-B29882 - Aug. 23, 2012, 10:57 p.m.
On Thu, Aug 23, 2012 at 5:13 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
>>    ${PYTHON_SITEPACKAGES_DIR}/.debug \
>>    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
>>    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
>> +  ${libdir}/${PYTHON_DIR}/.debug \
>> +  ${libdir}/${PYTHON_DIR}/*/.debug \
>> +  ${libdir}/${PYTHON_DIR}/*/*/.debug \
>
> I thought packages that used distutils generally put their files under
> sitepackages, and not the python base directory...  Are some packages
> doing it wrong?

pexpect was installing /usr/lib/python2.7 and that was my basis for
the correct location so I changed it to ${libdir} to fix that... I
just sent another patch that might address this issue..

-M

>
> Ross
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Martin Jansa - Aug. 24, 2012, 6:25 a.m.
On Thu, Aug 23, 2012 at 11:13:08PM +0100, Burton, Ross wrote:
> On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
> >    ${PYTHON_SITEPACKAGES_DIR}/.debug \
> >    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
> >    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
> > +  ${libdir}/${PYTHON_DIR}/.debug \
> > +  ${libdir}/${PYTHON_DIR}/*/.debug \
> > +  ${libdir}/${PYTHON_DIR}/*/*/.debug \
> 
> I thought packages that used distutils generally put their files under
> sitepackages, and not the python base directory...  Are some packages
> doing it wrong?

Yes, almost all python-* recipes after this patch
http://git.openembedded.org/openembedded-core/commit/?id=3b23feca31480cc56f55301fd0274e622c40b522

I have 9 such recipes in my dep tree.

Cheers,
McClintock Matthew-B29882 - Aug. 24, 2012, 4:06 p.m.
On Fri, Aug 24, 2012 at 1:25 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Aug 23, 2012 at 11:13:08PM +0100, Burton, Ross wrote:
>> On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
>> >    ${PYTHON_SITEPACKAGES_DIR}/.debug \
>> >    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
>> >    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
>> > +  ${libdir}/${PYTHON_DIR}/.debug \
>> > +  ${libdir}/${PYTHON_DIR}/*/.debug \
>> > +  ${libdir}/${PYTHON_DIR}/*/*/.debug \
>>
>> I thought packages that used distutils generally put their files under
>> sitepackages, and not the python base directory...  Are some packages
>> doing it wrong?
>
> Yes, almost all python-* recipes after this patch
> http://git.openembedded.org/openembedded-core/commit/?id=3b23feca31480cc56f55301fd0274e622c40b522
>
> I have 9 such recipes in my dep tree.

Martin,

Can you look at:

http://patches.openembedded.org/patch/35245/

-M

>
> Cheers,
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Aug. 24, 2012, 4:16 p.m.
On Fri, 2012-08-24 at 08:25 +0200, Martin Jansa wrote:
> On Thu, Aug 23, 2012 at 11:13:08PM +0100, Burton, Ross wrote:
> > On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
> > >    ${PYTHON_SITEPACKAGES_DIR}/.debug \
> > >    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
> > >    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
> > > +  ${libdir}/${PYTHON_DIR}/.debug \
> > > +  ${libdir}/${PYTHON_DIR}/*/.debug \
> > > +  ${libdir}/${PYTHON_DIR}/*/*/.debug \
> > 
> > I thought packages that used distutils generally put their files under
> > sitepackages, and not the python base directory...  Are some packages
> > doing it wrong?
> 
> Yes, almost all python-* recipes after this patch
> http://git.openembedded.org/openembedded-core/commit/?id=3b23feca31480cc56f55301fd0274e622c40b522
> 
> I have 9 such recipes in my dep tree.

That patch shouldn't have gone in, it breaks things. I've posted
something to try and fix things for everyone although python packaging
isn't my strong area.

Cheers,

Richard
Martin Jansa - Aug. 24, 2012, 4:19 p.m.
On Fri, Aug 24, 2012 at 04:06:45PM +0000, McClintock Matthew-B29882 wrote:
> On Fri, Aug 24, 2012 at 1:25 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Thu, Aug 23, 2012 at 11:13:08PM +0100, Burton, Ross wrote:
> >> On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
> >> >    ${PYTHON_SITEPACKAGES_DIR}/.debug \
> >> >    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
> >> >    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
> >> > +  ${libdir}/${PYTHON_DIR}/.debug \
> >> > +  ${libdir}/${PYTHON_DIR}/*/.debug \
> >> > +  ${libdir}/${PYTHON_DIR}/*/*/.debug \
> >>
> >> I thought packages that used distutils generally put their files under
> >> sitepackages, and not the python base directory...  Are some packages
> >> doing it wrong?
> >
> > Yes, almost all python-* recipes after this patch
> > http://git.openembedded.org/openembedded-core/commit/?id=3b23feca31480cc56f55301fd0274e622c40b522
> >
> > I have 9 such recipes in my dep tree.
> 
> Martin,
> 
> Can you look at:
> 
> http://patches.openembedded.org/patch/35245/

Not right now.. the builder with OEBasicHash which failed because of
this will be busy for next 40 hours at least because pixman PRINC was
bumped..

Cheers,

> -M
> 
> >
> > Cheers,
> >
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> >
Richard Purdie - Aug. 24, 2012, 4:20 p.m.
On Fri, 2012-08-24 at 16:06 +0000, McClintock Matthew-B29882 wrote:
> On Fri, Aug 24, 2012 at 1:25 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Thu, Aug 23, 2012 at 11:13:08PM +0100, Burton, Ross wrote:
> >> On 23 August 2012 19:46, Matthew McClintock <msm@freescale.com> wrote:
> >> >    ${PYTHON_SITEPACKAGES_DIR}/.debug \
> >> >    ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
> >> >    ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
> >> > +  ${libdir}/${PYTHON_DIR}/.debug \
> >> > +  ${libdir}/${PYTHON_DIR}/*/.debug \
> >> > +  ${libdir}/${PYTHON_DIR}/*/*/.debug \
> >>
> >> I thought packages that used distutils generally put their files under
> >> sitepackages, and not the python base directory...  Are some packages
> >> doing it wrong?
> >
> > Yes, almost all python-* recipes after this patch
> > http://git.openembedded.org/openembedded-core/commit/?id=3b23feca31480cc56f55301fd0274e622c40b522
> >
> > I have 9 such recipes in my dep tree.
> 
> Martin,
> 
> Can you look at:
> 
> http://patches.openembedded.org/patch/35245/

This gets so far but breaks python-argparse which uses setuptools. I've
posted a patch which fixes both.

Cheers,

Richard

Patch

diff --git a/meta/classes/distutils-common-base.bbclass b/meta/classes/distutils-common-base.bbclass
index f66a5cd..e650d93 100644
--- a/meta/classes/distutils-common-base.bbclass
+++ b/meta/classes/distutils-common-base.bbclass
@@ -18,4 +18,7 @@  FILES_${PN}-dbg += "\
   ${PYTHON_SITEPACKAGES_DIR}/.debug \
   ${PYTHON_SITEPACKAGES_DIR}/*/.debug \
   ${PYTHON_SITEPACKAGES_DIR}/*/*/.debug \
+  ${libdir}/${PYTHON_DIR}/.debug \
+  ${libdir}/${PYTHON_DIR}/*/.debug \
+  ${libdir}/${PYTHON_DIR}/*/*/.debug \
 "