Patchwork iputils: chmod in pkg_postinst are redundant

login
register
mail settings
Submitter Saul Wold
Date Aug. 23, 2012, 6:36 p.m.
Message ID <1345746983-15845-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/35235/
State Accepted
Commit a2bc81032c85548f7c72dc76e6020ab4df9af6de
Headers show

Comments

Saul Wold - Aug. 23, 2012, 6:36 p.m.
With pseudo the cmod in pkg_postinst is actaully redundant since
the do_install uses install -m 4555 and pseudo is able to track that
between the install time and the rootfs package installation, so the
perms are correct.

[YOCTO #2894]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-extended/iputils/iputils_s20101006.bb |   14 +-------------
 1 files changed, 1 insertions(+), 13 deletions(-)

Patch

diff --git a/meta/recipes-extended/iputils/iputils_s20101006.bb b/meta/recipes-extended/iputils/iputils_s20101006.bb
index 62e2b5e..2c2766c 100644
--- a/meta/recipes-extended/iputils/iputils_s20101006.bb
+++ b/meta/recipes-extended/iputils/iputils_s20101006.bb
@@ -13,7 +13,7 @@  LIC_FILES_CHKSUM = "file://ping.c;beginline=1;endline=35;md5=f9ceb201733e9a6cf8f
 
 DEPENDS = "openssl docbook-utils-native sgmlspl-native"
 
-PR = "r5"
+PR = "r6"
 
 SRC_URI = "http://www.skbuff.net/iputils/${BPN}-${PV}.tar.bz2 \
            file://debian/fix-dead-host-ping-stats.diff \
@@ -58,18 +58,6 @@  ALTERNATIVE_LINK_NAME[ping] = "${base_bindir}/ping"
 ALTERNATIVE_${PN}-ping6 = "ping6"
 ALTERNATIVE_LINK_NAME[ping6] = "${base_bindir}/ping6"
 
-pkg_postinst_${PN}-ping () {
-       chmod 4555 ${base_bindir}/ping
-}
-
-pkg_postinst_${PN}-ping6 () {
-       chmod 4555 ${base_bindir}/ping6
-}
-
-pkg_postinst_${PN}-traceroute6 () {
-	chmod 4555 ${base_bindir}/traceroute6
-}
-
 PACKAGES += "${PN}-ping ${PN}-ping6 ${PN}-arping ${PN}-tracepath ${PN}-tracepath6 ${PN}-traceroute6"
 
 ALLOW_EMPTY_${PN} = "1"