Patchwork [1/4] runqemu: Honor KERNEL and ROOTFS settings from environment

login
register
mail settings
Submitter Khem Raj
Date Aug. 22, 2012, 5:59 p.m.
Message ID <1345658390-19692-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/35149/
State Accepted
Commit c985b02130658dd64581ecf14b16e2c70d1d8db5
Headers show

Comments

Khem Raj - Aug. 22, 2012, 5:59 p.m.
Expand the usage to be able to specify KERNEL and ROOTFS
on commandline. This helps in using the script for booting
images that are essentially not part of OE-Core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 scripts/runqemu |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Scott Garman - Aug. 24, 2012, 7:26 a.m.
On 08/22/2012 10:59 AM, Khem Raj wrote:
> Expand the usage to be able to specify KERNEL and ROOTFS
> on commandline. This helps in using the script for booting
> images that are essentially not part of OE-Core
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Sure, this looks okay.

Acked-by: Scott Garman <scott.a.garman@intel.com>

> ---
>   scripts/runqemu |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 90998ae..290f9cc 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -54,9 +54,9 @@ error() {
>   }
>
>   MACHINE=${MACHINE:=""}
> -KERNEL=""
> +KERNEL=${KERNEL:=""}
> +ROOTFS=${ROOTFS:=""}
>   FSTYPE=""
> -ROOTFS=""
>   LAZY_ROOTFS=""
>   SCRIPT_QEMU_OPT=""
>   SCRIPT_QEMU_EXTRA_OPT=""
>
Saul Wold - Aug. 24, 2012, 6:09 p.m.
On 08/22/2012 10:59 AM, Khem Raj wrote:
> Expand the usage to be able to specify KERNEL and ROOTFS
> on commandline. This helps in using the script for booting
> images that are essentially not part of OE-Core
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   scripts/runqemu |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 90998ae..290f9cc 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -54,9 +54,9 @@ error() {
>   }
>
>   MACHINE=${MACHINE:=""}
> -KERNEL=""
> +KERNEL=${KERNEL:=""}
> +ROOTFS=${ROOTFS:=""}
>   FSTYPE=""
> -ROOTFS=""
>   LAZY_ROOTFS=""
>   SCRIPT_QEMU_OPT=""
>   SCRIPT_QEMU_EXTRA_OPT=""
>

Merged this along with 2 others, did not merge the the CC/KERNEL_CC change.

Thanks
	Sau!

Patch

diff --git a/scripts/runqemu b/scripts/runqemu
index 90998ae..290f9cc 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -54,9 +54,9 @@  error() {
 }
 
 MACHINE=${MACHINE:=""}
-KERNEL=""
+KERNEL=${KERNEL:=""}
+ROOTFS=${ROOTFS:=""}
 FSTYPE=""
-ROOTFS=""
 LAZY_ROOTFS=""
 SCRIPT_QEMU_OPT=""
 SCRIPT_QEMU_EXTRA_OPT=""