Patchwork [2/4] linux-yocto: Remove parens from COMPATIBLE_MACHINE regexp

login
register
mail settings
Submitter Khem Raj
Date Aug. 22, 2012, 5:59 p.m.
Message ID <1345658390-19692-2-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/35145/
State Accepted
Commit 32ba716e71fb7a16f13c83ab6c8cc51de56b3be2
Headers show

Comments

Khem Raj - Aug. 22, 2012, 5:59 p.m.
This helps in appending to this regexp from bbappends
coming from other layers who want to leverage linux-yocto
with minimum tweaks by using a standard prefefined machine
from linux-yocto

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-kernel/linux/linux-yocto_3.0.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.2.bb |    2 +-
 meta/recipes-kernel/linux/linux-yocto_3.4.bb |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Bruce Ashfield - Aug. 22, 2012, 6:11 p.m.
On Wed, Aug 22, 2012 at 1:59 PM, Khem Raj <raj.khem@gmail.com> wrote:
> This helps in appending to this regexp from bbappends
> coming from other layers who want to leverage linux-yocto
> with minimum tweaks by using a standard prefefined machine
> from linux-yocto

Fine with me.

We had a long winded discussion over a year ago about how the parens
could be present, and still allow us to easily append, but my search
didn't turn it up.

I can't see where this would cause a problem (others may though), so

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

Cheers,

Bruce


>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-kernel/linux/linux-yocto_3.0.bb |    2 +-
>  meta/recipes-kernel/linux/linux-yocto_3.2.bb |    2 +-
>  meta/recipes-kernel/linux/linux-yocto_3.4.bb |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.0.bb b/meta/recipes-kernel/linux/linux-yocto_3.0.bb
> index f5e812e..4d19664 100644
> --- a/meta/recipes-kernel/linux/linux-yocto_3.0.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto_3.0.bb
> @@ -26,7 +26,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.0;protocol=git;bareclone=1;b
>
>  SRC_URI += "file://noslang.patch"
>
> -COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
> +COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
>
>  # Functionality flags
>  KERNEL_FEATURES = "features/netfilter"
> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.2.bb b/meta/recipes-kernel/linux/linux-yocto_3.2.bb
> index b254251..c3fb252 100644
> --- a/meta/recipes-kernel/linux/linux-yocto_3.2.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto_3.2.bb
> @@ -26,7 +26,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.2;protocol=git;bareclone=1;b
>
>  SRC_URI += "file://noslang.patch"
>
> -COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
> +COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
>
>  # Functionality flags
>  KERNEL_FEATURES="features/netfilter"
> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
> index 8ac2402..691d789 100644
> --- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
> @@ -22,7 +22,7 @@ PV = "${LINUX_VERSION}+git${SRCPV}"
>
>  KMETA = "meta"
>
> -COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
> +COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
>
>  # Functionality flags
>  KERNEL_REVISION_CHECKING=""
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-kernel/linux/linux-yocto_3.0.bb b/meta/recipes-kernel/linux/linux-yocto_3.0.bb
index f5e812e..4d19664 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.0.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.0.bb
@@ -26,7 +26,7 @@  SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.0;protocol=git;bareclone=1;b
 
 SRC_URI += "file://noslang.patch"
 
-COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
+COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
 
 # Functionality flags
 KERNEL_FEATURES = "features/netfilter"
diff --git a/meta/recipes-kernel/linux/linux-yocto_3.2.bb b/meta/recipes-kernel/linux/linux-yocto_3.2.bb
index b254251..c3fb252 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.2.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.2.bb
@@ -26,7 +26,7 @@  SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.2;protocol=git;bareclone=1;b
 
 SRC_URI += "file://noslang.patch"
 
-COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
+COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
 
 # Functionality flags
 KERNEL_FEATURES="features/netfilter"
diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
index 8ac2402..691d789 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
@@ -22,7 +22,7 @@  PV = "${LINUX_VERSION}+git${SRCPV}"
 
 KMETA = "meta"
 
-COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
+COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
 
 # Functionality flags
 KERNEL_REVISION_CHECKING=""