From patchwork Tue Aug 21 19:17:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel] ui: Improve error message if bitbake cannot import python curses module Date: Tue, 21 Aug 2012 19:17:00 -0000 From: Mark Hatle X-Patchwork-Id: 35115 Message-Id: <1345576620-9407-1-git-send-email-mark.hatle@windriver.com> To: From: Konrad Scherer On some SuSE systems, the curses python module is not installed by default. Instead of a python failure, we want a nicer error message. (On SuSE systems the package is typically python-curses.) Signed-off-by: Konrad Scherer Signed-off-by: Jeff Polk Reword commit message, rebase to latest bitbake. Signed-off-by: Mark Hatle --- lib/bb/ui/knotty.py | 6 +++++- lib/bb/ui/ncurses.py | 8 +++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py index b01daee..858cacf 100644 --- a/lib/bb/ui/knotty.py +++ b/lib/bb/ui/knotty.py @@ -141,7 +141,11 @@ class TerminalFilter(object): if not self.interactive: return - import curses + try: + import curses + except ImportError: + sys.exit("FATAL: The knotty ui could not load the required curses python module.") + import termios self.curses = curses self.termios = termios diff --git a/lib/bb/ui/ncurses.py b/lib/bb/ui/ncurses.py index 1425bbd..f573b95 100644 --- a/lib/bb/ui/ncurses.py +++ b/lib/bb/ui/ncurses.py @@ -47,7 +47,13 @@ from __future__ import division import logging -import os, sys, curses, itertools, time, subprocess +import os, sys, itertools, time, subprocess + +try: + import curses +except ImportError: + sys.exit("FATAL: The ncurses ui could not load the required curses python module.") + import bb import xmlrpclib from bb import ui