Patchwork Pull request with misc changes

login
register
mail settings
Submitter Otavio Salvador
Date May 9, 2011, 7:15 p.m.
Message ID <BANLkTi=424KO0PMR6b_2QC98qtUryMykdQ@mail.gmail.com>
Download mbox
Permalink /patch/3503/
State New, archived
Headers show

Pull-request

git://github.com/OSSystems/oe-core master

Comments

Otavio Salvador - May 9, 2011, 7:15 p.m.
Hello,

This pull request fixes some issues I found since the last pull
request and should be preferred against the first.

The following changes since commit d0dc2b5bb02ef55a41e7a97b6831c72391ae7f36:

  u-boot: correct COPYING MD5SUM (2011-05-08 23:56:11 -0700)

are available in the git repository at:
  git://github.com/OSSystems/oe-core master

Otavio Salvador (10):
      meta/conf/local.conf.sample: fix mklibs comment line split and typo
      scripts/oe-setup-builddir: fix typo
      syslinux: improve packaging
      busybox: add support to mdev
      libxkbfile: disable xcb
      insane.bbclass: skip license checksum if LICENSE is "CLOSED"
      cmake.bbclass: fix qmake and rpath issues
      qmake_base.bbclass: add generate_qt_config_file task
      cmake: add support for oe qt4 tools names
      fuse: drop since it is not used by other recipes

 .../fuse-2.7.2/not-run-updaterc.d-on-host.patch    |   15 ----
 meta-demoapps/recipes-kernel/fuse/fuse.inc         |   13 ---
 meta-demoapps/recipes-kernel/fuse/fuse_2.7.2.bb    |   22 -----
 meta/classes/cmake.bbclass                         |   19 ++++-
 meta/classes/insane.bbclass                        |    4 +
 meta/classes/qmake_base.bbclass                    |   15 ++++
 meta/conf/local.conf.sample                        |    7 +-
 meta/recipes-core/busybox/busybox.inc              |   14 +++-
 meta/recipes-core/busybox/busybox_1.18.4.bb        |    2 +
 meta/recipes-core/busybox/files/mdev               |    7 ++
 meta/recipes-core/busybox/files/mdev.conf          |   35 ++++++++
 meta/recipes-devtools/cmake/cmake-native_2.8.3.bb  |    2 +-
 meta/recipes-devtools/cmake/cmake.inc              |    3 +-
 .../cmake/cmake/support-oe-qt4-tools-names.patch   |   85 ++++++++++++++++++++
 meta/recipes-devtools/syslinux/syslinux_4.03.bb    |   12 +++-
 meta/recipes-graphics/xorg-lib/libxkbfile_1.0.7.bb |    4 +-
 scripts/oe-setup-builddir                          |    2 +-
 17 files changed, 199 insertions(+), 62 deletions(-)
 delete mode 100644
meta-demoapps/recipes-kernel/fuse/fuse-2.7.2/not-run-updaterc.d-on-host.patch
 delete mode 100644 meta-demoapps/recipes-kernel/fuse/fuse.inc
 delete mode 100644 meta-demoapps/recipes-kernel/fuse/fuse_2.7.2.bb
 create mode 100755 meta/recipes-core/busybox/files/mdev
 create mode 100644 meta/recipes-core/busybox/files/mdev.conf
 create mode 100644
meta/recipes-devtools/cmake/cmake/support-oe-qt4-tools-names.patch
Saul Wold - May 10, 2011, 5:17 a.m.
On 05/09/2011 12:15 PM, Otavio Salvador wrote:
> Hello,
>
> This pull request fixes some issues I found since the last pull
> request and should be preferred against the first.
>
Otavio,

Next time, please use the create-pull-request script, which will 
generate a set of patch emails so that we can review this information 
via email. I will make a couple of additional comments below associated 
with each patch.

> The following changes since commit d0dc2b5bb02ef55a41e7a97b6831c72391ae7f36:
>
>    u-boot: correct COPYING MD5SUM (2011-05-08 23:56:11 -0700)
>
> are available in the git repository at:
>    git://github.com/OSSystems/oe-core master
>
> Otavio Salvador (10):
>        meta/conf/local.conf.sample: fix mklibs comment line split and typo
>        scripts/oe-setup-builddir: fix typo
>        syslinux: improve packaging
>        busybox: add support to mdev
>        libxkbfile: disable xcb
>        insane.bbclass: skip license checksum if LICENSE is "CLOSED"
I assume you are adding this for layers and commercial work, we should 
never have CLOSED in any open layer.

>        cmake.bbclass: fix qmake and rpath issues
>        qmake_base.bbclass: add generate_qt_config_file task
>        cmake: add support for oe qt4 tools names
Please add a comment to the patch explaining it's purpose and origin, 
and include a Signed-off-by: if appropriate. Any patches that you have 
modified or added should include the above info.

>        fuse: drop since it is not used by other recipes
>
>   .../fuse-2.7.2/not-run-updaterc.d-on-host.patch    |   15 ----
>   meta-demoapps/recipes-kernel/fuse/fuse.inc         |   13 ---
>   meta-demoapps/recipes-kernel/fuse/fuse_2.7.2.bb    |   22 -----
>   meta/classes/cmake.bbclass                         |   19 ++++-
>   meta/classes/insane.bbclass                        |    4 +
>   meta/classes/qmake_base.bbclass                    |   15 ++++
>   meta/conf/local.conf.sample                        |    7 +-
>   meta/recipes-core/busybox/busybox.inc              |   14 +++-
>   meta/recipes-core/busybox/busybox_1.18.4.bb        |    2 +
>   meta/recipes-core/busybox/files/mdev               |    7 ++
>   meta/recipes-core/busybox/files/mdev.conf          |   35 ++++++++
>   meta/recipes-devtools/cmake/cmake-native_2.8.3.bb  |    2 +-
>   meta/recipes-devtools/cmake/cmake.inc              |    3 +-
>   .../cmake/cmake/support-oe-qt4-tools-names.patch   |   85 ++++++++++++++++++++
>   meta/recipes-devtools/syslinux/syslinux_4.03.bb    |   12 +++-
>   meta/recipes-graphics/xorg-lib/libxkbfile_1.0.7.bb |    4 +-
>   scripts/oe-setup-builddir                          |    2 +-
>   17 files changed, 199 insertions(+), 62 deletions(-)
>   delete mode 100644
> meta-demoapps/recipes-kernel/fuse/fuse-2.7.2/not-run-updaterc.d-on-host.patch
>   delete mode 100644 meta-demoapps/recipes-kernel/fuse/fuse.inc
>   delete mode 100644 meta-demoapps/recipes-kernel/fuse/fuse_2.7.2.bb
>   create mode 100755 meta/recipes-core/busybox/files/mdev
>   create mode 100644 meta/recipes-core/busybox/files/mdev.conf
>   create mode 100644
> meta/recipes-devtools/cmake/cmake/support-oe-qt4-tools-names.patch
>
>
Otavio Salvador - May 10, 2011, 12:53 p.m.
On Tue, May 10, 2011 at 02:17, Saul Wold <sgw@linux.intel.com> wrote:
> Next time, please use the create-pull-request script, which will generate a
> set of patch emails so that we can review this information via email. I will
> make a couple of additional comments below associated with each patch.

It has a problem to me since it depends on using the contrib repo and
I am using github.
...
>>       insane.bbclass: skip license checksum if LICENSE is "CLOSED"
>
> I assume you are adding this for layers and commercial work, we should never
> have CLOSED in any open layer.

Sure. I fully agree but I also think it is insane to have to provide a
fake license file to workaround it in every repository I am using
internally.

>>       cmake: add support for oe qt4 tools names
>
> Please add a comment to the patch explaining it's purpose and origin, and
> include a Signed-off-by: if appropriate. Any patches that you have modified
> or added should include the above info.

On the patch itself? Any doc describing an example of it?

I am waiting for Richard and Koen replies about my questions and will
provide updated patches for the unmerged ones.

Cheers,
Saul Wold - May 10, 2011, 6 p.m.
On 05/10/2011 05:53 AM, Otavio Salvador wrote:
> On Tue, May 10, 2011 at 02:17, Saul Wold<sgw@linux.intel.com>  wrote:
>> Next time, please use the create-pull-request script, which will generate a
>> set of patch emails so that we can review this information via email. I will
>> make a couple of additional comments below associated with each patch.
>
> It has a problem to me since it depends on using the contrib repo and
> I am using github.
> ...
Is there a reason you can't use the oe-core-contrib repo and create a 
branch there?  Can the script be modified to support github also?

It creates get another remote that we need to fetch from.

>>>        insane.bbclass: skip license checksum if LICENSE is "CLOSED"
>>
>> I assume you are adding this for layers and commercial work, we should never
>> have CLOSED in any open layer.
>
> Sure. I fully agree but I also think it is insane to have to provide a
> fake license file to workaround it in every repository I am using
> internally.
>
We agree, thanks for this change.

>>>        cmake: add support for oe qt4 tools names
>>
>> Please add a comment to the patch explaining it's purpose and origin, and
>> include a Signed-off-by: if appropriate. Any patches that you have modified
>> or added should include the above info.
>
> On the patch itself? Any doc describing an example of it?
>
Mark Hatle has (or will have shortly) a proposal out to the OE community 
for commit and patch message guidelines, as a starting point, you can 
look at the wiki:

https://wiki.yoctoproject.org/wiki/Recipe_%26_Patch_Style_Guide

This will be updated in the next 24 hours or so.

Sau!

> I am waiting for Richard and Koen replies about my questions and will
> provide updated patches for the unmerged ones.
>
> Cheers,
>
Otavio Salvador - May 10, 2011, 6:20 p.m.
On Tue, May 10, 2011 at 15:00, Saul Wold <sgw@linux.intel.com> wrote:
> Is there a reason you can't use the oe-core-contrib repo and create a branch
> there?  Can the script be modified to support github also?

Not a hard one but I prefer to have it into our repository since
people can fork it there and follow it.

> It creates get another remote that we need to fetch from.

Or it creates another remote I need to push to.

To merge you don't need to add a remote but pull from the git URL
included into the pull command line.

...
>> On the patch itself? Any doc describing an example of it?
>>
> Mark Hatle has (or will have shortly) a proposal out to the OE community for
> commit and patch message guidelines, as a starting point, you can look at
> the wiki:
>
> https://wiki.yoctoproject.org/wiki/Recipe_%26_Patch_Style_Guide

I have pushed it already. It is available on the mailing list, please
take a look.
Darren Hart - May 11, 2011, 5:39 a.m.
On 05/10/2011 11:20 AM, Otavio Salvador wrote:
> On Tue, May 10, 2011 at 15:00, Saul Wold <sgw@linux.intel.com> wrote:
>> Is there a reason you can't use the oe-core-contrib repo and create a branch
>> there?  Can the script be modified to support github also?
> 
> Not a hard one but I prefer to have it into our repository since
> people can fork it there and follow it.

I use the script for multiple repositories (poky, oe-core, meta-intel,
and various other layers). A configurable remote URL would be a
reasonable thing to add to the script. Perhaps leveraging something from
the current .git/config ? I haven't really looked into it, but if
someone else wants to I am not opposed to discussing it.

--
Darren

> 
>> It creates get another remote that we need to fetch from.
> 
> Or it creates another remote I need to push to.
> 
> To merge you don't need to add a remote but pull from the git URL
> included into the pull command line.
> 
> ...
>>> On the patch itself? Any doc describing an example of it?
>>>
>> Mark Hatle has (or will have shortly) a proposal out to the OE community for
>> commit and patch message guidelines, as a starting point, you can look at
>> the wiki:
>>
>> https://wiki.yoctoproject.org/wiki/Recipe_%26_Patch_Style_Guide
> 
> I have pushed it already. It is available on the mailing list, please
> take a look.
>