| Submitter | Andrei Gherzan |
|---|---|
| Date | Aug. 16, 2012, 10:28 p.m. |
| Message ID | <2c0055c43eae1489aee3e5e3fa2b8481d10fe0ce.1345155936.git.andrei@gherzan.ro> |
| Download | mbox | patch |
| Permalink | /patch/34755/ |
| State | New |
| Headers | show |
Comments
On Friday 17 August 2012 01:28:51 Andrei Gherzan wrote: > For machines with no hardware clock it makes no sense to have this > init stript. Moreover, we avoid a boot error in this way. > > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> > --- > meta/recipes-core/tasks/task-core-boot.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-core/tasks/task-core-boot.bb > b/meta/recipes-core/tasks/task-core-boot.bb index 6487436..2947509 100644 > --- a/meta/recipes-core/tasks/task-core-boot.bb > +++ b/meta/recipes-core/tasks/task-core-boot.bb > @@ -34,6 +34,7 @@ RDEPENDS_task-core-boot = "\ > base-files \ > base-passwd \ > busybox \ > + ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} > \ ${VIRTUAL-RUNTIME_initscripts} \ > ${@base_contains("MACHINE_FEATURES", "keyboard", > "${VIRTUAL-RUNTIME_keymaps}", "", d)} \ modutils-initscripts \ Why did this get added to task-core-boot? This is meant only to contain items that are essential for booting; I'm not sure that support for the rtc qualifies. Cheers, Paul
On Mon, Sep 3, 2012 at 11:03 AM, Paul Eggleton < paul.eggleton@linux.intel.com> wrote: > On Friday 17 August 2012 01:28:51 Andrei Gherzan wrote: > > For machines with no hardware clock it makes no sense to have this > > init stript. Moreover, we avoid a boot error in this way. > > > > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> > > --- > > meta/recipes-core/tasks/task-core-boot.bb | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/meta/recipes-core/tasks/task-core-boot.bb > > b/meta/recipes-core/tasks/task-core-boot.bb index 6487436..2947509 > 100644 > > --- a/meta/recipes-core/tasks/task-core-boot.bb > > +++ b/meta/recipes-core/tasks/task-core-boot.bb > > @@ -34,6 +34,7 @@ RDEPENDS_task-core-boot = "\ > > base-files \ > > base-passwd \ > > busybox \ > busybox-hwclock contains the hwclock init script. Before this change that script was included in busybox main package which was added to this task. I didn't want to move this package as this change would have been a different commit - to move stuff from stuff - and because i didn't want to break anything around. ag > > + ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", > d)} > > \ ${VIRTUAL-RUNTIME_initscripts} \ > > ${@base_contains("MACHINE_FEATURES", "keyboard", > > "${VIRTUAL-RUNTIME_keymaps}", "", d)} \ modutils-initscripts \ > > Why did this get added to task-core-boot? This is meant only to contain > items > that are essential for booting; I'm not sure that support for the rtc > qualifies. > > Cheers, > Paul > > -- > > Paul Eggleton > Intel Open Source Technology Centre >
Patch
diff --git a/meta/recipes-core/tasks/task-core-boot.bb b/meta/recipes-core/tasks/task-core-boot.bb index 6487436..2947509 100644 --- a/meta/recipes-core/tasks/task-core-boot.bb +++ b/meta/recipes-core/tasks/task-core-boot.bb @@ -34,6 +34,7 @@ RDEPENDS_task-core-boot = "\ base-files \ base-passwd \ busybox \ + ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \ ${VIRTUAL-RUNTIME_initscripts} \ ${@base_contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \ modutils-initscripts \
For machines with no hardware clock it makes no sense to have this init stript. Moreover, we avoid a boot error in this way. Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> --- meta/recipes-core/tasks/task-core-boot.bb | 1 + 1 file changed, 1 insertion(+)