Patchwork [meta-oe] freerdp-extension-xpunlimited: inherit gitpkgv

login
register
mail settings
Submitter Paul Eggleton
Date Aug. 15, 2012, 11:55 a.m.
Message ID <1345031739-8374-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/34627/
State Accepted
Commit 8f47ea28d928cbf4ceadb03019af87b916649d2a
Headers show

Comments

Paul Eggleton - Aug. 15, 2012, 11:55 a.m.
If you refer to GITPKGVTAG you need to inherit gitpkgv or the result is
a parsing error.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 .../freerdp/freerdp-extension-xpunlimited_git.bb   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - Aug. 15, 2012, 5:48 p.m.
On Wed, Aug 15, 2012 at 8:55 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> If you refer to GITPKGVTAG you need to inherit gitpkgv or the result is
> a parsing error.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Acked-by: 	Otavio Salvador <otavio@ossystems.com.br>
Khem Raj - Aug. 16, 2012, 4:09 a.m.
On Wed, Aug 15, 2012 at 10:48 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Aug 15, 2012 at 8:55 AM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
>> If you refer to GITPKGVTAG you need to inherit gitpkgv or the result is
>> a parsing error.

since its not working and therefore carries no baggage lets try not
use GITPKGVTAG if possible ?


>>
>> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
>
> Acked-by:       Otavio Salvador <otavio@ossystems.com.br>
>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Otavio Salvador - Aug. 16, 2012, 11:39 a.m.
On Thu, Aug 16, 2012 at 1:09 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Wed, Aug 15, 2012 at 10:48 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Wed, Aug 15, 2012 at 8:55 AM, Paul Eggleton
>> <paul.eggleton@linux.intel.com> wrote:
>>> If you refer to GITPKGVTAG you need to inherit gitpkgv or the result is
>>> a parsing error.
>
> since its not working and therefore carries no baggage lets try not
> use GITPKGVTAG if possible ?

Why it is not working? I've been using it internally a lot and it
works fine for me.

Patch

diff --git a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
index c9721f4..ed7fc4d 100644
--- a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
@@ -12,7 +12,7 @@  PV = "gitr${SRCPV}"
 PKGV = "${GITPKGVTAG}"
 PR = "r0"
 
-inherit pkgconfig cmake
+inherit pkgconfig cmake gitpkgv
 
 SRCREV = "e952627ff4c116b4ce8541c91cb96bd5422c4a0d"
 SRC_URI = "git://github.com/OSSystems/FreeRDP-Extension-XPUnlimited.git;protocol=git"