Patchwork perf on older kernels

login
mail settings
Submitter McClintock Matthew-B29882
Date Aug. 15, 2012, 4:05 a.m.
Message ID <CAEsOVNcz3rSuE6yCV1cyJh-pL4SYWtzDR4TZYDPdea-7nEo0ng@mail.gmail.com>
Download mbox | patch
Permalink /patch/34625/
State New
Headers show

Comments

McClintock Matthew-B29882 - Aug. 15, 2012, 4:05 a.m.
On Tue, Aug 14, 2012 at 10:39 PM, Bruce Ashfield
<bruce.ashfield@gmail.com> wrote:
> On Tue, Aug 14, 2012 at 11:29 PM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>>
>> On Aug 14, 2012 10:11 PM, "Bruce Ashfield" <bruce.ashfield@gmail.com> wrote:
>>>
>>> On Tue, Aug 14, 2012 at 6:39 PM, McClintock Matthew-B29882
>>> <B29882@freescale.com> wrote:
>>> > I've had to fix / hack the perf_3.4.bb recipe to get it building on my
>>> > older kernel. Should we add perf_3.0.bb recipes in oe-core or my own
>>> > layer? Or try to keep one recipe working for all versions? I have no
>>> > strong opinions.
>>>
>>> I'd prefer one recipe. Liang sent another proposal earlier for a fix
>>> that should make
>>> it work on all kernels. Just waiting to hear on that at the moment.
>>
>> I've actually got other issues...
>
> Did you post the error and I missed it .. I block marked quite a few email read
> earlier :) In that case, we can factor out common code to a .inc and keep the
> changes between versions as small as possible.

I have not posted it yet.. but it looks something like this so far...
not sure about this fix yet: https://gist.github.com/3352962


-M

>
> Cheers,
>
> Bruce
>
>>
>> -M
>>
>>>
>>> Cheers,
>>>
>>> Bruce
>>>
>>> >
>>> > -M
>>> >
>>> > _______________________________________________
>>> > Openembedded-core mailing list
>>> > Openembedded-core@lists.openembedded.org
>>> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>>
>>>
>>> --
>>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>>> thee at its end"
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/per
index 505c7b8..ff8d281 100644
--- a/meta/recipes-kernel/perf/perf_3.4.bb
+++ b/meta/recipes-kernel/perf/perf_3.4.bb
@@ -54,6 +54,7 @@  B = "${WORKDIR}/${BPN}-${PV}"
 SCRIPTING_DEFINES = "${@perf_feature_enabled('perf-scripting', '', 'NO_LIBPERL=
 TUI_DEFINES = "${@perf_feature_enabled('perf-tui', '', 'NO_NEWT=1',d)}"

+export LDFLAGS = "-ldl -lutil"
 EXTRA_OEMAKE = \
                '-C ${S}/tools/perf \
                O=${B} \
@@ -63,6 +64,7 @@  EXTRA_OEMAKE = \
                AR="${AR}" \
                prefix=/usr \
                NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 ${SCRIPTING_DEFINES} \
+               V=1 \
                '

 do_compile() {
@@ -71,7 +73,8 @@  do_compile() {

 do_install() {
        oe_runmake DESTDIR=${D} install
-       if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ]; then
+       # we are checking for this make target to be compatible with older perf
+       if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(gr
                oe_runmake DESTDIR=${D} install-python_ext
        fi
 }